patches and low-level development discussion
 help / color / mirror / code / Atom feed
From: Demi Marie Obenour <demiobenour@gmail.com>
To: "Johannes Süllner" <johannes.suellner@mailbox.org>,
	devel@spectrum-os.org
Subject: Re: [PATCH 4/4] release/live: remove B slot from live image and reduce A slot size
Date: Sun, 4 Jan 2026 16:16:23 -0500	[thread overview]
Message-ID: <025d9ef5-8e12-48e5-902a-1347fb69ece2@gmail.com> (raw)
In-Reply-To: <20260104140102.106960-8-johannes.suellner@mailbox.org>


[-- Attachment #1.1.1: Type: text/plain, Size: 1732 bytes --]

On 1/4/26 09:00, Johannes Süllner wrote:
> In contrast to the old installer, with the new installer the live image
> is not copied as a whole to the destination disk any more. Instead,
> `systemd-repart` creates partitions with the desired size, and then
> copies the individual partitions.
> 
> Signed-off-by: Johannes Süllner <johannes.suellner@mailbox.org>
> ---
>  release/live/Makefile | 4 +---
>  1 file changed, 1 insertion(+), 3 deletions(-)
> 
> diff --git a/release/live/Makefile b/release/live/Makefile
> index f5fe558..34a7d3f 100644
> --- a/release/live/Makefile
> +++ b/release/live/Makefile
> @@ -11,9 +11,7 @@ $(dest): ../../scripts/format-uuid.sh ../../scripts/make-gpt.sh ../../scripts/sf
>  	../../scripts/make-gpt.sh $@.tmp \
>  	    build/boot.fat:c12a7328-f81f-11d2-ba4b-00a0c93ec93b \
>  	    $(ROOT_FS_VERITY):verity:$$(../../scripts/format-uuid.sh "$$(dd if=$(ROOT_FS_VERITY_ROOTHASH) bs=32 skip=1 count=1 status=none)"):Spectrum_'$(VERSION).verity:162' \
> -	    $(ROOT_FS_IMAGE):root:$$(../../scripts/format-uuid.sh "$$(head -c 32 $(ROOT_FS_VERITY_ROOTHASH))"):Spectrum_'$(VERSION):20000' \
> -	    /dev/null:verity:18f2ccff-92f1-4bb1-a80e-24f76ecda90c:_empty:162 \
> -	    /dev/null:root:ec0c5ff3-f6b1-4adf-82b4-61336c4d135f:_empty:20000
> +	    $(ROOT_FS_IMAGE):root:$$(../../scripts/format-uuid.sh "$$(head -c 32 $(ROOT_FS_VERITY_ROOTHASH))"):Spectrum_'$(VERSION)'
>  	mv $@.tmp $@
>  
>  build/boot.fat: $(SYSTEMD_BOOT_EFI) $(SPECTRUM_EFI)

After this, are there any places left that pass explicit sizes to make_gpt.sh?
If not, the change to add support for this can be reverted.

Thanks for this awesome improvement!
-- 
Sincerely,
Demi Marie Obenour (she/her/hers)

[-- Attachment #1.1.2: OpenPGP public key --]
[-- Type: application/pgp-keys, Size: 7253 bytes --]

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

  reply	other threads:[~2026-01-04 21:16 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-01-04 14:00 [PATCH 1/4] tools: add spectrum-installer Johannes Süllner
2026-01-04 14:00 ` [PATCH 2/4] host/rootfs: integrate spectrum-installer Johannes Süllner
2026-01-04 14:00 ` [PATCH 3/4] release: drop combined and installer image Johannes Süllner
2026-01-04 14:00 ` [PATCH 4/4] release/live: remove B slot from live image and reduce A slot size Johannes Süllner
2026-01-04 21:16   ` Demi Marie Obenour [this message]
2026-01-04 21:13 ` [PATCH 1/4] tools: add spectrum-installer Demi Marie Obenour
2026-01-11 18:30   ` Johannes Süllner
2026-01-10 21:04 ` Alyssa Ross
2026-01-18  8:54   ` Johannes Süllner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=025d9ef5-8e12-48e5-902a-1347fb69ece2@gmail.com \
    --to=demiobenour@gmail.com \
    --cc=devel@spectrum-os.org \
    --cc=johannes.suellner@mailbox.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://spectrum-os.org/git/crosvm
	https://spectrum-os.org/git/doc
	https://spectrum-os.org/git/mktuntap
	https://spectrum-os.org/git/nixpkgs
	https://spectrum-os.org/git/spectrum
	https://spectrum-os.org/git/ucspi-vsock
	https://spectrum-os.org/git/www

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).