Re: [PATCH] fix: config support with vms

[Ville Ilvonen <ville.ilvonen@unikie.com>]

On 9/20/22 14:31, Alyssa Ross wrote:
> Ville Ilvonen <ville.ilvonen@unikie.com> writes:
> 
>> with config.nix, the build of vms fails with
>> error: undefined variable 'pkgs'
>> ..
>>    49|
>>    50|   kernel = pkgs.linux_latest.override {
>>      |            ^
>>
>> This fixes the issue for all default vms
>>
>> Signed-off-by: Ville Ilvonen <ville.ilvonen@unikie.com>
>> ---
> 
> Hi Ville, I was wondering how I'd have missed something like the default
> VMs not evaluating, but indeed I'm not able to reproduce this.  And when
> I look at the default.nix files for the default VMs, I see:
> 
> 50	  kernel = buildPackages.linux.override {
> 
> So unless I've missed something, I don't think this issue exists in the
> current upstream.  (I checked commit 3aa2f8a.)

I'm not testing with default but with new config.nix support.
Have you tested with any config.nix?

-Ville

> Although this does make me wonder /why/ buildPackages is used here —
> I think that would be incorrect in the case of cross compilation.
> Possibly it was just a hack I used to work around some pkgsStatic issue
> with the kernel at the time, and then forgot to change back.  The right
> thing to do here would be for linux_latest to be an argument to the
> function passed to callPackage.