From mboxrd@z Thu Jan 1 00:00:00 1970 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on atuin.qyliss.net X-Spam-Level: X-Spam-Status: No, score=-2.1 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,MAILING_LIST_MULTI,NICE_REPLY_A,RCVD_IN_DNSWL_NONE, SPF_HELO_NONE autolearn=unavailable autolearn_force=no version=3.4.6 Received: from atuin.qyliss.net (localhost [IPv6:::1]) by atuin.qyliss.net (Postfix) with ESMTP id 237C1610D3; Tue, 20 Sep 2022 11:34:42 +0000 (UTC) Received: by atuin.qyliss.net (Postfix, from userid 496) id 6562B61123; Tue, 20 Sep 2022 11:34:40 +0000 (UTC) Received: from mail-lj1-x231.google.com (mail-lj1-x231.google.com [IPv6:2a00:1450:4864:20::231]) by atuin.qyliss.net (Postfix) with ESMTPS id 7E0AD61121 for ; Tue, 20 Sep 2022 11:34:36 +0000 (UTC) Received: by mail-lj1-x231.google.com with SMTP id c7so2576263ljm.12 for ; Tue, 20 Sep 2022 04:34:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=unikie.com; s=google; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date; bh=kX5AzrPZldJQToMJvN4neV0vynUCLWkgsGJJazIOHJk=; b=fRdLxCV3cV7QjIEp9y7SR7sSx1sTQp6bVXtE9Illkijv/m/oYKsTZ2PWnR1QIf0nhV 4+jUmxe+gzc9/QwREXr0BTer5eRWXXt6iy+4jTdFbIZXTfuzO71EX88LNxnHnrEPvK7X AS1+MMxChMhB9XvID4lukg3nZaRAeknqPI9T6W0oHXkFdINtEZhf4ZxOIA1oJx2UGX/M dwdS00V5h/0UWlvd0CrbDPSc/DtQ4BSPfeUHFE6VeM5Ugv0L0J62eG10iWkNJB6nnC0L 3ByH18ExptaV4W4Sjjf62yNjukLI5tr43tGJVx3ZBg5nJyvFiSDztgGEPN6HW+zwWCkZ m2+w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date; bh=kX5AzrPZldJQToMJvN4neV0vynUCLWkgsGJJazIOHJk=; b=MxFTQRa4gtIt/aGKEjgNdMqfTGkM9VJuVGLgK7fpyfIKyA/fiR/Qf4rZ3tgk7HYR0v QReMxrxn663AdEc3amWsP9FITyT7rxX1AAHH/mI9fL9oo7Bx2k53sTBuu8H/Q3tkirEv dFWnn+TwkdWov5oPjeM+bkdLGCY88T0KFwoyejG75CH/9QdgVjTJ48Srh37pDfVKk0We qgLgXHYHPuygHr9gaNuQhZiZFpp60qw6N/gzFlvnLKIg6fZesQx2z79B3wFQH3wb2i88 IolSMq66QxgIL6c3cU+DCFUWD7x0V36joyH1RnEXkSDUrPEMqdfTMVSyGKjxxzKanuoo KUEg== X-Gm-Message-State: ACrzQf2TrhP3ptPhPrJov7p7adPFC76eWsbnubl4O2AcSsqhdkWJRt8M 97G5ofbqPPKsU8unww0Aqh/Q88iSAyZ6hg== X-Google-Smtp-Source: AMsMyM5KNFLco1zqZIv0ro6jYwPHZjUshGYG/ifyr7Owlj8GuU360xNG15EMqowaE9wRh4EHNDyhhw== X-Received: by 2002:a2e:bba2:0:b0:26b:e4ba:851d with SMTP id y34-20020a2ebba2000000b0026be4ba851dmr7082964lje.45.1663673675749; Tue, 20 Sep 2022 04:34:35 -0700 (PDT) Received: from [192.168.1.26] (mobile-access-567351-194.dhcp.inet.fi. [86.115.81.194]) by smtp.gmail.com with ESMTPSA id y26-20020a2e4b1a000000b0026c1cbbf461sm223727lja.80.2022.09.20.04.34.34 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 20 Sep 2022 04:34:35 -0700 (PDT) Message-ID: <1263b0d5-14f7-9650-7823-70da02f42c5d@unikie.com> Date: Tue, 20 Sep 2022 14:34:34 +0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.2.0 Subject: Re: [PATCH] fix: config support with vms To: Alyssa Ross References: <20220920110958.2548848-1-ville.ilvonen@unikie.com> <87fsgmmgdf.fsf@alyssa.is> Content-Language: en-US From: Ville Ilvonen In-Reply-To: <87fsgmmgdf.fsf@alyssa.is> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Message-ID-Hash: EZRDFSW7PVIIJAV5G2IXH3FJXEKXTQPW X-Message-ID-Hash: EZRDFSW7PVIIJAV5G2IXH3FJXEKXTQPW X-MailFrom: ville.ilvonen@unikie.com X-Mailman-Rule-Hits: header-match-devel.spectrum-os.org-0 X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-config-1 CC: devel@spectrum-os.org X-Mailman-Version: 3.3.5 Precedence: list List-Id: Patches and low-level development discussion Archived-At: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On 9/20/22 14:31, Alyssa Ross wrote: > Ville Ilvonen writes: > >> with config.nix, the build of vms fails with >> error: undefined variable 'pkgs' >> .. >> 49| >> 50| kernel = pkgs.linux_latest.override { >> | ^ >> >> This fixes the issue for all default vms >> >> Signed-off-by: Ville Ilvonen >> --- > > Hi Ville, I was wondering how I'd have missed something like the default > VMs not evaluating, but indeed I'm not able to reproduce this. And when > I look at the default.nix files for the default VMs, I see: > > 50 kernel = buildPackages.linux.override { > > So unless I've missed something, I don't think this issue exists in the > current upstream. (I checked commit 3aa2f8a.) I'm not testing with default but with new config.nix support. Have you tested with any config.nix? -Ville > Although this does make me wonder /why/ buildPackages is used here — > I think that would be incorrect in the case of cross compilation. > Possibly it was just a hack I used to work around some pkgsStatic issue > with the kernel at the time, and then forgot to change back. The right > thing to do here would be for linux_latest to be an argument to the > function passed to callPackage.