patches and low-level development discussion
 help / color / mirror / code / Atom feed
From: "Ville Ilvonen" <ville.ilvonen@unikie.com>
To: devel@spectrum-os.org
Subject: Re: [PATCH] doc: addressing architecture.adoc review changes
Date: Tue, 07 Jun 2022 06:52:00 -0000	[thread overview]
Message-ID: <165458472089.1819.1950838469655114894@atuin.qyliss.net> (raw)
In-Reply-To: <20220607064259.588734-1-ville.ilvonen@unikie.com>

Hi,

Thanks for the review comments and no worries with delay. People have their schedules. I was just following up on this contrib :-)

I was quite not sure how you would have preferred the changes implemented - amended to the original patch or additional patch. I used additional patch. As hard line wrap destroys the diff in respect to the earlier patch I addressed your review comments in the patch comments and used git-send to add the patch. I don't mind amending the changes to the original patch either, just let me know.

If there's different preferences, we could complement the contribution guidelines and include style guide.

Thanks, -Ville


  reply	other threads:[~2022-06-07  6:52 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-05-24 13:56 [PATCH] doc: architecture view with drawio to svg generation Ville Ilvonen
2022-06-03  7:15 ` Ville Ilvonen
2022-06-03 10:54 ` Alyssa Ross
2022-06-07  6:42   ` [PATCH] doc: addressing architecture.adoc review changes Ville Ilvonen
2022-06-07  6:52     ` Ville Ilvonen [this message]
2022-06-12 22:11       ` Alyssa Ross
2022-06-14  9:37         ` Ville Ilvonen
2022-06-15 10:50     ` Alyssa Ross
2022-06-15 10:56     ` Alyssa Ross

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=165458472089.1819.1950838469655114894@atuin.qyliss.net \
    --to=ville.ilvonen@unikie.com \
    --cc=devel@spectrum-os.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://spectrum-os.org/git/crosvm
	https://spectrum-os.org/git/doc
	https://spectrum-os.org/git/mktuntap
	https://spectrum-os.org/git/nixpkgs
	https://spectrum-os.org/git/spectrum
	https://spectrum-os.org/git/ucspi-vsock
	https://spectrum-os.org/git/www

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).