From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <devel-bounces@spectrum-os.org>
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on atuin.qyliss.net
X-Spam-Level: 
X-Spam-Status: No, score=-4.8 required=3.0 tests=ALL_TRUSTED,BAYES_00,
	HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,T_SCC_BODY_TEXT_LINE
	autolearn=ham autolearn_force=no version=3.4.6
Received: from atuin.qyliss.net (localhost [IPv6:::1])
	by atuin.qyliss.net (Postfix) with ESMTP id 1FD7B31615;
	Tue,  7 Jun 2022 06:52:03 +0000 (UTC)
Received: from atuin.qyliss.net (localhost [IPv6:::1])
	by atuin.qyliss.net (Postfix) with ESMTP id E926B315F7
	for <devel@spectrum-os.org>; Tue,  7 Jun 2022 06:52:00 +0000 (UTC)
Content-Type: text/plain; charset="utf-8"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Subject: Re: [PATCH] doc: addressing architecture.adoc review changes
From: "Ville Ilvonen" <ville.ilvonen@unikie.com>
To: devel@spectrum-os.org
Date: Tue, 07 Jun 2022 06:52:00 -0000
Message-ID: <165458472089.1819.1950838469655114894@atuin.qyliss.net>
In-Reply-To: <20220607064259.588734-1-ville.ilvonen@unikie.com>
References: <20220607064259.588734-1-ville.ilvonen@unikie.com>
User-Agent: HyperKitty on https://spectrum-os.org/
Message-ID-Hash: JRX4OVNBN3MHRYYOW6XYAKEVER2IILFF
X-Message-ID-Hash: JRX4OVNBN3MHRYYOW6XYAKEVER2IILFF
X-MailFrom: ville.ilvonen@unikie.com
X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency;
 loop; banned-address; member-moderation; header-match-config-1;
 header-match-devel.spectrum-os.org-0; header-match-devel.spectrum-os.org-1;
 nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size;
 news-moderation; no-subject; digests; suspicious-header
X-Mailman-Version: 3.3.5
Precedence: list
List-Id: Patches and low-level development discussion <devel.spectrum-os.org>
Archived-At: 
 <https://spectrum-os.org/lists/hyperkitty/list/devel@spectrum-os.org/message/JRX4OVNBN3MHRYYOW6XYAKEVER2IILFF/>
List-Archive: 
 <https://spectrum-os.org/lists/hyperkitty/list/devel@spectrum-os.org/>
List-Help: <mailto:devel-request@spectrum-os.org?subject=help>
List-Owner: <mailto:devel-owner@spectrum-os.org>
List-Post: <mailto:devel@spectrum-os.org>
List-Subscribe: <mailto:devel-join@spectrum-os.org>
List-Unsubscribe: <mailto:devel-leave@spectrum-os.org>

Hi,

Thanks for the review comments and no worries with delay. People have their schedules. I was just following up on this contrib :-)

I was quite not sure how you would have preferred the changes implemented - amended to the original patch or additional patch. I used additional patch. As hard line wrap destroys the diff in respect to the earlier patch I addressed your review comments in the patch comments and used git-send to add the patch. I don't mind amending the changes to the original patch either, just let me know.

If there's different preferences, we could complement the contribution guidelines and include style guide.

Thanks, -Ville