Re: [PATCH 1/2] host/rootfs: assign-devices: silence errors

[Demi Marie Obenour <demiobenour@gmail.com>]

[-- Attachment #1.1.1: Type: text/plain, Size: 1247 bytes --]

On 11/2/25 10:00, Alyssa Ross wrote:
> The expected warnings frequently confuse people.

Ideally there would be a way to suppress only "device already added
errors", but since there is not:

> Signed-off-by: Alyssa Ross <hi@alyssa.is>
> ---
>  host/rootfs/image/usr/bin/assign-devices | 5 +++++
>  1 file changed, 5 insertions(+)
> 
> diff --git a/host/rootfs/image/usr/bin/assign-devices b/host/rootfs/image/usr/bin/assign-devices
> index 1332a40..58dd3cc 100755
> --- a/host/rootfs/image/usr/bin/assign-devices
> +++ b/host/rootfs/image/usr/bin/assign-devices
> @@ -5,4 +5,9 @@
>  elglob -0 devices /sys/bus/pci/drivers/vfio-pci/????:??:??.?
>  forx -pE device { $devices }
>  
> +# This script is designed to be re-entrant and called multiple times.
> +# This means we expect to sometimes get an error due to the device
> +# already having been added.  If there's a different error,
> +# cloud-hypervisor will probably log it itself anyway.
> +redirfd -w 2 /dev/null
>  ch-remote --api-socket /run/vm/by-name/sys.netvm/vmm add-device path=${device}
> 
> base-commit: e0f5aad7901d150b1abe381ffd99d554e65e758b

Reviewed-by: Demi Marie Obenour <demiobenour@gmail.com>
-- 
Sincerely,
Demi Marie Obenour (she/her/hers)

[-- Attachment #1.1.2: OpenPGP public key --]
[-- Type: application/pgp-keys, Size: 7253 bytes --]

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 833 bytes --]