From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.3 (2019-12-06) on atuin X-Spam-Level: X-Spam-Status: No, score=-1.6 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, RCVD_IN_DNSWL_LOW,RCVD_IN_MSPIKE_H4,RCVD_IN_MSPIKE_WL,SPF_HELO_PASS autolearn=unavailable autolearn_force=no version=3.4.3 Received: by atuin.qyliss.net (Postfix, from userid 496) id 3FBE8241E4; Tue, 2 Jun 2020 00:37:24 +0000 (UTC) Received: from [127.0.1.1] (localhost [IPv6:::1]) by atuin.qyliss.net (Postfix) with ESMTP id 69ABC241DB; Tue, 2 Jun 2020 00:37:19 +0000 (UTC) Received: by atuin.qyliss.net (Postfix, from userid 496) id 14A96241CF; Tue, 2 Jun 2020 00:37:18 +0000 (UTC) Received: from wout2-smtp.messagingengine.com (wout2-smtp.messagingengine.com [64.147.123.25]) by atuin.qyliss.net (Postfix) with ESMTPS id 89A2624202 for ; Tue, 2 Jun 2020 00:37:13 +0000 (UTC) Received: from compute7.internal (compute7.nyi.internal [10.202.2.47]) by mailout.west.internal (Postfix) with ESMTP id EDF4CA0C; Mon, 1 Jun 2020 20:37:10 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute7.internal (MEProxy); Mon, 01 Jun 2020 20:37:11 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=alyssa.is; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; s=fm3; bh=NzRvNBbzlPJx3 PvSiF0LQD6t59mssJe8sSSAPtu+pUw=; b=FTQJOwYexmSertyyzeCT4Wiq/jp76 eKKAS1hyXBrdqm+FWPYPQ0q6UfHcYGeivSRiXDvfyDQ2RFty1Ol27A/MW0/KLkQH 4snURHMkSP8WhBa58abJ0hnWQWJQp5jxC5RYTjcs0fXLGzlaT9eTynrsJCtiND66 BWIQr8QpwPNAE9cOCsM3Ecvo5obXz0ZcgRLKk2CiqVWvwvP0nvqAjK0khw2qy035 ehNPSsmSpcKmCely725PZ+lc+jSLU+MK45CuvwAKL0IY80awbdyCll8NvzLtyU7+ I5aBXyLQ42K9C4hzvdMhl92qzszL0i1q3CUBd87hR/cFyGHstqRRbMBCg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:date:from :in-reply-to:message-id:mime-version:references:subject:to :x-me-proxy:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s= fm2; bh=NzRvNBbzlPJx3PvSiF0LQD6t59mssJe8sSSAPtu+pUw=; b=TsIRxJ72 yI+Gy58LAMwEbQYJNQl3WHsC3CyU6sOrMo48qblgcwcYCGaJ+LhFrN1l2EYaBGis AMtR+sq/iFwI6N9AkcMo9kX6aYum6Z89xLIog5ROszSbKeVU3eduFoD+XGeZ0abF 826+97qzgh6DpNF74YuxLaN85n86dZoBqaeUQXsDqYbanbV9OyOgT7vbKoUj5sFn 1we6ySoYI48vzQZG86oYSvSX2J+q+xMEWwg1CSwNskZtJDw4/QiutAnkA/ZRSPIW H/FOvy9yAOa2+qZFtK5O4ULdzqSfx3o7GUTzfUvKyDlsIDGREn3SNRiIfGR1JmA+ VtqYMZ2YAPWMvA== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduhedrudefiedgfeehucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucenucfjughrpefhvffufffkofgjfhgggfestdhqre dtredttdenucfhrhhomheptehlhihsshgrucftohhsshcuoehhihesrghlhihsshgrrdhi sheqnecuggftrfgrthhtvghrnhepfeeiheetieejteffteekhfeiffdtgfethfduteeufe efteefvddtleetleeguefgnecuffhomhgrihhnpehpsgdrtggtnecukfhppeejledrvdef hedrudduledrudelgeenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrih hlfhhrohhmpehqhihlihhsshesgidvvddtrdhqhihlihhsshdrnhgvth X-ME-Proxy: Received: from x220.qyliss.net (p4feb77c2.dip0.t-ipconnect.de [79.235.119.194]) by mail.messagingengine.com (Postfix) with ESMTPA id 1DBA6328005D; Mon, 1 Jun 2020 20:37:10 -0400 (EDT) Received: by x220.qyliss.net (Postfix, from userid 1000) id 34ACB8AE; Tue, 2 Jun 2020 00:37:09 +0000 (UTC) From: Alyssa Ross To: 7c6f434c@mail.ru, cole.e.helbling@outlook.com Subject: [PATCH platform2] vm_tools: proto: fix parallel build Date: Tue, 2 Jun 2020 00:37:09 +0000 Message-Id: <20200602003709.20514-1-hi@alyssa.is> X-Mailer: git-send-email 2.26.2 In-Reply-To: <87367e9w9y.fsf@alyssa.is> References: <87367e9w9y.fsf@alyssa.is> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Message-ID-Hash: KVWEY3RYBAUWF5WH3JQ5CWEIDNHGEF2J X-Message-ID-Hash: KVWEY3RYBAUWF5WH3JQ5CWEIDNHGEF2J X-MailFrom: qyliss@x220.qyliss.net X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-config-1; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; suspicious-header CC: devel@spectrum-os.org X-Mailman-Version: 3.3.0 Precedence: list List-Id: Patches and low-level development discussion Archived-At: List-Archive: List-Help: List-Post: List-Subscribe: List-Unsubscribe: fuzzer-protos depends on vm-crash-rpcs, but this dependency wasn't declared, causing build failures like the following: [26/52] CXX obj/out/Release/gen/include/vm_protos/proto_bindings/libfuzzer-= protos.fuzzer.grpc.pb.o FAILED: obj/out/Release/gen/include/vm_protos/proto_bindings/libfuzzer-prot= os.fuzzer.grpc.pb.o c++ -MMD -MF obj/out/Release/gen/include/vm_protos/proto_bindings/libfuzzer= -protos.fuzzer.grpc.pb.o.d -D_LARGEFILE_SOURCE -D_LARGEFILE64_SOURCE -D_FIL= E_OFFSET_BITS=3D64 -Igen/include -I../../common-mk -I/usr/include -Igen -Ig= en -Igen -Igen -Wall -Wunused -Wno-unused-parameter -Wunreachable-code -ggd= b3 -fstack-protector-strong -Wformat=3D2 -fvisibility=3Dinternal -Wa,--noex= ecstack -Wimplicit-fallthrough -Werror --sysroot=3D -fPIE -fvisibility=3Dde= fault -pthread -I/nix/store/pjl2q3lny3c18ypqjcv0q3akyq89hg2i-grpc-1.28.1/in= clude -I/nix/store/hya0y6slws66h99njc2yiz02irfv4n62-openssl-1.1.1g-dev/incl= ude -I/nix/store/mfpg3sk5vk9rm99hbpmd3dgvxqybd391-protobuf-3.8.0/include -p= thread -I/nix/store/pjl2q3lny3c18ypqjcv0q3akyq89hg2i-grpc-1.28.1/include -I= /nix/store/hya0y6slws66h99njc2yiz02irfv4n62-openssl-1.1.1g-dev/include -I/n= ix/store/mfpg3sk5vk9rm99hbpmd3dgvxqybd391-protobuf-3.8.0/include -Wno-unrea= chable-code -std=3Dgnu++14 -fno-exceptions -fno-unwind-tables -fno-asynchro= nous-unwind-tables -Wno-psabi -c gen/include/vm_protos/proto_bindings/fuzze= r.grpc.pb.cc -o obj/out/Release/gen/include/vm_protos/proto_bindings/libfuz= zer-protos.fuzzer.grpc.pb.o In file included from gen/include/vm_protos/proto_bindings/fuzzer.grpc.pb.c= c:5: gen/include/vm_protos/proto_bindings/fuzzer.pb.h:38:10: fatal error: vm_cra= sh.pb.h: No such file or directory 38 | #include "vm_crash.pb.h" | ^~~~~~~~~~~~~~~ compilation terminated. ninja: build stopped: subcommand failed. Reported-by: Cole Helbling --- > Michael Raskin <7c6f434c@mail.ru> writes: >=20 >>>>> In file included from gen/include/vm_protos/proto_bindings/fuzzer= .grpc.pb.cc:5: >>>>> gen/include/vm_protos/proto_bindings/fuzzer.pb.h:38:10: fatal err= or: vm_crash.pb.h: No such file or directory >>>>> 38 | #include "vm_crash.pb.h" >>>>> | ^~~~~~~~~~~~~~~ >>>>> compilation terminated. >>>>> ninja: build stopped: subcommand failed. >>>>> builder for '/nix/store/8asskz117p1nhirxaa4pwa0caayxg6c5-vm_proto= s-83.13020.0.0-rc1.drv' failed with exit code 1 >> >> The first thing I would check if the same derivation builds elsewhere >> is the job count. Next step is checking the checksums of build >> inputs??? >=20 > I job count is unlikely. On one computer I built with 4 cores, on the > other I built with 48. But Cole, it might be worth trying with a single > core. >=20 > Is there an easy way to get checksums of built inputs, or do I need to > do that manually? >=20 > Michael, does it build for you? Looks like it was a parallelism bug after all. Interesting that Cole=20 saw it and I didn't, even with my -j48 build. Cole, could you please test this patch? The easiest way is probably to save the email, and then add=20 platform2Patches =3D [ /path/to/email ]; to the vm_protos expression. vm_tools/proto/BUILD.gn | 1 + 1 file changed, 1 insertion(+) diff --git a/vm_tools/proto/BUILD.gn b/vm_tools/proto/BUILD.gn index 713b81853..a25265cab 100644 --- a/vm_tools/proto/BUILD.gn +++ b/vm_tools/proto/BUILD.gn @@ -70,6 +70,7 @@ proto_library("fuzzer-protos") { deps =3D [ ":container-rpcs", ":tremplin-rpcs", + ":vm-crash-rpcs", ] sources =3D [ "${proto_in_dir}/fuzzer.proto", --=20 2.26.2