From: Alyssa Ross <hi@alyssa.is>
To: Cole Helbling <cole.e.helbling@outlook.com>
Cc: devel@spectrum-os.org
Subject: Re: [PATCH nixpkgs] spectrumPackages.rootfs: fix custom path entries
Date: Tue, 16 Mar 2021 00:48:04 +0000 [thread overview]
Message-ID: <20210316004804.mmiptolt6qt7liub@eve.qyliss.net> (raw)
In-Reply-To: <SJ0PR03MB5581AE9D3E3599E845CC1CA0B36C9@SJ0PR03MB5581.namprd03.prod.outlook.com>
[-- Attachment #1: Type: text/plain, Size: 775 bytes --]
On Mon, Mar 15, 2021 at 04:11:42PM -0700, Cole Helbling wrote:
> On Mon Mar 15, 2021 at 6:58 AM PDT, Alyssa Ross wrote:
> > Stage 1 was supposed to be able to take a list of PATH entries to
> > prepend to the default PATH, but it didn't do anything with them.
> > Now, it properly adds them to the PATH as early as possible during
> > boot.
> >
> > This mechanism isn't currently used anywhere, but is very useful for
> > debugging.
> > ---
> > pkgs/os-specific/linux/spectrum/rootfs/generic.nix | 3 ++-
> > pkgs/os-specific/linux/spectrum/rootfs/stage1.nix | 7 +++++--
> > 2 files changed, 7 insertions(+), 3 deletions(-)
>
> Stuff that helps debugging is good!
>
> Reviewed-by: Cole Helbling <cole.e.helbling@outlook.com>
Committed as d85408e1193. Thanks for the review!
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
prev parent reply other threads:[~2021-03-16 0:48 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-15 13:58 [PATCH nixpkgs] spectrumPackages.rootfs: fix custom path entries Alyssa Ross
2021-03-15 23:11 ` Cole Helbling
2021-03-16 0:48 ` Alyssa Ross [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210316004804.mmiptolt6qt7liub@eve.qyliss.net \
--to=hi@alyssa.is \
--cc=cole.e.helbling@outlook.com \
--cc=devel@spectrum-os.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://spectrum-os.org/git/crosvm
https://spectrum-os.org/git/doc
https://spectrum-os.org/git/mktuntap
https://spectrum-os.org/git/nixpkgs
https://spectrum-os.org/git/spectrum
https://spectrum-os.org/git/ucspi-vsock
https://spectrum-os.org/git/www
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).