From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on atuin.qyliss.net X-Spam-Level: X-Spam-Status: No, score=-4.6 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,RCVD_IN_DNSWL_LOW,RCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL,SPF_HELO_PASS autolearn=unavailable autolearn_force=no version=3.4.4 Received: by atuin.qyliss.net (Postfix, from userid 496) id 68CF73FE6; Tue, 16 Mar 2021 00:48:37 +0000 (UTC) Received: from [127.0.0.1] (localhost [IPv6:::1]) by atuin.qyliss.net (Postfix) with ESMTP id 85EF83FC4; Tue, 16 Mar 2021 00:48:16 +0000 (UTC) Received: by atuin.qyliss.net (Postfix, from userid 496) id 916463FAE; Tue, 16 Mar 2021 00:48:12 +0000 (UTC) Received: from out3-smtp.messagingengine.com (out3-smtp.messagingengine.com [66.111.4.27]) by atuin.qyliss.net (Postfix) with ESMTPS id 662C13FAC for ; Tue, 16 Mar 2021 00:48:08 +0000 (UTC) Received: from compute3.internal (compute3.nyi.internal [10.202.2.43]) by mailout.nyi.internal (Postfix) with ESMTP id 186085C00EC; Mon, 15 Mar 2021 20:48:07 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute3.internal (MEProxy); Mon, 15 Mar 2021 20:48:07 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=alyssa.is; h= date:from:to:cc:subject:message-id:references:mime-version :content-type:in-reply-to; s=fm2; bh=Z1yUI9ckdc6wS5hSKVbaMhAyu/E H5vyBOBd6Ff6Q5X4=; b=GIxuVJjM9Ti80PDxEuol0peQp7LLb/eMJoWHCbWmQYZ sr++hGRmVPzuMIkH2MVPBBL84a/Bxm20s56URj13q77DLTcs1Dj7Eb0X0he0tm1A UTQMBqQJfa3zmKr+v+b2BrX1VnmlS2Hfr8XkyYbE/jJhEs/cj/lofGTiPF42JZGA fUIF8FlkF6/yRw0w9me+z/xq/0x9x/r5I1N6fiNxbegw5FpRrkypnUs90m3Uvbq6 DSE5WpazGj6Sr9ngRqnSUNOSwzAOFyysHlNzyk2HCWEaDfRMnPtvSYQunibeLaES O8ZKvbLh0NmeOjku0Nd7BtG5VhJIsVMrh3VvpIbev/w== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm2; bh=Z1yUI9 ckdc6wS5hSKVbaMhAyu/EH5vyBOBd6Ff6Q5X4=; b=KTWUhxVSPcaW2RGHPAbk3q esmv9XaEgNl2slk6ylDaKb+WnpaNMENEq28bs2f9asT+q6I/4PMDsoW4OA6m8qos e0ndz36YYqHWd+QXULmLT5aWOINWCsvP5eLXOMDhsxi4BQu9pcwSC6hfQwc5B5ai 5YU642AqRaTtbxG3Ob5lcE51LFwftiKCPSarJojKyTE5lyAV2X6bMahw/ZtiCUf/ XaLca+cp5qB1nFHQUZ0Byb29Bf4R2+2te/ZbfxwXeu+HpwS13t/i2+Uwzu4RNiW6 L0hDctxl5eFoVJxlETmVgaafPCliWEZe5ar9OniWo1L0thkr+ltZhMV4cFOKYx9w == X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduledrudefuddgvdegucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhepfffhvffukfhfgggtuggjsehgtddtredttddvnecuhfhrohhmpeetlhihshhs rgcutfhoshhsuceohhhisegrlhihshhsrgdrihhsqeenucggtffrrghtthgvrhhnpeeuff egffdtvdffiedttefggfehtdfgudfhfffgteefgfdugeegveffieffudduvdenucfkphep keegrddukeegrddvfedvrddukedtnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrg hmpehmrghilhhfrhhomhepqhihlhhishhssegvvhgvrdhqhihlihhsshdrnhgvth X-ME-Proxy: Received: from eve.qyliss.net (p54b8e8b4.dip0.t-ipconnect.de [84.184.232.180]) by mail.messagingengine.com (Postfix) with ESMTPA id 38128108005F; Mon, 15 Mar 2021 20:48:06 -0400 (EDT) Received: by eve.qyliss.net (Postfix, from userid 1000) id 10E86F24; Tue, 16 Mar 2021 00:48:04 +0000 (UTC) Date: Tue, 16 Mar 2021 00:48:04 +0000 From: Alyssa Ross To: Cole Helbling Subject: Re: [PATCH nixpkgs] spectrumPackages.rootfs: fix custom path entries Message-ID: <20210316004804.mmiptolt6qt7liub@eve.qyliss.net> References: <20210315135820.6375-1-hi@alyssa.is> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="ei2hdpwnfx2hlb56" Content-Disposition: inline In-Reply-To: Message-ID-Hash: LVK2JVDMZVUV6HMG4MMLWGK4DSRFP2N6 X-Message-ID-Hash: LVK2JVDMZVUV6HMG4MMLWGK4DSRFP2N6 X-MailFrom: qyliss@eve.qyliss.net X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-config-1; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; suspicious-header CC: devel@spectrum-os.org X-Mailman-Version: 3.3.1 Precedence: list List-Id: Patches and low-level development discussion Archived-At: List-Archive: List-Help: List-Post: List-Subscribe: List-Unsubscribe: --ei2hdpwnfx2hlb56 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Mon, Mar 15, 2021 at 04:11:42PM -0700, Cole Helbling wrote: > On Mon Mar 15, 2021 at 6:58 AM PDT, Alyssa Ross wrote: > > Stage 1 was supposed to be able to take a list of PATH entries to > > prepend to the default PATH, but it didn't do anything with them. > > Now, it properly adds them to the PATH as early as possible during > > boot. > > > > This mechanism isn't currently used anywhere, but is very useful for > > debugging. > > --- > > pkgs/os-specific/linux/spectrum/rootfs/generic.nix | 3 ++- > > pkgs/os-specific/linux/spectrum/rootfs/stage1.nix | 7 +++++-- > > 2 files changed, 7 insertions(+), 3 deletions(-) > > Stuff that helps debugging is good! > > Reviewed-by: Cole Helbling Committed as d85408e1193. Thanks for the review! --ei2hdpwnfx2hlb56 Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCAAdFiEEH9wgcxqlHM/ARR3h+dvtSFmyccAFAmBQAEIACgkQ+dvtSFmy ccBiYQ/+M9M5Khkpg6G6ze5X2KruTyqAGNTc0Jpz6rBuy2RSGm2Kg+ksTzq4dxDM hsxVXK3fKA6yaYYJV8W0Iiw8fxG9zEQPDIhMgw9g2wc22+WdA7WWCzO0zCUSWUbI 07Brk3+8dbfk3TVKXj4M3Jm4XR/W1sxFB022iE+KnbxrlDSh+JdTjBpLAkXWVSv2 EPi2dSYuoaBoPK2tluIiqAW6Cn2MmBIUM164CX9BBG2PfSf6pw3Hk7hepMpWcX3c 93sFe5kM3r5vdU48wxuICTJYpvQKddXcKQDVPLWwSzw+VdrVNY2irzsiPiAopei9 MZaBKus75WxJKH07X162CWmV23/2nSQ+iuchy7En1g0/5JKffSFdWoO8AmdAXp6P b23mJQnV07V956pZLvB3K56JQRxz9SIKw4w5pYrXRyKmM5bCDahMw23VFOvcV4qJ eRaQTcnm2qpMPpOYkhXbcdChBtPt0hgj0xc0ZgT5Eu9fxIdBnFoFm53lk6a9FDCC Nj1orxFb58UQuco9UQEQpEN0Jr/lJBx4w/CdqlmBIk3/9YoXUFGi5LY9ll+wdiTN uD7SG72AqV1TJCNDcO/4cHEldYcendeNl/ZDkwItuGAmnXzNvN4ILScUZMNz+wZX +728h4IgfwWjDvnoVVgIGBlAii2+OqoDLj8XCMBFBs1pQj6VkX8= =jwng -----END PGP SIGNATURE----- --ei2hdpwnfx2hlb56--