From: Alyssa Ross <hi@alyssa.is>
To: Cole Helbling <cole.e.helbling@outlook.com>
Cc: devel@spectrum-os.org
Subject: Re: [PATCH nixpkgs] spectrumPackages.rootfs: add /sys
Date: Tue, 16 Mar 2021 00:50:20 +0000 [thread overview]
Message-ID: <20210316005020.byzvhsksv253aus4@eve.qyliss.net> (raw)
In-Reply-To: <SJ0PR03MB558113018E78FF41968A69A5B36C9@SJ0PR03MB5581.namprd03.prod.outlook.com>
[-- Attachment #1: Type: text/plain, Size: 1127 bytes --]
On Mon, Mar 15, 2021 at 04:09:20PM -0700, Cole Helbling wrote:
> On Mon Mar 15, 2021 at 7:53 AM PDT, Alyssa Ross wrote:
> > On Mon, Mar 15, 2021 at 01:55:40PM +0000, Alyssa Ross wrote:
> > > Programs assume this and it's useful to have.
> > > ---
> > > pkgs/os-specific/linux/spectrum/rootfs/generic.nix | 2 +-
> > > pkgs/os-specific/linux/spectrum/rootfs/stage1.nix | 1 +
> > > 2 files changed, 2 insertions(+), 1 deletion(-)
> >
> > I already posted this patch too[1]. Oops.
> >
> > Although it could still use a review...
> >
> > [1]:
> > https://spectrum-os.org/lists/archives/spectrum-devel/20200825164845.8850-1-hi@alyssa.is/
>
> Unable to find the old mail in my box, so I'll just send it here:
No problem. :)
> Reviewed-by: Cole Helbling <cole.e.helbling@outlook.com>
Committed as 3eb1b848b6a. Thanks for the review!
BTW, just in case you don't know this trick:
When I can't find an email, I find the thread overview on public-inbox
and download it with the "mbox.gz" button. Then I just need to
gzip -d t.mbox.gz
neomutt -f t.mbox
and I'm looking at the thread.
I assume aerc has a similar flag.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2021-03-16 0:50 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-15 13:55 [PATCH nixpkgs] spectrumPackages.rootfs: add /sys Alyssa Ross
2021-03-15 14:53 ` Alyssa Ross
2021-03-15 23:09 ` Cole Helbling
2021-03-16 0:50 ` Alyssa Ross [this message]
-- strict thread matches above, loose matches on Subject: below --
2020-08-25 16:48 Alyssa Ross
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210316005020.byzvhsksv253aus4@eve.qyliss.net \
--to=hi@alyssa.is \
--cc=cole.e.helbling@outlook.com \
--cc=devel@spectrum-os.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://spectrum-os.org/git/crosvm
https://spectrum-os.org/git/doc
https://spectrum-os.org/git/mktuntap
https://spectrum-os.org/git/nixpkgs
https://spectrum-os.org/git/spectrum
https://spectrum-os.org/git/ucspi-vsock
https://spectrum-os.org/git/www
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).