From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on atuin.qyliss.net X-Spam-Level: X-Spam-Status: No, score=-4.6 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,RCVD_IN_DNSWL_LOW,SPF_HELO_PASS autolearn=unavailable autolearn_force=no version=3.4.4 Received: by atuin.qyliss.net (Postfix, from userid 496) id 661E1B924; Sun, 21 Mar 2021 14:33:38 +0000 (UTC) Received: from [127.0.0.1] (localhost [IPv6:::1]) by atuin.qyliss.net (Postfix) with ESMTP id 8E05CB8BE; Sun, 21 Mar 2021 14:33:24 +0000 (UTC) Received: by atuin.qyliss.net (Postfix, from userid 496) id 79B36B8BA; Sun, 21 Mar 2021 14:33:22 +0000 (UTC) Received: from out3-smtp.messagingengine.com (out3-smtp.messagingengine.com [66.111.4.27]) by atuin.qyliss.net (Postfix) with ESMTPS id 1A544B8B8 for ; Sun, 21 Mar 2021 14:33:18 +0000 (UTC) Received: from compute3.internal (compute3.nyi.internal [10.202.2.43]) by mailout.nyi.internal (Postfix) with ESMTP id B9D575C00D7; Sun, 21 Mar 2021 10:33:16 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute3.internal (MEProxy); Sun, 21 Mar 2021 10:33:16 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=alyssa.is; h= date:from:to:cc:subject:message-id:references:mime-version :content-type:in-reply-to; s=fm2; bh=MCCrOVUO/Xpq7yWcjIgMzsm53Ck LJnvL5LThke3zEfw=; b=Sbuvc0wR1UA4Rm1UeerZeA/jqmIFUXOx7iHyGcNwmEt wBe1Jxn+uvgrawpRrDzDlEvRSczMvyFqqvCzP23gvVr27A3kUQuoD8vIis1JOTc0 khJ8kIUGFEWTFoAr5lMG4X8O/62cbyBsMakb+GgmIjG7+p4ZYYJKuO9065WTsh44 skXwhdVsQVirxf3C56NVxYm0gl17tb/L1IVrp+pY4tNt6Oz242LFJSTJDAO8u7UU L/EyPnn6TtuUpfyd8d/M+bwn3RqJ/ZWO4TwTRKMQQceagmX/e8j9p0EwMYOgN8EU K9kt5sG5b8qP0KcqX+KnWBiGmJOFCdy2RtlWZMvMTkQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm2; bh=MCCrOV UO/Xpq7yWcjIgMzsm53CkLJnvL5LThke3zEfw=; b=YOfGPxQ3K5T8J4ZCtFUdpe 2uz7HvSs+omjIu6sWBkktrHdeNs9gRiyXUQgBy9H/tD5LlMSuUK2pgiwq/r0/aMk UDbQAL5p30Z+DHdBtJbdjmZ5hF6gYCCzgEvApMaEBNL0ySZCDpmvwTjm9FIjNtEd 08iADw17h9cqDuLiGMv1rvUsDxJyXWx6IgzTv/SgABtOtTrpdfsytQEaWvmxG2po Wssz89Kk8OiKharUx+obCqI02CrSu6qW0Qp5uGvunNAYwBV7ey9xKEtwkghDEpkq +eahGrde9/5RE1Sr0RWZx+T3Nq2WiFe1R02GehQzjo/f09YBJNkObBG5BbRGqg/Q == X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduledrudegvddgieeiucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhepfffhvffukfhfgggtuggjsehgtddtredttddvnecuhfhrohhmpeetlhihshhs rgcutfhoshhsuceohhhisegrlhihshhsrgdrihhsqeenucggtffrrghtthgvrhhnpeeuff egffdtvdffiedttefggfehtdfgudfhfffgteefgfdugeegveffieffudduvdenucfkphep jeelrddvfedurddvgeefrdekudenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmh epmhgrihhlfhhrohhmpehqhihlihhsshesvghvvgdrqhihlhhishhsrdhnvght X-ME-Proxy: Received: from eve.qyliss.net (p4fe7f351.dip0.t-ipconnect.de [79.231.243.81]) by mail.messagingengine.com (Postfix) with ESMTPA id 3AEFA2400CC; Sun, 21 Mar 2021 10:33:16 -0400 (EDT) Received: by eve.qyliss.net (Postfix, from userid 1000) id 36A4311D9; Sun, 21 Mar 2021 14:33:14 +0000 (UTC) Date: Sun, 21 Mar 2021 14:33:14 +0000 From: Alyssa Ross To: Cole Helbling Subject: Re: [PATCH ucspi-vsock 7/7] Extract vsockserver-socketbinder and vsockserverd Message-ID: <20210321143314.xmnminxra7vn6bvj@eve.qyliss.net> References: <20210320202441.m4leazkzrgduofwz@eve.qyliss.net> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="wklcigdeeehd7fpk" Content-Disposition: inline In-Reply-To: Message-ID-Hash: JBDWF6HPN3X4KVGHZWIJ7KGMKQJSKI2I X-Message-ID-Hash: JBDWF6HPN3X4KVGHZWIJ7KGMKQJSKI2I X-MailFrom: qyliss@eve.qyliss.net X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-config-1; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; suspicious-header CC: devel@spectrum-os.org X-Mailman-Version: 3.3.1 Precedence: list List-Id: Patches and low-level development discussion Archived-At: List-Archive: List-Help: List-Post: List-Subscribe: List-Unsubscribe: --wklcigdeeehd7fpk Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Sat, Mar 20, 2021 at 07:52:00PM -0700, Cole Helbling wrote: > On Sat Mar 20, 2021 at 1:24 PM PDT, Alyssa Ross wrote: > > On Thu, Mar 18, 2021 at 08:39:31PM -0700, Cole Helbling wrote: > > > > + if (listen(fd ,40) == -1) > > > > > > Minor formatting nit (comma, then space); but also, what is `40` > > > representative of? Should this be `#define`d, or otherwise assigned to > > > some descriptive name? > > > > Looks like the next thing I should do after this is set up clang-tidy or > > something. ;) > > > > It's the backlog parameter, i.e. the minimum[1] number of connections > > the kernel should allow to queue up before it starts rejecting them. > > > > Would the following additional diff make you happy? :) > > (I won't bother resending the whole patch with it applied; for the > > purposes of reviewing just pretend this is part of the patch I sent.) > > Yep, looks good to me! Though if I'm being greedy, maybe add the above > explanation as a comment above the new variable? ("It's the backlog > [...]") I think I don't want to get too much into explaining things listen(2) will explain better than me (but you were right about giving this number a name)! > Entire series looks good as well: > > Reviewed-by: Cole Helbling Thanks! To ssh://atuin/home/spectrum/git/ucspi-vsock.git e718a97..a452f16 master -> master --wklcigdeeehd7fpk Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCAAdFiEEH9wgcxqlHM/ARR3h+dvtSFmyccAFAmBXWSYACgkQ+dvtSFmy ccBY5A//WgFLzj+1RXBv9eMlTOzCLQaxfC3fD1heNLb2/RuD/OhkxeV3G8NrRIT1 lVj6Ut6NWbId3Ojdv3b+eYID+r4iIKM+h/c7yQw0boUg2K64WovvDnNwupcHFXBn HqKZ+6//0aeY+bmRktnPCPKYWpDgSdTmZhemTGYsoZ9pXHlzvePHPrA9x1t28m0L UuvSArVEwJbnh4YsadaSMAjsN4Oe7+J0bVZrRHPp1H/JHeor1SitVlMC8Xipa8gS CbLoZpimwqPo9IPGG+4/EZ90Zg7LR+AwUmloeEZJaTHzwZsnnTvuTg6Ue+ubS18g jVW0SjlYSdZISzf93Dte4TJrlaA3ybGT4FmZYAFxfH437HJlMuIYeMrr445tv1nL zvnzD2yFgQJE7PsY5FtH4M3SaP0R52MnhYbADl+M9WgUCP39zZXXZUIT3UET9vHR EyCiaeuujhUa0BVbDt6OV2Chr7D4oycgIyu0gy68mJCoIlNBWn2gxRV5yS3kEs59 Dv3E8Kf7t+Vhy+XO1duZFvMT8Oa6jw6uuh99GDZ8SJvcptAAylRvIrIjuSnqxtFt mwZutNF5bSg/+wnkXmkj5cKMH1mhWionTRUs2p2+4OxnYUnHpDA25j2ElYVNy/Zd wBHbo2+qopcQlEiOouKwnbe3Ru3LbJjcp4s+6r2X0ygmT7MHXHQ= =hsfE -----END PGP SIGNATURE----- --wklcigdeeehd7fpk--