From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on atuin.qyliss.net X-Spam-Level: X-Spam-Status: No, score=-4.6 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,RCVD_IN_DNSWL_LOW,SPF_HELO_PASS autolearn=unavailable autolearn_force=no version=3.4.4 Received: by atuin.qyliss.net (Postfix, from userid 496) id 80F26B9A8; Sun, 21 Mar 2021 14:39:13 +0000 (UTC) Received: from [127.0.0.1] (localhost [IPv6:::1]) by atuin.qyliss.net (Postfix) with ESMTP id 2EB14B8F8; Sun, 21 Mar 2021 14:38:57 +0000 (UTC) Received: by atuin.qyliss.net (Postfix, from userid 496) id 445EBB8F1; Sun, 21 Mar 2021 14:38:55 +0000 (UTC) Received: from out3-smtp.messagingengine.com (out3-smtp.messagingengine.com [66.111.4.27]) by atuin.qyliss.net (Postfix) with ESMTPS id 044A1B93E for ; Sun, 21 Mar 2021 14:38:52 +0000 (UTC) Received: from compute3.internal (compute3.nyi.internal [10.202.2.43]) by mailout.nyi.internal (Postfix) with ESMTP id 397075C00D2; Sun, 21 Mar 2021 10:38:52 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute3.internal (MEProxy); Sun, 21 Mar 2021 10:38:52 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=alyssa.is; h= date:from:to:cc:subject:message-id:references:mime-version :content-type:in-reply-to; s=fm2; bh=Ftco2LgcDz6n4SxNMC8gN8Crzjy bFIxyh+OVWyeM2cE=; b=kBVDq6d8VUQkBFJV914CvHiW1uLFPUJAsWCxtm1sqPk 9aw2stkkddF1w8oV0s+HCDM3XjrIhM0iCJKED8DLnaeaI0CKkIKFuKdfq+Qfbavm G1TFXnmdYF332lAxAJgFJmhHBqOhwVHgpXDrcUPt4uP7p7URB1leO9qtKeWLuOxR Ynv25n4BNkb1f4Lw1a6t4DUEz4AxR/yb1HFNlIpufd7bTq6GhVEK98cRI+ShwvlG j0Vw6ipuDHQUGbfB6hPeBAvWrtc1eWMzdYeRvMO6Puen6z87BokuTM6KbMKnF35U KNdpZCkzj+cDgJyvPsEGDe8euHVEieE4Vm2jALT1tCg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm2; bh=Ftco2L gcDz6n4SxNMC8gN8CrzjybFIxyh+OVWyeM2cE=; b=vrv+twNUTWZERvm6ZdwWb5 w6CYLyiTs+fW/xgX2Xq8UKn4A8UQyliVV/ZVyEwNeFWHsxftulTFOWiK+QR9/Woc mZ7suNco6TSTDWghVRTHPZ0V7fjenJW633RQndKjSt1piiYteUTDepm6NJiMcSBk BHHpuANBQ+adWFYSxZe5UuxYlu5EqwxLYbTTutuZT1pMsLD9HLR3Hl8sYORntbrC 8xOrIm8CAn7vQyaoAdcJRvHMJvttJwBrL/qlSC4Cb7WukhaSXfQpv8s6HpQNqQz0 JDW8LCMSAGvl+C6CyrVionE8sS646utkTYMQWuPF5vg5zDIYrcsF2faAFsbFw+vw == X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduledrudegvddgieejucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhepfffhvffukfhfgggtuggjsehgtddtredttddvnecuhfhrohhmpeetlhihshhs rgcutfhoshhsuceohhhisegrlhihshhsrgdrihhsqeenucggtffrrghtthgvrhhnpeeuff egffdtvdffiedttefggfehtdfgudfhfffgteefgfdugeegveffieffudduvdenucfkphep jeelrddvfedurddvgeefrdekudenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmh epmhgrihhlfhhrohhmpehqhihlihhsshesvghvvgdrqhihlhhishhsrdhnvght X-ME-Proxy: Received: from eve.qyliss.net (p4fe7f351.dip0.t-ipconnect.de [79.231.243.81]) by mail.messagingengine.com (Postfix) with ESMTPA id 60D9E2400CC; Sun, 21 Mar 2021 10:38:51 -0400 (EDT) Received: by eve.qyliss.net (Postfix, from userid 1000) id 8C9C91204; Sun, 21 Mar 2021 14:38:50 +0000 (UTC) Date: Sun, 21 Mar 2021 14:38:50 +0000 From: Alyssa Ross To: Cole Helbling Subject: Re: [PATCH ucspi-vsock 7/7] Extract vsockserver-socketbinder and vsockserverd Message-ID: <20210321143850.3z55zbzi5ebetgcz@eve.qyliss.net> References: <20210320202441.m4leazkzrgduofwz@eve.qyliss.net> <20210321143314.xmnminxra7vn6bvj@eve.qyliss.net> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="d5k4fnzecus5jfpz" Content-Disposition: inline In-Reply-To: <20210321143314.xmnminxra7vn6bvj@eve.qyliss.net> Message-ID-Hash: VNTUPBLIDOK2S6TMPRXLNKXDEGMH2RGL X-Message-ID-Hash: VNTUPBLIDOK2S6TMPRXLNKXDEGMH2RGL X-MailFrom: qyliss@eve.qyliss.net X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-config-1; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; suspicious-header CC: devel@spectrum-os.org X-Mailman-Version: 3.3.1 Precedence: list List-Id: Patches and low-level development discussion Archived-At: List-Archive: List-Help: List-Post: List-Subscribe: List-Unsubscribe: --d5k4fnzecus5jfpz Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Sun, Mar 21, 2021 at 02:33:14PM +0000, Alyssa Ross wrote: > On Sat, Mar 20, 2021 at 07:52:00PM -0700, Cole Helbling wrote: > > On Sat Mar 20, 2021 at 1:24 PM PDT, Alyssa Ross wrote: > > > On Thu, Mar 18, 2021 at 08:39:31PM -0700, Cole Helbling wrote: > > > > > + if (listen(fd ,40) == -1) > > > > > > > > Minor formatting nit (comma, then space); but also, what is `40` > > > > representative of? Should this be `#define`d, or otherwise assigned to > > > > some descriptive name? > > > > > > Looks like the next thing I should do after this is set up clang-tidy or > > > something. ;) > > > > > > It's the backlog parameter, i.e. the minimum[1] number of connections > > > the kernel should allow to queue up before it starts rejecting them. > > > > > > Would the following additional diff make you happy? :) > > > (I won't bother resending the whole patch with it applied; for the > > > purposes of reviewing just pretend this is part of the patch I sent.) > > > > Yep, looks good to me! Though if I'm being greedy, maybe add the above > > explanation as a comment above the new variable? ("It's the backlog > > [...]") > > I think I don't want to get too much into explaining things listen(2) > will explain better than me (but you were right about giving this > number a name)! > > > Entire series looks good as well: > > > > Reviewed-by: Cole Helbling > > Thanks! > > To ssh://atuin/home/spectrum/git/ucspi-vsock.git > e718a97..a452f16 master -> master Actually it's e718a97..20a27f1. Realised I hadn't actually applied that diff, and decided to just force push before anybody noticed. ;) --d5k4fnzecus5jfpz Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCAAdFiEEH9wgcxqlHM/ARR3h+dvtSFmyccAFAmBXWnkACgkQ+dvtSFmy ccD3ag//bUkBm4qWj3rHSdofLd5dMHG7iZagOY0PYHWiQbnegANkvsPui6suBx0I ApWQsoLXFI0ThRkIg6b21V6AkdAAQ3IMXbAKUcXQ5Rmwlo4Xiwya6Kh7cwKNs2+I qNMbGtik2JTXjZb6p/cdWOi13ibaohDnSmzUMbhZpSr9Y84t/NnPGbvvw3TUcJ4O PDg68EHkTV/lZ6wfC77dPelx0/sNrXZGWGN4KHYukI5E1TexNBY/0kGoAuJAHHEB NmRtaaaiBoer7f/+2YYT46m1yn2uvKBQneCim4ZmHv13WLr1y7TJPH6gIxkPKFT8 SMjTPWVu3BeY3WL9rYDLYWlg7uuG2phhiEdZVm+bRm8WPEaGmI6PYcVNX8gpgYDV 1r6xVdiHFNAMclO8W+5y2dRbripzAxhs36TcCnxagGYnQ9kfuaM0oWX7Bw/bbFde UUpFXtYzglcjOXLnfellNSOV/hGgR2cXK5B1vL9eEXK18RwetmjzjGvJ0dTe2ctu WveXaOMo9P3/cllXFgBXBo2OMlZgnh/pEfS1RxP9ZjeMfVYr5ttnAyChH+UrIxW8 rUin3z/9pCG1PGRlFosYGtZrDXNHUQvB5aN+3CrC8oXXZpIDa6MXdydccBec4BVc yahdIxd/MWXxKDgnblwoNwnJ9NCgM+eNvoY1o2TmSjJmkSq6q+c= =zgOV -----END PGP SIGNATURE----- --d5k4fnzecus5jfpz--