From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on atuin.qyliss.net X-Spam-Level: X-Spam-Status: No, score=-4.5 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,RCVD_IN_DNSWL_LOW,RCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL,SPF_HELO_PASS autolearn=unavailable autolearn_force=no version=3.4.4 Received: by atuin.qyliss.net (Postfix, from userid 496) id E7864BFB0; Sun, 21 Mar 2021 19:38:13 +0000 (UTC) Received: from [127.0.0.1] (localhost [IPv6:::1]) by atuin.qyliss.net (Postfix) with ESMTP id 07790BEFF; Sun, 21 Mar 2021 19:38:03 +0000 (UTC) Received: by atuin.qyliss.net (Postfix, from userid 496) id EE9D1BF1F; Sun, 21 Mar 2021 19:38:00 +0000 (UTC) Received: from out4-smtp.messagingengine.com (out4-smtp.messagingengine.com [66.111.4.28]) by atuin.qyliss.net (Postfix) with ESMTPS id E427ABEF6 for ; Sun, 21 Mar 2021 19:37:56 +0000 (UTC) Received: from compute3.internal (compute3.nyi.internal [10.202.2.43]) by mailout.nyi.internal (Postfix) with ESMTP id E67255C00D5; Sun, 21 Mar 2021 15:37:54 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute3.internal (MEProxy); Sun, 21 Mar 2021 15:37:54 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=alyssa.is; h= date:from:to:cc:subject:message-id:references:mime-version :content-type:in-reply-to; s=fm2; bh=Z+QvMEf0I0enrqljyZrcOg32k6t 3W2D0lXDRTp2diF4=; b=srlF3OXxbzhGR8Uva/rXHz0AynP28jxZVDDg2NTfs/g YrVMi15AT6Su10QZFVZYENPaGSPT5POHP/U7NKMfkp1Wr902vqJOkGamX9t0pdiC U/HY1TOlZnaGhKi2KV0Qz76w3ACDfSp57KakHMmgayrdFjuPGMPUH26UKtRtpKV+ h5SIJnl/L1REFoBiUX2rK4CInXS2OugssBYgh8i/euf7sPZnw+LL2tZOoIrnTWAw KKvt0H+OqI/q94+p+AqE0S+c+Be0DnW3FknW1cX4Q0eHYYDUJhWeTrBvF7Dm1+iX j6uJi4W4CxCEZGRap1pbbbKG+3Frs6umrXKz4xBLWSw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm2; bh=Z+QvME f0I0enrqljyZrcOg32k6t3W2D0lXDRTp2diF4=; b=wH6rBtkpLEOWXbBtyYyDqA fpfsEgL7QaHcOz/518nReQhhJ4/oCnFPvlx9/7nBrIGMPzFHq13RFdo1IyuSE0N5 InAka//L3ue5RqRfH+8M7w4I7FWb480MzsaZLV5QyQrXMJ8/2uFxf81Ft6dhKUHC tbQoc4Z+jD+AxJ/uqCC+Jt6gSTXrRHHwIp0s8y6mz3R42PLz5E515ZwrvjZXZmPJ BSiw2th4S2ildLqxSdn4Huv4hz+mR0ey7DymqrCykbzKZQPX7Rrn0F78LUxEa7kG E4Br8quAe7Q1LAAFmv54V7AKhYxzcjbdMrWX/w0SO3pTstEa5tvSSOWZqkN3rEhg == X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduledrudegvddguddvjecutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfgh necuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmd enucfjughrpeffhffvuffkfhggtggujgesghdttdertddtvdenucfhrhhomheptehlhihs shgrucftohhsshcuoehhihesrghlhihsshgrrdhisheqnecuggftrfgrthhtvghrnhepgf ekhfevfefgveethfffleffteethedufedtgeekkeeuuedugeegveffudeuvddvnecuffho mhgrihhnpeifihhkihhpvgguihgrrdhorhhgnecukfhppeejledrvdefuddrvdegfedrke dunecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomhepqhih lhhishhssegvvhgvrdhqhihlihhsshdrnhgvth X-ME-Proxy: Received: from eve.qyliss.net (p4fe7f351.dip0.t-ipconnect.de [79.231.243.81]) by mail.messagingengine.com (Postfix) with ESMTPA id BA33A240299; Sun, 21 Mar 2021 15:37:53 -0400 (EDT) Received: by eve.qyliss.net (Postfix, from userid 1000) id DA60A1138; Sun, 21 Mar 2021 19:37:51 +0000 (UTC) Date: Sun, 21 Mar 2021 19:37:51 +0000 From: Alyssa Ross To: Cole Helbling Subject: Re: [PATCH ucspi-vsock 0/2] Fix clang-tidy warnings Message-ID: <20210321193751.pxoarzuk3d33ub3u@eve.qyliss.net> References: <20210321144700.24024-1-hi@alyssa.is> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="kvcfkygqmb4gymor" Content-Disposition: inline In-Reply-To: Message-ID-Hash: OYFE5AXOFFMIM3Q7WUTG24CKF5TOBWVS X-Message-ID-Hash: OYFE5AXOFFMIM3Q7WUTG24CKF5TOBWVS X-MailFrom: qyliss@eve.qyliss.net X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-config-1; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; suspicious-header CC: devel@spectrum-os.org X-Mailman-Version: 3.3.1 Precedence: list List-Id: Patches and low-level development discussion Archived-At: List-Archive: List-Help: List-Post: List-Subscribe: List-Unsubscribe: --kvcfkygqmb4gymor Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Sun, Mar 21, 2021 at 09:30:42AM -0700, Cole Helbling wrote: > On Sun Mar 21, 2021 at 7:46 AM PDT, Alyssa Ross wrote: > > clang-tidy also produced this warning: > > > > /home/src/ucspi-vsock/repro.c:43:19: warning: unused parameter 'sig' [clang-diagnostic-unused-parameter] > > void sig_exit(int sig) { exit(EX_UNAVAILABLE); } > > ^ > > vsock.c:27:23: warning: The left operand of '!=' is a garbage value [clang-analyzer-core.UndefinedBinaryOperatorResult] > > if (addr->svm_family != AF_VSOCK) { > > ^ > > vsock.c:90:6: note: Assuming the condition is false > > if (getsockname(fd, (struct sockaddr *)&addr, &addrlen) == -1) > > ^ > > vsock.c:90:2: note: Taking false branch > > if (getsockname(fd, (struct sockaddr *)&addr, &addrlen) == -1) > > ^ > > vsock.c:93:9: note: Calling 'fill_cid_and_port' > > return fill_cid_and_port(&addr, cid, port); > > ^ > > vsock.c:27:23: note: The left operand of '!=' is a garbage value > > if (addr->svm_family != AF_VSOCK) { > > > > But I think this is just warning me that the POSIX socket API violates > > the strict aliasing rule. (Which is true, but there's not a lot I can > > do about it...) > > > > It also tells me I should use memset_s instead of memset, but, well... > > https://en.wikipedia.org/wiki/C11_(C_standard_revision)#Criticism > > > > Alyssa Ross (2): > > exec: free argv if exec fails > > vsockserver: fix uninitialized variable > > > > exec.c | 5 ++++- > > vsockserver.c | 2 +- > > 2 files changed, 5 insertions(+), 2 deletions(-) > > > > -- > > 2.30.0 > > Patchset LGTM. > > Reviewed-by: Cole Helbling Thanks! To ssh://atuin/home/spectrum/git/ucspi-vsock.git 20a27f1..8b690b9 8b690b9 -> master > (I should really make a macro or something for that ^, so I don't have > to type it out every time and potentially make a mistake :D) --kvcfkygqmb4gymor Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCAAdFiEEH9wgcxqlHM/ARR3h+dvtSFmyccAFAmBXoI0ACgkQ+dvtSFmy ccCE0w//ZIftmzmQdFnMbvNSGqaqwT3AVAfEmgOprak5CIhWYdybQDkWHbIf5AwQ lP0Orr5hGBODmiWuLKw0YOuma6GZCBCi0xtsNWp0TE0bn125Cv/fSDTJfokShvfv XqOZkjXOCEhxGDVfvXrvlUrPETTipNOVnYr/EW4EvihF0gFHhr76v8j0DOaOCc1x zCYZHQKJN7ZWcQTVv/hglvSO2y3c5nw8qwtMJ0sePLxp3+I1FcN3A5XKqCKmCIRh efUvX/Rp3qkynqbO5jOLF0T1yxsgn2qhBwOJCwb2qsez7rYXQN1Kq3/uVQQGqRo4 Lu6/tfb4mE5ohaYcj8VyRRAv41EjoP+fO/wqfBVH5QZqOoQLbGeYUI2ELR43BauE a5jk+TGq3k9BBOIE6zo5SsObKnsjCmgsAiXMPbMX7h0cVn1dU24kYqzOQSZakEA0 XREWXd+FKoxjaJU6z+6FtZU6dtow4U+/eRv3nIxfB9U33K771qGvK+u7wGvXifjd 4jNeVDwSrCBvvp1qGNxPUkLmMUK6Wh4AJNW9jE2nIWfW6O9U4/lmk8Ep1x1Io5Ow oG1vTkUyEe2dCabzzXFLKc1aiMF2nMaom5Hrcr08A4njuubLf6zDUdKPblp12Hbx o+oSOa19J59KgkPyki3o2fMCRZIImMLp21Pdp7NsRf04K3kk5hM= =oukb -----END PGP SIGNATURE----- --kvcfkygqmb4gymor--