patches and low-level development discussion
 help / color / mirror / code / Atom feed
From: Alyssa Ross <hi@alyssa.is>
To: devel@spectrum-os.org
Subject: [PATCH nixpkgs] spectrumPackages.makeRootfs: fix messagebus group
Date: Thu, 22 Apr 2021 01:01:05 +0000	[thread overview]
Message-ID: <20210422010105.415233-1-hi@alyssa.is> (raw)

/etc/passwd set the messagebus user's primary group to 1, but there
was no group with that id in /etc/group.  The messagebus group had id 4.
The 4 comes from NixOS.  I think it's probably a good idea to use the
same user and group ids where possible -- there's no particular reason
to diverge -- so let's fix it in /etc/passwd instead of changing the
id in /etc/group to 1.

And while we're here, for consistency, let's change the user id of
messagebus to 4 as well, so that's consistent with NixOS as well.
I don't think the user ID is used anywhere else.

This fixes the DBus "Permission denied" errors that have been showing
up in vm-net since forever (but never seemed to cause any real harm...).
---
 pkgs/os-specific/linux/spectrum/rootfs/etc/passwd | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/pkgs/os-specific/linux/spectrum/rootfs/etc/passwd b/pkgs/os-specific/linux/spectrum/rootfs/etc/passwd
index c76fb8f2a99..ddb1f854a6e 100644
--- a/pkgs/os-specific/linux/spectrum/rootfs/etc/passwd
+++ b/pkgs/os-specific/linux/spectrum/rootfs/etc/passwd
@@ -1,3 +1,3 @@
 root:x:0:0:System administrator:/:/bin/sh
-messagebus:x:1:1:D-Bus system message bus daemon user:/run/dbus:/bin/sh
+messagebus:x:4:4:D-Bus system message bus daemon user:/run/dbus:/bin/sh
 user:x:1000:1000:User:/:/bin/sh
-- 
2.31.0


             reply	other threads:[~2021-04-22  1:01 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-04-22  1:01 Alyssa Ross [this message]
2021-04-22  1:35 ` [PATCH nixpkgs] spectrumPackages.makeRootfs: fix messagebus group Cole Helbling
2021-04-22  3:04   ` Josh DuBois
2021-04-22  8:03     ` Alyssa Ross
2021-04-22  8:03   ` Alyssa Ross

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210422010105.415233-1-hi@alyssa.is \
    --to=hi@alyssa.is \
    --cc=devel@spectrum-os.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://spectrum-os.org/git/crosvm
	https://spectrum-os.org/git/doc
	https://spectrum-os.org/git/mktuntap
	https://spectrum-os.org/git/nixpkgs
	https://spectrum-os.org/git/spectrum
	https://spectrum-os.org/git/ucspi-vsock
	https://spectrum-os.org/git/www

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).