From: Alyssa Ross <hi@alyssa.is>
To: devel@spectrum-os.org
Cc: Puck Meerburg <puck@puckipedia.com>
Subject: [PATCH platform2 0/2] Make vm_protos compatible with protoc-gen-go 1.5.x
Date: Mon, 28 Jun 2021 17:31:04 +0000 [thread overview]
Message-ID: <20210628173106.1128138-1-hi@alyssa.is> (raw)
My previous attempt[1] at this was totally wrong, because I didn't
understand what change needed to be made, and didn't have any way of
testing it.
To make sure this time that I got it right, I wrote a package for
tremplin[2], which was the only Chromium OS component I could find
that was written in Go and actually used vm_protos. With these
changes, I was able to add "${vm_protos}/lib/gopath" to tremplin's
extraSrcPaths, and get a successful build.
[1]: https://spectrum-os.org/lists/archives/spectrum-devel/20210627165035.899276-1-hi@alyssa.is/
[2]: https://chromium.googlesource.com/chromiumos/platform/tremplin
Alyssa Ross (2):
common-mk: add goproto_library source_relative opt
vm_tools: proto: set go_package correctly
common-mk/proto_library.gni | 7 +++++++
vm_tools/proto/BUILD.gn | 5 +++++
vm_tools/proto/tremplin.proto | 2 +-
vm_tools/proto/vm_crash.proto | 2 +-
vm_tools/proto/vm_guest.proto | 1 +
vm_tools/proto/vm_host.proto | 1 +
6 files changed, 16 insertions(+), 2 deletions(-)
--
2.31.1
next reply other threads:[~2021-06-28 17:31 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-28 17:31 Alyssa Ross [this message]
2021-06-28 17:31 ` [PATCH platform2 1/2] common-mk: add goproto_library source_relative opt Alyssa Ross
2021-06-28 17:31 ` [PATCH platform2 2/2] vm_tools: proto: set go_package correctly Alyssa Ross
2021-06-28 20:35 ` [PATCH platform2 0/2] Make vm_protos compatible with protoc-gen-go 1.5.x Cole Helbling
2021-06-30 9:12 ` Alyssa Ross
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210628173106.1128138-1-hi@alyssa.is \
--to=hi@alyssa.is \
--cc=devel@spectrum-os.org \
--cc=puck@puckipedia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://spectrum-os.org/git/crosvm
https://spectrum-os.org/git/doc
https://spectrum-os.org/git/mktuntap
https://spectrum-os.org/git/nixpkgs
https://spectrum-os.org/git/spectrum
https://spectrum-os.org/git/ucspi-vsock
https://spectrum-os.org/git/www
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).