From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.5 (2021-03-20) on atuin.qyliss.net X-Spam-Level: X-Spam-Status: No, score=-4.5 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, RCVD_IN_DNSWL_LOW,SPF_HELO_PASS autolearn=unavailable autolearn_force=no version=3.4.5 Received: by atuin.qyliss.net (Postfix, from userid 496) id BB481461F7; Mon, 28 Jun 2021 17:31:59 +0000 (UTC) Received: from atuin.qyliss.net (localhost [IPv6:::1]) by atuin.qyliss.net (Postfix) with ESMTP id 524AA46215; Mon, 28 Jun 2021 17:31:43 +0000 (UTC) Received: by atuin.qyliss.net (Postfix, from userid 496) id 6B4424617E; Mon, 28 Jun 2021 17:31:39 +0000 (UTC) Received: from forward3-smtp.messagingengine.com (forward3-smtp.messagingengine.com [66.111.4.237]) by atuin.qyliss.net (Postfix) with ESMTPS id C673B4617A for ; Mon, 28 Jun 2021 17:31:35 +0000 (UTC) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailforward.nyi.internal (Postfix) with ESMTP id 4FBFC1940429; Mon, 28 Jun 2021 13:31:34 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute1.internal (MEProxy); Mon, 28 Jun 2021 13:31:34 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:date:from :message-id:mime-version:subject:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm3; bh=kbM6N7tdyiNB0rLcB 4/kdhfRtMiTT9MiZ/y37JkhlT4=; b=XjgrdiuN6vGhwnq/LVs3r7aDEakVC0UKQ SBak4HDjgkr3L8Vc8mlmgbbXJo42U7o1V+8nG1gO1T9C5EFaRUIZMYfNgx24Kl3F 8NA6KrzV2GavkKnQDqqhY85nMp9kXvoPolfQwhG5x3JjLl97wKJiYIZBTsi8G2A0 g6lJcmlxbli40aQG5XeyJxVAQHH6431vDoXP0tULs16BaAa7Z2yEmVIZGSBkwm2i OWrJiw9kCgYbXAYIfkDA1P+CuTrrQMT9TeH25Z2aYXUPwv1PdO58B13dMSyVCjsY 4O+KVLNi0GtRnRtCptbgAvEHUHzx7AiVwrqsjxFmEIIVG8RyPmXyA== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduledrfeehgedguddufecutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfgh necuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmd enucfjughrpefhvffufffkofgggfestdekredtredttdenucfhrhhomheptehlhihsshgr ucftohhsshcuoehhihesrghlhihsshgrrdhisheqnecuggftrfgrthhtvghrnhepffehff evkeffheeiieduudduheeuvdffudejkeduvedtheduleffffeigfegvdeunecuffhomhgr ihhnpehsphgvtghtrhhumhdqohhsrdhorhhgpdhgohhoghhlvghsohhurhgtvgdrtghomh enucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpehqhihl ihhsshesvghvvgdrqhihlhhishhsrdhnvght X-ME-Proxy: Received: by mail.messagingengine.com (Postfix) with ESMTPA; Mon, 28 Jun 2021 13:31:33 -0400 (EDT) Received: by eve.qyliss.net (Postfix, from userid 1000) id 8670C12A3; Mon, 28 Jun 2021 17:31:31 +0000 (UTC) From: Alyssa Ross To: devel@spectrum-os.org Subject: [PATCH platform2 0/2] Make vm_protos compatible with protoc-gen-go 1.5.x Date: Mon, 28 Jun 2021 17:31:04 +0000 Message-Id: <20210628173106.1128138-1-hi@alyssa.is> X-Mailer: git-send-email 2.31.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Message-ID-Hash: CAMDJO5RH5XFTMOLKFLPV2WAPXUZM5T6 X-Message-ID-Hash: CAMDJO5RH5XFTMOLKFLPV2WAPXUZM5T6 X-MailFrom: qyliss@eve.qyliss.net X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-config-1; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: Puck Meerburg X-Mailman-Version: 3.3.4 Precedence: list List-Id: Patches and low-level development discussion Archived-At: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: My previous attempt[1] at this was totally wrong, because I didn't understand what change needed to be made, and didn't have any way of testing it. To make sure this time that I got it right, I wrote a package for tremplin[2], which was the only Chromium OS component I could find that was written in Go and actually used vm_protos. With these changes, I was able to add "${vm_protos}/lib/gopath" to tremplin's extraSrcPaths, and get a successful build. [1]: https://spectrum-os.org/lists/archives/spectrum-devel/20210627165035.899276-1-hi@alyssa.is/ [2]: https://chromium.googlesource.com/chromiumos/platform/tremplin Alyssa Ross (2): common-mk: add goproto_library source_relative opt vm_tools: proto: set go_package correctly common-mk/proto_library.gni | 7 +++++++ vm_tools/proto/BUILD.gn | 5 +++++ vm_tools/proto/tremplin.proto | 2 +- vm_tools/proto/vm_crash.proto | 2 +- vm_tools/proto/vm_guest.proto | 1 + vm_tools/proto/vm_host.proto | 1 + 6 files changed, 16 insertions(+), 2 deletions(-) -- 2.31.1