From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.5 (2021-03-20) on atuin.qyliss.net X-Spam-Level: X-Spam-Status: No, score=-4.5 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, RCVD_IN_DNSWL_LOW,SPF_HELO_PASS autolearn=unavailable autolearn_force=no version=3.4.5 Received: by atuin.qyliss.net (Postfix, from userid 496) id 5B5BE4EC58; Wed, 30 Jun 2021 09:12:41 +0000 (UTC) Received: from atuin.qyliss.net (localhost [IPv6:::1]) by atuin.qyliss.net (Postfix) with ESMTP id 338074EC37; Wed, 30 Jun 2021 09:12:33 +0000 (UTC) Received: by atuin.qyliss.net (Postfix, from userid 496) id CDBA64EC33; Wed, 30 Jun 2021 09:12:30 +0000 (UTC) Received: from forward4-smtp.messagingengine.com (forward4-smtp.messagingengine.com [66.111.4.238]) by atuin.qyliss.net (Postfix) with ESMTPS id 0B74E4EBFB for ; Wed, 30 Jun 2021 09:12:26 +0000 (UTC) Received: from compute4.internal (compute4.nyi.internal [10.202.2.44]) by mailforward.nyi.internal (Postfix) with ESMTP id 9BF1519404FF; Wed, 30 Jun 2021 05:12:25 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute4.internal (MEProxy); Wed, 30 Jun 2021 05:12:25 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm3; bh=SNWH0n gjVHlpz4jTxIRNprQBtYA/19k+y8ZEVX/5Dho=; b=OTSNu/3ruf8Ygk1F2LeiCV F4xjyi2jPh9MriNURIAsIVlirYoe9bJNK6wnDg2JJhCd16iPxGGXz2iV+o9f2Xtc ENqnuqYTM/ya/AXvKhrdltDjSrKFKGI/4kU4RRtL629JFJi1ZTuCzF4Rk2Ku37Vq f8JMcTmA4kjf9BAAfWUOpDcev4unPsZ4ZuLLL8Vt35nYchWVn29USwurkBRBB4qv OmmkppMtspNB76FVHCk70Yu33MEs8vuwIHDWRSo1L0l1j0sPQOWlmqSnT504pex+ AycDVonqCL9eRkm23axSYIt+4ekrKkIGITgZnjiD8x/LQ8K9C9RiKeynBQgavhrQ == X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduledrfeeivddguddvucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhepfffhvffukfhfgggtuggjsehgtddtredttddvnecuhfhrohhmpeetlhihshhs rgcutfhoshhsuceohhhisegrlhihshhsrgdrihhsqeenucggtffrrghtthgvrhhnpeektd ehuddtffekgfdtteejieefjeevheeghfffudekueffgfeitedtveffgfejgeenucffohhm rghinhepshhpvggtthhruhhmqdhoshdrohhrghdpghhoohhglhgvshhouhhrtggvrdgtoh hmnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomhepqhih lhhishhssegvvhgvrdhqhihlihhsshdrnhgvth X-ME-Proxy: Received: by mail.messagingengine.com (Postfix) with ESMTPA; Wed, 30 Jun 2021 05:12:25 -0400 (EDT) Received: by eve.qyliss.net (Postfix, from userid 1000) id 519F4FB2; Wed, 30 Jun 2021 09:12:23 +0000 (UTC) Date: Wed, 30 Jun 2021 09:12:23 +0000 From: Alyssa Ross To: Cole Helbling Subject: Re: [PATCH platform2 0/2] Make vm_protos compatible with protoc-gen-go 1.5.x Message-ID: <20210630091223.p6tnych3z27utcpi@eve.qyliss.net> References: <20210628173106.1128138-1-hi@alyssa.is> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="tk75drzn27cxjf6f" Content-Disposition: inline In-Reply-To: Message-ID-Hash: 2UG3WIXEXNBSKLSME277RJ3HFWXRL5A2 X-Message-ID-Hash: 2UG3WIXEXNBSKLSME277RJ3HFWXRL5A2 X-MailFrom: qyliss@eve.qyliss.net X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-config-1; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: devel@spectrum-os.org, Puck Meerburg X-Mailman-Version: 3.3.4 Precedence: list List-Id: Patches and low-level development discussion Archived-At: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: --tk75drzn27cxjf6f Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Mon, Jun 28, 2021 at 01:35:51PM -0700, Cole Helbling wrote: > On Mon Jun 28, 2021 at 10:31 AM PDT, Alyssa Ross wrote: > > My previous attempt[1] at this was totally wrong, because I didn't > > understand what change needed to be made, and didn't have any way of > > testing it. > > > > To make sure this time that I got it right, I wrote a package for > > tremplin[2], which was the only Chromium OS component I could find > > that was written in Go and actually used vm_protos. With these > > changes, I was able to add "${vm_protos}/lib/gopath" to tremplin's > > extraSrcPaths, and get a successful build. > > > > [1]: https://spectrum-os.org/lists/archives/spectrum-devel/20210627165035.899276-1-hi@alyssa.is/ > > [2]: https://chromium.googlesource.com/chromiumos/platform/tremplin > > > > Alyssa Ross (2): > > common-mk: add goproto_library source_relative opt > > vm_tools: proto: set go_package correctly > > > > common-mk/proto_library.gni | 7 +++++++ > > vm_tools/proto/BUILD.gn | 5 +++++ > > vm_tools/proto/tremplin.proto | 2 +- > > vm_tools/proto/vm_crash.proto | 2 +- > > vm_tools/proto/vm_guest.proto | 1 + > > vm_tools/proto/vm_host.proto | 1 + > > 6 files changed, 16 insertions(+), 2 deletions(-) > > > > -- > > 2.31.1 Hey Cole, glad you're still around. :) > Good thing I didn't (have enough time to) review that previous patch :P > > Is this something unique to this project, or should / will this be upstreamed > (if it isn't already)? It's probably not that useful to upstream, because they're still using the old version of protoc-gen-go, and when they do get around to upgrading, I imagine they'll want to do it across the board, so it'll end up being different to the fix I've made here that only affects one component. I expect they'd want to just set source_relative unconditionally, for example, whereas I've made it an option that defaults to off. I did it that way because I don't have the resources to check all of Chromium OS, when the only bits of it I know how to build are the bits I've packaged for Spectrum. Additionally, I'm a bit wary about upstreaming things to Google, because they have a mandatory CLA. If we had some big change where we'd really benefit from them maintaining it upstream, I might be able to overcome my reservations, but this isn't it. > That aside, diff LGTM. > > Reviewed-by: Cole Helbling Thanks! I'll be sending some patches shortly that add these patches to chromiumOSPackages.vm_protos in Spectrum's Nixpkgs. --tk75drzn27cxjf6f Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCAAdFiEEH9wgcxqlHM/ARR3h+dvtSFmyccAFAmDcNXAACgkQ+dvtSFmy ccANEBAAmIb0wXgJNgQFfOEAWJJ9XZGjff3NrzC2OAN+58zYqd27gWo17+g2YORf WVtHglBSDDwwDLFuj7KwFQH7DthExirbv4C0+XSV0T6nDo15v2T25PWR19YuCaQR vh1LacgaNojL+Fj3M2eGOiNpbbKohkMQXaPXzW7KGKKwgViAVkQq08LcqRX3lR3r UYzV29be4ZOwE7DWTdIGM3JudgiX40XcD2wlwhi6OpVc2/2gh6ZVTzO57OwyB6IN 8HplrWdXeXFwohpIzEHVsiOIeYYVWeUQ6ln50P3Zjtt7B74qqeNC9UOmJSgJkpeI urdexj0+6Pa2WFRPJCGvCLkG1xQUmN4xdlZvabwmE5kvC7qGzjn9Mhmi/i7+3Rqb qXiHsoIwuOYLHfEgJVPhALHkw199DpYMTUwx4vv8tnRhuZxLdP3WCYvaUvOZh0Hm mcnaXwPsxxlNobXeenHczzEYc0boFzRKHT5RbiHR8HLkqYiLWaOAj1XFM4MJ9ZqL rCiCjs5FSXW0sgcWsIcegv0F6qTop1TP6ynQlF/N13f3dClB9JHzvBPs8WMwDFyB v0XyPN6KfWeVIvmNskZ5jXsv8qDR/x3MaCDM1brLZ5vMkk94rY53AXZTVjJGNgnu 78FTDupE1Ik0DykRQgVVmn8C2P2PG+BDHI4a98kgVfQ/Mmg+2Nw= =ZfFW -----END PGP SIGNATURE----- --tk75drzn27cxjf6f--