Re: [PATCH nixpkgs] spectrumPackages: update execline backtick uses

Alyssa Ross
2021-08-12T09:24:28Z

[-- Attachment #1: Type: text/plain, Size: 1229 bytes --]

sternenseemann <sternenseemann@systemli.org> writes:

> On 8/8/21 7:04 PM, Alyssa Ross wrote:
>> execline 2.8.0.0 changed how backtick's options work:
>>
>> * -i (exit with the program's error code on failure) and -n (chomp off
>> a trailing newline from the captured output) are now the defaults.
>> * -E has been introduced, which does importas automatically.
>>
>> -E is fantastic, because we followed every single use of backtick with
>> importas.
>>
>> Even we didn't have -n before, it's okay that chomping will now be
>> enabled from the default, because in all those cases, there won't be a
>> trailing newline anyway.
>> ---
>> .../linux/spectrum/testhost/default.nix | 14 ++++----------
>> pkgs/os-specific/linux/spectrum/vm/app/default.nix | 3 +--
>> pkgs/os-specific/linux/spectrum/vm/net/default.nix | 6 ++----
>> 3 files changed, 7 insertions(+), 16 deletions(-)
>>
>> base-commit: d2e147bedf251976ed99b94b6c905d6761f7a892
>> --
>> 2.32.0
>
> Looks good and quite straightforward. All substitutions seem correct.
>
> Reviewed-by: sterni <sternenseemann@systemli.org>

Thanks so much for the review! Committed as
769e648d243223613d008276bcac18a164302ba8. :)

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 832 bytes --]