From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on atuin.qyliss.net X-Spam-Level: X-Spam-Status: No, score=-4.6 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,RCVD_IN_DNSWL_LOW,SPF_HELO_PASS autolearn=unavailable autolearn_force=no version=3.4.6 Received: from atuin.qyliss.net (localhost [IPv6:::1]) by atuin.qyliss.net (Postfix) with ESMTP id 5ADAE32CCB; Sun, 24 Apr 2022 08:02:27 +0000 (UTC) Received: by atuin.qyliss.net (Postfix, from userid 496) id 9339532CC3; Sun, 24 Apr 2022 08:02:24 +0000 (UTC) Received: from wout3-smtp.messagingengine.com (wout3-smtp.messagingengine.com [64.147.123.19]) by atuin.qyliss.net (Postfix) with ESMTPS id 6428A32CC2 for ; Sun, 24 Apr 2022 08:02:20 +0000 (UTC) Received: from compute2.internal (compute2.nyi.internal [10.202.2.46]) by mailout.west.internal (Postfix) with ESMTP id A4C913200A3E; Sun, 24 Apr 2022 04:02:16 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute2.internal (MEProxy); Sun, 24 Apr 2022 04:02:16 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=alyssa.is; h=cc :cc:content-transfer-encoding:date:date:from:from:in-reply-to :message-id:mime-version:reply-to:sender:subject:subject:to:to; s=fm3; t=1650787336; x=1650873736; bh=WiOd5d+nI7POs9WDoyJlBsACv 9Cj5ddCpWvGVky5oXk=; b=Xkb7+0YWG1v0jQyd1n/hS5hr43y3X7xEHm71qXhA+ YJraB1pScjMfIh0v8SGqV6L7Xblsuoulz67TZeM4rhoDZy1TLhksm8hhQcbaSTNQ UnP6lxrmxlA6y//PAH+hPq2zz3/G6eI9ha4xFJXe1v+JtERf4jz6/b1uLso4sk3R l2LV1133C7axnx3Vf6RWdyb/tEYy9mL/HW6MEppnEFyFt4ZTBXeAjOke1KP9HOO6 1OE9gdCY4k7xDMD0fgZIVkv7Had8NwKkFeJzOGxW50EcDio3BMcoT6RHKK1+Asmu Jr8qMpZDUGdb72sfFA6yDvDGLVfCpXDD9QuFIxBRiejZA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding:date:date :from:from:in-reply-to:message-id:mime-version:reply-to:sender :subject:subject:to:to:x-me-proxy:x-me-proxy:x-me-sender :x-me-sender:x-sasl-enc; s=fm1; t=1650787336; x=1650873736; bh=W iOd5d+nI7POs9WDoyJlBsACv9Cj5ddCpWvGVky5oXk=; b=S/vhs0Oc14RKIESye 17BALS0iqCotQC0Ri2Q0CKImeoEKdPGCGhRdWsKvRDehQDCgNX7yuagbgowwbIr9 KCHRjY5gdIQcmdioLAw2EKJgBoUbe9AD5jgHJcVLaSByRQ8l1gUpbVOQFF/UkA1x QvVJaMOTotYVGo3YyyyGssQqz86Q/8D+A2zER3dTRq0DHkl7PASkp9p5XTHzkjHr v4Uc7/SwjwhQgW4bCPdw0m2kIXBJvgAmfpzd7jiCnMze6b1uorowUAiv715Ob/Zt qgdGnNHwaEdRBlNlDONdfJCZmpDK6KAid90PHkLho9Ocktl8nAQUfH+3PThNtl6A qr2Zw== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvfedrtdekgddvfecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpefhvfevufffkffoggfgsedtkeertdertddtnecuhfhrohhmpeetlhihshhsrgcu tfhoshhsuceohhhisegrlhihshhsrgdrihhsqeenucggtffrrghtthgvrhhnpeehkefgtd evtedtkeduudeguefgudejheeugfelgeettdfhffduhfehudfhudeuhfenucevlhhushht vghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpehqhihlihhsshesvghvvg drqhihlhhishhsrdhnvght X-ME-Proxy: Received: by mail.messagingengine.com (Postfix) with ESMTPA; Sun, 24 Apr 2022 04:02:15 -0400 (EDT) Received: by eve.qyliss.net (Postfix, from userid 1000) id AE6F22F7; Sun, 24 Apr 2022 08:02:14 +0000 (UTC) From: Alyssa Ross To: devel@spectrum-os.org Subject: [PATCH] host/rootfs: fix Weston hotplugging Date: Sun, 24 Apr 2022 08:00:21 +0000 Message-Id: <20220424080020.32216-1-hi@alyssa.is> X-Mailer: git-send-email 2.35.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Message-ID-Hash: C3BDXEDDK2ZTQD36SWHBPJQUQDFTB5HU X-Message-ID-Hash: C3BDXEDDK2ZTQD36SWHBPJQUQDFTB5HU X-MailFrom: qyliss@eve.qyliss.net X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-config-1; header-match-devel.spectrum-os.org-0; header-match-devel.spectrum-os.org-1; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: Ville Ilvonen X-Mailman-Version: 3.3.5 Precedence: list List-Id: Patches and low-level development discussion Archived-At: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On the Spectrum host, the kernel delivers uevents to mdevd. By default, if mdevd doesn't have a handler for an event, it won't do anything, and other processes that might be interested in the uevent hear about it. This means that Weston isn't notified about input device hotplugs. (And USB devices can appear after init has started, so any USB device counts as hotplugging even if it's attached before boot or even built in to the computer.) To fix this, we configure mdevd to rebroadcast events it doesn't handle on Netlink group 4. These events will then be picked up by Weston via libudev-zero, which listens on group 4 for hotplug events. Reported-by: Ville Ilvonen Fixes: 372bacd ("etc/s6-rc: add weston service") --- Ville, does this fix the internal keyboard and mouse on your ThinkPad T560? host/rootfs/etc/s6-rc/mdevd/run | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/host/rootfs/etc/s6-rc/mdevd/run b/host/rootfs/etc/s6-rc/mdevd/run index f838d2d..c4615c8 100644 --- a/host/rootfs/etc/s6-rc/mdevd/run +++ b/host/rootfs/etc/s6-rc/mdevd/run @@ -2,4 +2,4 @@ # SPDX-License-Identifier: EUPL-1.2 # SPDX-FileCopyrightText: 2020-2022 Alyssa Ross -mdevd -D3 -b134217728 +mdevd -D3 -O4 -b134217728 base-commit: 402c7fd0637e834f97b0ea1a2abb89c417e7469d -- 2.35.1