Re: [PATCH] Fix valgrind build with Musl

Alyssa Ross
2022-05-18T13:43:20Z

[-- Attachment #1: Type: text/plain, Size: 1040 bytes --]

On Wed, May 18, 2022 at 03:19:24PM +0300, Ivan Nikolaenko wrote:
> Musl does not support __THROW macro, so need to define
> this empty.
>
> Signed-off-by: Ivan Nikolaenko <ivan.nikolaenko@unikie.com>

Thanks for the patch!

Would you mind submitting it to upstream Nixpkgs? [1] It's a small
change, so shouldn't be difficult to get upstream. (I can probably just
merge it myself.) Once it's accepted upstream, we can cherry-pick it
into Spectrum's nixpkgs, or update Spectrum's nixpkgs to a version that
includes the fix. This way, we minimize how much Spectrum's nixpkgs is
diverged from upstream. If it ends up being more difficult to upstream
than I expect (e.g. if somebody objects for some reason), then I'll
happily just commit it to Spectrum nixpkgs.

When you open the Nixpkgs PR, please CC me. My GitHub username is
@alyssais. Nixpkgs is quite picky about commit message format, so make
sure to look at the examples in the documentation linked below.

[1]: https://nixos.org/manual/nixpkgs/unstable/#chap-submitting-changes

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]