Re: [PATCH] Allow static building of dtc

[Alyssa Ross <hi@alyssa.is>]

[-- Attachment #1: Type: text/plain, Size: 1314 bytes --]

On Fri, May 20, 2022 at 12:52:57PM +0300, Tero Tervala wrote:
> Signed-off-by: Tero Tervala <tero.tervala@unikie.com>
> ---
>  ...01-Use-libfdt.a-if-building-staticly.patch | 54 +++++++++++++++++++
>  pkgs/development/compilers/dtc/default.nix    |  4 ++
>  2 files changed, 58 insertions(+)
>  create mode 100644 pkgs/development/compilers/dtc/0001-Use-libfdt.a-if-building-staticly.patch

Thanks for the patch!  Since pkgsStatic.dtc is broken in upstream
Nixpkgs, would you mind submitting it there? [1]  It will get us wider
review than on the Spectrum list, and if it's accepted upstream (I
imagine this or a similar fix will be) it'll minimize how much Spectrum
Nixpkgs diverges, which is important for maintainability.  Once it's
accepted upstream (or if it ends up being difficult to upstream), we can
cherry-pick it into Spectrum's nixpkgs, or update Spectrum's nixpkgs to
a version that includes the fix.

When you open the Nixpkgs PR, please CC me.  My GitHub username is
@alyssais.  Nixpkgs is quite picky about commit message format, so make
sure to look at the examples in the documentation linked below.

When I get a chance, I'll update the documentation to recommend
submitting fixes to upstream Nixpkgs first if applicable.

[1]: https://nixos.org/manual/nixpkgs/unstable/#chap-submitting-changes

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]