From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on atuin.qyliss.net X-Spam-Level: X-Spam-Status: No, score=-4.6 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,RCVD_IN_DNSWL_LOW,SPF_HELO_PASS, T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.6 Received: from atuin.qyliss.net (localhost [IPv6:::1]) by atuin.qyliss.net (Postfix) with ESMTP id 6BCDD54BA7; Sun, 12 Jun 2022 22:11:58 +0000 (UTC) Received: by atuin.qyliss.net (Postfix, from userid 496) id E0B2054B2E; Sun, 12 Jun 2022 22:11:55 +0000 (UTC) Received: from wout1-smtp.messagingengine.com (wout1-smtp.messagingengine.com [64.147.123.24]) by atuin.qyliss.net (Postfix) with ESMTPS id A2B4554B9B for ; Sun, 12 Jun 2022 22:11:51 +0000 (UTC) Received: from compute5.internal (compute5.nyi.internal [10.202.2.45]) by mailout.west.internal (Postfix) with ESMTP id 703843200912; Sun, 12 Jun 2022 18:11:48 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute5.internal (MEProxy); Sun, 12 Jun 2022 18:11:48 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=alyssa.is; h=cc :cc:content-type:date:date:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:sender:subject :subject:to:to; s=fm1; t=1655071907; x=1655158307; bh=5ZANvJYIsS PIEn9cM2+DCdX6pD8RczOymA8UKvZaBvM=; b=5ywtIVQ3oDxNC0vPa4PK2bEyID NPe/ypFFMtT6+tHmFKIPKX20ZakWhfQJ4VerZSmjj56v7D+Ttk6omj6B82z0EOri mr6Ekdc7UVwu67vO9xdEmQaNNSwmDjYZpn1J8H+hAwVJa3d3gAPAoth4hhxK58UU NRnsEflxQ/ZbmnZpmK5/JLXkc9Fs0igz+XQgVBt0rYPo+O+N+pdDE73s9/0kWz5c cN17SoCq01Pqd7ZA0QkXCKbsC/Xe1dLHXh61joNMikTkZ/E5jrbSQITzLePs++Sg 1f3bo6x3/HeI4y342CMEbSfQqkwNLcqxkrBqLmdbW5gBzSjF19be+1OtdkhA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:date:date:feedback-id :feedback-id:from:from:in-reply-to:in-reply-to:message-id :mime-version:references:reply-to:sender:subject:subject:to:to :x-me-proxy:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s= fm2; t=1655071907; x=1655158307; bh=5ZANvJYIsSPIEn9cM2+DCdX6pD8R czOymA8UKvZaBvM=; b=SNnPctRWUiUxNv077sGHHjWlObKUDboq5Zb1dGl3hCHm azbt6M32+FR6rVsGLe6VvJiggVZ66+3pR3SZFce2h9MIIDrG3W6w5+F/j28CmGCN K1NI/57nMHvUr5V3k8V6+HP96EheWwdUpVrk0Z/UUwRLWTOhILW4RMEXWyRqGlcQ GdJjQwrr9S1XqdlvC8tpRBxb9hitK62N217LJs6rD+3IKMD4N+w/ASKRIFClfiI6 USBsTvf/T+L1zGsHuIAjTPnkqQkmaoqF2IrypWuIN2hcyBRPrkerbsGeJ//QnT8f i7j13+5hlmBmfbNi0c5M9n/SC6Aw+rWC+lbTFxw4lQ== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvfedrudduiedgtdefucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhepfffhvfevuffkfhggtggujgesghdtreertddtjeenucfhrhhomheptehlhihs shgrucftohhsshcuoehhihesrghlhihsshgrrdhisheqnecuggftrfgrthhtvghrnhepge ejieegjefhgfffheeuleduvefhiefffedugedvgeduhfdujeehfefhuefggefhnecuvehl uhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomhepqhihlhhishhsse gvvhgvrdhqhihlihhsshdrnhgvth X-ME-Proxy: Feedback-ID: i12284293:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Sun, 12 Jun 2022 18:11:47 -0400 (EDT) Received: by eve.qyliss.net (Postfix, from userid 1000) id 17A9247D; Sun, 12 Jun 2022 22:11:44 +0000 (UTC) Date: Sun, 12 Jun 2022 22:11:44 +0000 From: Alyssa Ross To: Ville Ilvonen Subject: Re: [PATCH] doc: addressing architecture.adoc review changes Message-ID: <20220612221144.ap7ri3376gemqczb@eve> References: <20220607064259.588734-1-ville.ilvonen@unikie.com> <165458472089.1819.1950838469655114894@atuin.qyliss.net> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="ekqwnhvhxvswf2lm" Content-Disposition: inline In-Reply-To: <165458472089.1819.1950838469655114894@atuin.qyliss.net> Message-ID-Hash: 5OKTAL772P3P5ZD2SX3V7YBDK2WQX6XU X-Message-ID-Hash: 5OKTAL772P3P5ZD2SX3V7YBDK2WQX6XU X-MailFrom: qyliss@eve.qyliss.net X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-config-1; header-match-devel.spectrum-os.org-0; header-match-devel.spectrum-os.org-1; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: devel@spectrum-os.org X-Mailman-Version: 3.3.5 Precedence: list List-Id: Patches and low-level development discussion Archived-At: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: --ekqwnhvhxvswf2lm Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Tue, Jun 07, 2022 at 06:52:00AM -0000, Ville Ilvonen wrote: > Hi, > > Thanks for the review comments and no worries with delay. People have the= ir schedules. I was just following up on this contrib :-) Thanks! I'm ready to apply this patch. One small thing that needs to be addressed first: the diagram file is missing a license notice, so my `reuse lint` check fails. Is the same license as used for the documentation file itself (GFDL-1.3-no-invariants-or-later OR CC-BY-SA-4.0) okay? No need to send a new patch just to add the license notice =E2=80=94 I can = add it when I apply the patch. > I was quite not sure how you would have preferred the changes implemented= - amended to the original patch or additional patch. I used additional pat= ch. As hard line wrap destroys the diff in respect to the earlier patch I a= ddressed your review comments in the patch comments and used git-send to ad= d the patch. I don't mind amending the changes to the original patch either= , just let me know. > > If there's different preferences, we could complement the contribution gu= idelines and include style guide. Good idea. I'll write it up when I get the chance, but in short, the preferred way to do this is to send a new version of the whole patch, with "[PATCH v2]" at the start of the subject line (the -v2 argument to git format-patch or git send-email will do this), and to explain the changes from the previous version after the "---" line, just before the diffstat. (This is called the "timely commentary" section because it's stripped when the final version of the patch is applied by git.) --ekqwnhvhxvswf2lm Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCAAdFiEEH9wgcxqlHM/ARR3h+dvtSFmyccAFAmKmZJkACgkQ+dvtSFmy ccDamw//U0KSiFxIEU4oPZ3Ji8mMAsBfOAPxtOLKk8szxy77NZiIimwvl0qQD4A0 LfFKNV1z8e2RN2O9CweCmTzPF2iExxoZ0wU38W2q6D+DVlcq/5NMa5G97CjttLSI eaMoLJIsgLm1P7ylkInkoozhw61hTgesC3YnIoAtlpvMmjVvKCypRVLXRBVWWP5A 5zNPJpNdESSsKv/BnccSE4j3j9S+6cGNp6SwJUv5+q8hrX6n5wspaSC1YoihIdSm W0HbxShdKOV0TW9k2XtHk/V72p69T1l9BVdM9opBx8QtYZGalkFDRWV81rKcxRaj v8f2DIsJFkMJMRyOiCyZHmYZjcQtHp1vaDnXRqMp1f+E5r/VraLqfOzGz64EBsI1 9SvgtiOA619bBOe0A6U0yJ6hI+TaCrtMygUmfMRLu0nAHYYSoytX+gYzN5/o/Ro2 /pZIJxwfqP4jSdcMhaDNBFBATbJXvUn7IBUjRcFYI96umStJmimF1ghx+fpEFaLw rwzIEGwTCBe8jCI1yPmX9NjftdhhniiraVvfKMMoLI5NJvfQaAaZRsEhkf8M8keT sxt8EqKwWL4GunPqzL7o3Y68iXn2gqM7jv3foK1aesG5X6BcWHptPEb53jYHNtu0 qlVyaU+UQ8IAfmbg/4dg0VYJWrHevaFr4VZ1PlbJMn4tVpmCZP8= =EXCI -----END PGP SIGNATURE----- --ekqwnhvhxvswf2lm--