patches and low-level development discussion
 help / color / mirror / code / Atom feed
From: Alyssa Ross <hi@alyssa.is>
To: Ville Ilvonen <ville.ilvonen@unikie.com>
Cc: devel@spectrum-os.org
Subject: Re: [PATCH] Documentation: Architecture Decision Record
Date: Fri, 22 Jul 2022 11:37:12 +0000	[thread overview]
Message-ID: <20220722113712.vmeoe4rvcdrmc4e3@eve> (raw)
In-Reply-To: <CAP-nJwHX11dzQ+aoWsbOx4DzVRYE3LOp7eKV1cU9_ykpFssA3g@mail.gmail.com>

[-- Attachment #1: Type: text/plain, Size: 887 bytes --]

On Wed, Jul 13, 2022 at 02:04:31PM +0300, Ville Ilvonen wrote:
> On Wed, Jul 13, 2022 at 12:53 PM Alyssa Ross <hi@alyssa.is> wrote:
> >
> > I've thought about this a bit more, and decided that it's fine to have
> > proposed ADRs in the repo.  I was concerned about the in-between state
> > an ADR could find itself in when it's been submitted but I haven't
> > applied the patch yet, but having thought about it more, I don't think
> > having a stage of "being accepted for discussion" is a bad thing.
>
> Ok. This patch addresses all your review comments.

Thanks.  I've applied the patch.

I still have some reservations about the ADRs — I'm still a bit worried
about the proposed ADRs being in the repo making people hesitant to
suggest changes to them, and I'm not sure yet how they fit into the rest
of the documentation — but let's give them a go, as a trial.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

  parent reply	other threads:[~2022-07-22 11:37 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-07-08 11:02 [PATCH] Documentation: Architecture Decision Record Ville Ilvonen
2022-07-12 18:11 ` Alyssa Ross
2022-07-13  9:35   ` Ville Ilvonen
2022-07-13  9:53     ` Alyssa Ross
2022-07-13 11:04       ` Ville Ilvonen
2022-07-22 11:32         ` Alyssa Ross
2022-07-22 11:37         ` Alyssa Ross [this message]
2022-07-13 10:04 ` Alyssa Ross
2023-01-03  7:03 ` Adam Joseph
2023-01-06 13:27   ` Alyssa Ross

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220722113712.vmeoe4rvcdrmc4e3@eve \
    --to=hi@alyssa.is \
    --cc=devel@spectrum-os.org \
    --cc=ville.ilvonen@unikie.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://spectrum-os.org/git/crosvm
	https://spectrum-os.org/git/doc
	https://spectrum-os.org/git/mktuntap
	https://spectrum-os.org/git/nixpkgs
	https://spectrum-os.org/git/spectrum
	https://spectrum-os.org/git/ucspi-vsock
	https://spectrum-os.org/git/www

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).