patches and low-level development discussion
 help / color / mirror / code / Atom feed
From: "José Pekkarinen" <jose.pekkarinen@unikie.com>
To: devel@spectrum-os.org
Cc: "Alyssa Ross" <hi@alyssa.is>,
	"José Pekkarinen" <jose.pekkarinen@unikie.com>
Subject: [PATCH v2] host/rootfs: remove kernel override
Date: Thu,  8 Sep 2022 13:04:01 +0300	[thread overview]
Message-ID: <20220908100401.14420-1-jose.pekkarinen@unikie.com> (raw)

From: Alyssa Ross <hi@alyssa.is>

These drivers should be loaded by the initramfs if required — most
Spectrum installs won't need the virtio drivers on the host, and
overriding the kernel means more stuff we can't reuse from
cache.nixos.org.

We'll probably want to build in the driver for whatever filesystem we
end up using for the root file system eventually, since it will always
be required, but that should be done as part of a more systematic
effort to optimise our kernel configuration.

Signed-off-by: Alyssa Ross <hi@alyssa.is>
Signed-off-by: José Pekkarinen <jose.pekkarinen@unikie.com>
---
[ v1 -> v2 ] Request mdev to load modules on boot

 host/rootfs/default.nix                         | 9 +--------
 host/rootfs/etc/modules-autoload.d/modules.conf | 4 ++++
 2 files changed, 5 insertions(+), 8 deletions(-)
 create mode 100644 host/rootfs/etc/modules-autoload.d/modules.conf

diff --git a/host/rootfs/default.nix b/host/rootfs/default.nix
index e5f316f..a651a20 100644
--- a/host/rootfs/default.nix
+++ b/host/rootfs/default.nix
@@ -65,14 +65,7 @@ let
     imports = [ (modulesPath + "/profiles/all-hardware.nix") ];
   });
 
-  kernel = pkgs.linux_latest.override {
-    structuredExtraConfig = with lib.kernel; {
-      VIRTIO = yes;
-      VIRTIO_PCI = yes;
-      VIRTIO_BLK = yes;
-      EXT4_FS = yes;
-    };
-  };
+  kernel = pkgs.linux_latest;
 
   packagesSysroot = runCommand "packages-sysroot" {
     nativeBuildInputs = [ xorg.lndir ];
diff --git a/host/rootfs/etc/modules-autoload.d/modules.conf b/host/rootfs/etc/modules-autoload.d/modules.conf
new file mode 100644
index 0000000..dd9529a
--- /dev/null
+++ b/host/rootfs/etc/modules-autoload.d/modules.conf
@@ -0,0 +1,4 @@
+virtio
+virtio_pci
+virtio_blk
+ext4
-- 
2.25.1



                 reply	other threads:[~2022-09-08 10:04 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220908100401.14420-1-jose.pekkarinen@unikie.com \
    --to=jose.pekkarinen@unikie.com \
    --cc=devel@spectrum-os.org \
    --cc=hi@alyssa.is \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://spectrum-os.org/git/crosvm
	https://spectrum-os.org/git/doc
	https://spectrum-os.org/git/mktuntap
	https://spectrum-os.org/git/nixpkgs
	https://spectrum-os.org/git/spectrum
	https://spectrum-os.org/git/ucspi-vsock
	https://spectrum-os.org/git/www

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).