From mboxrd@z Thu Jan 1 00:00:00 1970 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on atuin.qyliss.net X-Spam-Level: X-Spam-Status: No, score=-1.8 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,MAILING_LIST_MULTI,RCVD_IN_DNSWL_LOW,RCVD_IN_MSPIKE_H2, SPF_HELO_PASS autolearn=unavailable autolearn_force=no version=3.4.6 Received: from atuin.qyliss.net (localhost [IPv6:::1]) by atuin.qyliss.net (Postfix) with ESMTP id EDEAE6D2CE; Thu, 22 Sep 2022 07:57:12 +0000 (UTC) Received: by atuin.qyliss.net (Postfix, from userid 496) id D0F5B6D2A9; Thu, 22 Sep 2022 07:57:09 +0000 (UTC) Received: from wout1-smtp.messagingengine.com (wout1-smtp.messagingengine.com [64.147.123.24]) by atuin.qyliss.net (Postfix) with ESMTPS id 6F34A6D330 for ; Thu, 22 Sep 2022 07:57:07 +0000 (UTC) Received: from compute2.internal (compute2.nyi.internal [10.202.2.46]) by mailout.west.internal (Postfix) with ESMTP id 0A4ED32004F8; Thu, 22 Sep 2022 03:57:05 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute2.internal (MEProxy); Thu, 22 Sep 2022 03:57:06 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=alyssa.is; h=cc :cc:content-transfer-encoding:date:date:from:from:in-reply-to :in-reply-to:message-id:mime-version:references:reply-to:sender :subject:subject:to:to; s=fm1; t=1663833425; x=1663919825; bh=th 2sup/cn4qdMLKWwS3nkwNaPb4V/XpWQof01u4I4tY=; b=ChhvPcIq9ghxtWQf4A eBbIL6p9OSc3/WlLN0rgoPdNPgfnvX2H0YqbMABLT0jmghqix5qj4svFWentCtQn BYpdojxnIWhI9Pe6mJsZ+iuht1cJ5kqtVXy43t7xfkQfCVirxDm4I/ScfyyXn8Zm qiq9OiMC7RGN0/ZR23q8SDbtJcSwxhqt3P9h4YWc0qkLr9beYWqiyZ9biaJAkVTT Dtq9G8FABKX0yFh6BnTYi9Y3a27hXFdub2q28iMeS8yBCQPgdC2PY270WD87U6ty +l/aZ+CavO+EdiHCsNN88iB1pjbxqORM6SprQZ/4GxRdHR2v9pwAIwIVrcGqsUiN 9tdw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding:date:date :feedback-id:feedback-id:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:sender:subject :subject:to:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm2; t=1663833425; x=1663919825; bh=th2sup/cn4qdM LKWwS3nkwNaPb4V/XpWQof01u4I4tY=; b=PYcWSdT47kG9pJtA5TxjCGClmHD6t +coemDxf8RD4svyRFg7vz1mIgbA+tIqyGy7spUK7dsFaIdrakDDt5SSDgRgXwf3J 6T353/pxSci/LdwH0p8JAcbMHY9Ph7da8+u3ybOtbyMCRyJPred6jgSvpzrgjzYv AdFSrCjyVMDS9BzY2QpvqglwVk6HYaxo7AUnnpmVwWGGdOy7+/DJN5jOiuCC9EVv OxzvZAN0YTDGLGfXlvHqX99mIsed4K/Zo1H/9gzk1EjdlBcZ5XDdHdI/aqXrbhIZ TIBB56wa6mE1x53rcsKYCga9xWTvW2+cG9ahMzcOcwbN8MyZZiNJAU0IQ== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvfedrfeefvddguddviecutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfgh necuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmd enucfjughrpefhvfevufffkffojghfggfgsedtkeertdertddtnecuhfhrohhmpeetlhih shhsrgcutfhoshhsuceohhhisegrlhihshhsrgdrihhsqeenucggtffrrghtthgvrhhnpe egueeiudeukeekiedvteffgeekudfhudevvdelvdekhfefieetkeduudejffefgeenucev lhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpehqhihlihhssh esgidvvddtrdhqhihlihhsshdrnhgvth X-ME-Proxy: Feedback-ID: i12284293:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Thu, 22 Sep 2022 03:57:05 -0400 (EDT) Received: by x220.qyliss.net (Postfix, from userid 1000) id 788DD280; Thu, 22 Sep 2022 07:57:04 +0000 (UTC) From: Alyssa Ross To: devel@spectrum-os.org Subject: [PATCH 1/2] Set intel_iommu=on in kernel command line Date: Thu, 22 Sep 2022 07:56:28 +0000 Message-Id: <20220922075629.247058-2-hi@alyssa.is> X-Mailer: git-send-email 2.37.1 In-Reply-To: <20220922075629.247058-1-hi@alyssa.is> References: <20220922075629.247058-1-hi@alyssa.is> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Message-ID-Hash: OY75X5DVDOO6EQFCOMP2FORMFD5J5UXX X-Message-ID-Hash: OY75X5DVDOO6EQFCOMP2FORMFD5J5UXX X-MailFrom: qyliss@x220.qyliss.net X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-config-1; header-match-devel.spectrum-os.org-0; header-match-devel.spectrum-os.org-1; header-match-devel.spectrum-os.org-2; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: Vadim Likholetov X-Mailman-Version: 3.3.5 Precedence: list List-Id: Patches and low-level development discussion Archived-At: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: In Nixpkgs kernels, Intel IOMMUs are disabled by default (CONFIG_INTEL_IOMMU_DEFAULT_ON=n), so it needs to be explicitly enabled on the kernel command line. This was already done in the rootfs run make target, which is what I mostly use for testing, which is why I hadn't noticed until now. We could also set CONFIG_INTEL_IOMMU_DEFAULT_ON, but I think it's better to avoid changing our kernel configuration too much at the moment. (This might change in future if we want to go all in.) No changes are required for AMD IOMMUs, which are enabled by default. Reported-by: Vadim Likholetov Signed-off-by: Alyssa Ross --- host/initramfs/Makefile | 2 +- img/live/Makefile | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/host/initramfs/Makefile b/host/initramfs/Makefile index 1bdc407..596b15e 100644 --- a/host/initramfs/Makefile +++ b/host/initramfs/Makefile @@ -67,7 +67,7 @@ run: build/initramfs build/rootfs.verity.roothash build/live.img $(QEMU_KVM) -m 4G \ -kernel $(KERNEL) \ -initrd build/initramfs \ - -append "ro console=ttyS0 ext=vda roothash=$$(< build/rootfs.verity.roothash)" \ + -append "ro console=ttyS0 ext=vda intel_iommu=on roothash=$$(< build/rootfs.verity.roothash)" \ -cpu host \ -display gtk,gl=on \ -device virtio-vga-gl \ diff --git a/img/live/Makefile b/img/live/Makefile index 9815c88..f13dd26 100644 --- a/img/live/Makefile +++ b/img/live/Makefile @@ -26,7 +26,7 @@ build/spectrum.conf: build/rootfs.verity.roothash printf "title Spectrum\n" > $@ printf "linux /spectrum/linux\n" >> $@ printf "initrd /spectrum/initrd\n" >> $@ - printf "options ro console=tty console=ttyS0 roothash=" >> $@ + printf "options ro console=tty console=ttyS0 intel_iommu=on roothash=" >> $@ cat build/rootfs.verity.roothash >> $@ build/boot.fat: $(KERNEL) $(INITRAMFS) $(SYSTEMD_BOOT_EFI) build/spectrum.conf -- 2.37.1