patches and low-level development discussion
 help / color / mirror / code / Atom feed
From: Ivan Nikolaenko <ivan.nikolaenko@unikie.com>
To: devel@spectrum-os.org
Cc: Ivan Nikolaenko <ivan.nikolaenko@unikie.com>
Subject: [PATCH] EFI Loader: use correct arch suffix
Date: Tue, 27 Sep 2022 13:56:49 +0300	[thread overview]
Message-ID: <20220927105649.2265480-1-ivan.nikolaenko@unikie.com> (raw)

Previously there were hardcoded "x64" in EFI loaders' filenames.

Signed-off-by: Ivan Nikolaenko <ivan.nikolaenko@unikie.com>
---
 img/combined/default.nix |  5 +++--
 img/live/Makefile        |  2 +-
 img/live/default.nix     |  5 +++--
 nix/eval-config.nix      | 11 ++++++++++-
 4 files changed, 17 insertions(+), 6 deletions(-)

diff --git a/img/combined/default.nix b/img/combined/default.nix
index 3989d55..2086973 100644
--- a/img/combined/default.nix
+++ b/img/combined/default.nix
@@ -7,6 +7,7 @@
 let
   inherit (builtins) storeDir;
   inherit (pkgs.lib) removePrefix;
+  inherit (config) archSuffix;
 
   eosimages = import ./eosimages.nix { inherit config; };
 
@@ -74,8 +75,8 @@ let
     done
     mcopy -i $out ${grub}/share/grub/unicode.pf2 ::/grub/fonts
 
-    grub-mkimage -o grubx64.efi -p "(hd0,gpt1)/grub" -O ${grub.grubTarget} part_gpt fat
-    mcopy -i $out grubx64.efi ::/EFI/BOOT/BOOTX64.EFI
+    grub-mkimage -o grub${archSuffix}.efi -p "(hd0,gpt1)/grub" -O ${grub.grubTarget} part_gpt fat
+    mcopy -i $out grub${archSuffix}.efi ::/EFI/BOOT/BOOT${lib.toUpper archSuffix}.EFI
 
     fsck.vfat -n $out
   '';
diff --git a/img/live/Makefile b/img/live/Makefile
index 9815c88..e63c598 100644
--- a/img/live/Makefile
+++ b/img/live/Makefile
@@ -36,7 +36,7 @@ build/boot.fat: $(KERNEL) $(INITRAMFS) $(SYSTEMD_BOOT_EFI) build/spectrum.conf
 	$(MCOPY) -i $@ build/spectrum.conf ::/loader/entries
 	$(MCOPY) -i $@ $(KERNEL) ::/spectrum/linux
 	$(MCOPY) -i $@ $(INITRAMFS) ::/spectrum/initrd
-	$(MCOPY) -i $@ $(SYSTEMD_BOOT_EFI) ::/EFI/BOOT/BOOTX64.EFI
+	$(MCOPY) -i $@ $(SYSTEMD_BOOT_EFI) ::/EFI/BOOT/$(EFINAME)
 
 # veritysetup format produces two files, but Make only (portably)
 # supports one output per rule, so we combine the two outputs then
diff --git a/img/live/default.nix b/img/live/default.nix
index 65ad058..7be55ac 100644
--- a/img/live/default.nix
+++ b/img/live/default.nix
@@ -4,7 +4,7 @@
 { config ? import ../../nix/eval-config.nix {} }:
 
 let
-  inherit (config) pkgs;
+  inherit (config) pkgs archSuffix;
   inherit (pkgs.lib) cleanSource cleanSourceWith hasSuffix;
 
   extfs = pkgs.pkgsStatic.callPackage ../../host/initramfs/extfs.nix {
@@ -33,7 +33,8 @@ stdenvNoCC.mkDerivation {
   INITRAMFS = initramfs;
   KERNEL = "${rootfs.kernel}/${stdenv.hostPlatform.linux-kernel.target}";
   ROOT_FS = rootfs;
-  SYSTEMD_BOOT_EFI = "${systemd}/lib/systemd/boot/efi/systemd-bootx64.efi";
+  SYSTEMD_BOOT_EFI = "${systemd}/lib/systemd/boot/efi/systemd-boot${archSuffix}.efi";
+  EFINAME = "BOOT${lib.toUpper archSuffix}.EFI";
 
   buildFlags = [ "build/live.img" ];
   makeFlags = [ "SCRIPTS=${scripts}" ];
diff --git a/nix/eval-config.nix b/nix/eval-config.nix
index 467f877..4234321 100644
--- a/nix/eval-config.nix
+++ b/nix/eval-config.nix
@@ -8,6 +8,15 @@
   else {}
 }:
 
-({ pkgs ? import <nixpkgs> {} }: {
+({ pkgs ? import <nixpkgs> {} }: with pkgs; {
   inherit pkgs;
+
+  archSuffix =
+    if pkgs.stdenv.isx86_64 then
+      "x64"
+    else if pkgs.stdenv.isAarch64 then
+      "aa64"
+    else
+      throw "Unsupported architecture";
+
 }) config
-- 
2.25.1



             reply	other threads:[~2022-09-27 10:57 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-09-27 10:56 Ivan Nikolaenko [this message]
2022-09-27 11:17 ` [PATCH] EFI Loader: use correct arch suffix Alyssa Ross
2022-09-29  8:44   ` Alyssa Ross

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220927105649.2265480-1-ivan.nikolaenko@unikie.com \
    --to=ivan.nikolaenko@unikie.com \
    --cc=devel@spectrum-os.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://spectrum-os.org/git/crosvm
	https://spectrum-os.org/git/doc
	https://spectrum-os.org/git/mktuntap
	https://spectrum-os.org/git/nixpkgs
	https://spectrum-os.org/git/spectrum
	https://spectrum-os.org/git/ucspi-vsock
	https://spectrum-os.org/git/www

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).