From: Alyssa Ross <alyssa.ross@unikie.com>
To: devel@spectrum-os.org
Cc: Henri Rosten <henri.rosten@unikie.com>
Subject: [PATCH 1/2] Documentation/scripts: fix shellcheck issues
Date: Tue, 15 Nov 2022 10:56:36 +0000 [thread overview]
Message-ID: <20221115105637.298620-1-alyssa.ross@unikie.com> (raw)
There's an open issue about teaching shellcheck to automatically
recognize nix-shell shebangs:
https://github.com/koalaman/shellcheck/issues/1210
Signed-off-by: Alyssa Ross <alyssa.ross@unikie.com>
---
Documentation/scripts/build.sh | 2 +-
Documentation/scripts/update-gems.sh | 3 +++
2 files changed, 4 insertions(+), 1 deletion(-)
diff --git a/Documentation/scripts/build.sh b/Documentation/scripts/build.sh
index 85bd5a5..e6a2cd8 100755
--- a/Documentation/scripts/build.sh
+++ b/Documentation/scripts/build.sh
@@ -4,7 +4,7 @@
cd "$(dirname "$0")/.."
-if [ ! -w . -a ! -w .jekyll-cache ]; then
+if [ ! -w . ] && [ ! -w .jekyll-cache ]; then
JEKYLLFLAGS=--disable-disk-cache
fi
diff --git a/Documentation/scripts/update-gems.sh b/Documentation/scripts/update-gems.sh
index 7ba98d8..d70f55f 100755
--- a/Documentation/scripts/update-gems.sh
+++ b/Documentation/scripts/update-gems.sh
@@ -1,8 +1,11 @@
#! /usr/bin/env nix-shell
#! nix-shell -i bash -p bundler bundix
+
# SPDX-FileCopyrightText: 2022 Unikie
# SPDX-License-Identifier: EUPL-1.2+
+# shellcheck shell=bash
+
set -euo pipefail
bundle lock --update
--
2.35.1
next reply other threads:[~2022-11-15 10:57 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-15 10:56 Alyssa Ross [this message]
2022-11-15 10:56 ` [PATCH 2/2] nix/checks.nix: shellcheck more files Alyssa Ross
2022-11-16 8:56 ` Henri Rosten
2022-11-16 10:40 ` Alyssa Ross
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221115105637.298620-1-alyssa.ross@unikie.com \
--to=alyssa.ross@unikie.com \
--cc=devel@spectrum-os.org \
--cc=henri.rosten@unikie.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://spectrum-os.org/git/crosvm
https://spectrum-os.org/git/doc
https://spectrum-os.org/git/mktuntap
https://spectrum-os.org/git/nixpkgs
https://spectrum-os.org/git/spectrum
https://spectrum-os.org/git/ucspi-vsock
https://spectrum-os.org/git/www
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).