Re: [PATCH 2/2] nix/checks.nix: shellcheck more files

[Henri Rosten <henri.rosten@unikie.com>]

On Tue, Nov 15, 2022 at 10:56:37AM +0000, Alyssa Ross wrote:
> I didn't realise that bash's ** feature (which matches any depth of
> directories) wasn't enabled by default, because it appeared to work,
> just didn't find all scripts.

I'm getting shellcheck warnings from 
host/rootfs/build/etc/mdev/modalias.sh. Did you intentionally include 
scripts under 'build' too, or should those be excluded?

> 
> Signed-off-by: Alyssa Ross <alyssa.ross@unikie.com>
> Fixes: 169fdd6 ("release.nix: run shellcheck on build scripts")
> ---
>  nix/checks.nix | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/nix/checks.nix b/nix/checks.nix
> index 9eb261f..b2af72a 100644
> --- a/nix/checks.nix
> +++ b/nix/checks.nix
> @@ -17,6 +17,7 @@
>  
>        nativeBuildInputs = [ shellcheck ];
>      } ''
> +      shopt -s globstar
>        shellcheck $src/**/*.sh
>        touch $out
>      ''
> -- 
> 2.35.1
>