From mboxrd@z Thu Jan 1 00:00:00 1970 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on atuin.qyliss.net X-Spam-Level: X-Spam-Status: No, score=-1.1 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,MAILING_LIST_MULTI,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE autolearn=unavailable autolearn_force=no version=3.4.6 Received: from atuin.qyliss.net (localhost [IPv6:::1]) by atuin.qyliss.net (Postfix) with ESMTP id 7B3FC3337C; Wed, 16 Nov 2022 08:56:28 +0000 (UTC) Received: by atuin.qyliss.net (Postfix, from userid 496) id 7DB0C332D7; Wed, 16 Nov 2022 08:56:25 +0000 (UTC) Received: from mail-lj1-x234.google.com (mail-lj1-x234.google.com [IPv6:2a00:1450:4864:20::234]) by atuin.qyliss.net (Postfix) with ESMTPS id 43E20332D5 for ; Wed, 16 Nov 2022 08:56:22 +0000 (UTC) Received: by mail-lj1-x234.google.com with SMTP id u2so20938705ljl.3 for ; Wed, 16 Nov 2022 00:56:22 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=unikie.com; s=google; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=KWKxtlo8JGV8h9aOQWTldd9RZ06pUve1jCmsGwvXFeY=; b=GsTxF1qw8WejRqlnEPUmqLt2CcxcxltC7+J0uJWmwJ3CoWTXfG9riqROiepQqMR1FN Z3bgoGeqAhLWJm2Mv5ewhSUchnYuHPFMU0QVLebhN+UFKLGYZ6bmpCE6IAYqVOtZu8WW fLzImF242RMgoKtrzunX/3x+MdO68wDLO93Z6FMn/Z6qmKzNgcrIFcKxzwCW8hsPSeHc E/LJPuAcR+Lf8I55iPzkqyNDRlsCvBeCYyZq3lYnDN6jsUQyiKOICeix9xzdm52m1Tvr cYW5HTlaQi94NBJOn2oxnLKEQ9dsrH8Rm87mLpClrtXT9Jq/72couoKC2z8WuX2rYx8j fY/A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=KWKxtlo8JGV8h9aOQWTldd9RZ06pUve1jCmsGwvXFeY=; b=DprWrHuJ37XB/YoaP3qbvB/fwmwBrTdyJM13hF6XchsL1Vo5eH2IZs04ZHxHX5D0OV YH0d5qXzg0o19hm5Y3X8tcaHwIL05+YuY9Od1SXzb7vk97hJY3RpHipoO6tQC4ciDtoo idgtX0/JuPDjwGY2D/dqIcpMmFVVroi8VrNLKRbeS+wlIyh1BYQVf3FpzZIJKoVQ4IzN kYqN5tM4qlWYfd+h5C923b2rYei9RQO/rO0dcgGPJUx3QHPkVeCWxeSahTKbO/VcLExa zAGlKOxWV5tRjWepZMJmhEufrfnQTvL+j5nuqrQgM1228jhdnNEnFRi5/Yc5fxv14McX aCzQ== X-Gm-Message-State: ANoB5pmzNQHBYpm8VfQTs9jEKgpl221xsC0noez10cHAUFVsQPiOt3o3 JlrUywvS2XsvTy3PkDq31hNKhQ== X-Google-Smtp-Source: AA0mqf4muMw7SmlLxdsN4GhExMkZZnsLXbojw0TDFq+rVmR18Aj+9L90RG04JSl/uSz3rsAHZtd92Q== X-Received: by 2002:a2e:8e31:0:b0:277:5f7e:9c07 with SMTP id r17-20020a2e8e31000000b002775f7e9c07mr7106055ljk.495.1668588979694; Wed, 16 Nov 2022 00:56:19 -0800 (PST) Received: from buamix (86-60-162-79.dynamic.lounea.fi. [86.60.162.79]) by smtp.gmail.com with ESMTPSA id o9-20020ac24e89000000b004974da17c2bsm2508712lfr.0.2022.11.16.00.56.19 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 16 Nov 2022 00:56:19 -0800 (PST) Date: Wed, 16 Nov 2022 10:56:18 +0200 From: Henri Rosten To: Alyssa Ross Subject: Re: [PATCH 2/2] nix/checks.nix: shellcheck more files Message-ID: <20221116085618.GA1412553@buamix> References: <20221115105637.298620-1-alyssa.ross@unikie.com> <20221115105637.298620-2-alyssa.ross@unikie.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20221115105637.298620-2-alyssa.ross@unikie.com> Message-ID-Hash: QYYKK6EX2LGNMNQ2MUYBKGGFYWAGEVNC X-Message-ID-Hash: QYYKK6EX2LGNMNQ2MUYBKGGFYWAGEVNC X-MailFrom: henri.rosten@unikie.com X-Mailman-Rule-Hits: header-match-devel.spectrum-os.org-0 X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-config-1 CC: devel@spectrum-os.org X-Mailman-Version: 3.3.5 Precedence: list List-Id: Patches and low-level development discussion Archived-At: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On Tue, Nov 15, 2022 at 10:56:37AM +0000, Alyssa Ross wrote: > I didn't realise that bash's ** feature (which matches any depth of > directories) wasn't enabled by default, because it appeared to work, > just didn't find all scripts. I'm getting shellcheck warnings from host/rootfs/build/etc/mdev/modalias.sh. Did you intentionally include scripts under 'build' too, or should those be excluded? > > Signed-off-by: Alyssa Ross > Fixes: 169fdd6 ("release.nix: run shellcheck on build scripts") > --- > nix/checks.nix | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/nix/checks.nix b/nix/checks.nix > index 9eb261f..b2af72a 100644 > --- a/nix/checks.nix > +++ b/nix/checks.nix > @@ -17,6 +17,7 @@ > > nativeBuildInputs = [ shellcheck ]; > } '' > + shopt -s globstar > shellcheck $src/**/*.sh > touch $out > '' > -- > 2.35.1 >