From mboxrd@z Thu Jan 1 00:00:00 1970 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on atuin.qyliss.net X-Spam-Level: X-Spam-Status: No, score=-1.1 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,MAILING_LIST_MULTI,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE autolearn=unavailable autolearn_force=no version=3.4.6 Received: from atuin.qyliss.net (localhost [IPv6:::1]) by atuin.qyliss.net (Postfix) with ESMTP id BD21C339C5; Wed, 16 Nov 2022 10:40:19 +0000 (UTC) Received: by atuin.qyliss.net (Postfix, from userid 496) id AC0DC339A9; Wed, 16 Nov 2022 10:40:17 +0000 (UTC) Received: from mail-wm1-x32e.google.com (mail-wm1-x32e.google.com [IPv6:2a00:1450:4864:20::32e]) by atuin.qyliss.net (Postfix) with ESMTPS id EB94033944 for ; Wed, 16 Nov 2022 10:40:14 +0000 (UTC) Received: by mail-wm1-x32e.google.com with SMTP id i186-20020a1c3bc3000000b003cfe29a5733so1277696wma.3 for ; Wed, 16 Nov 2022 02:40:14 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=unikie.com; s=google; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=rZX72APXQVT9jyxmFLUzIQlxNTvbwFDUqpYgUwDxtQs=; b=N49pnFesy2y74QORQmwMXFXWtwbpmLuwVXgoJznsshuRLtGobGiDZgCuuNFlZIU3dw 3sd55H4J95AedXOrTjq0gdSBxk8nxl6R2FPZRB0wqViyo9aAwp9aI9UxGPDbnCXc4dMH UxXN9xmNl2DDCkpjujKecLT098mE7RK5ifTDCVrCC79RnjVaP2pWpu3N74UyXe2zTW5L 4eWDczU2sBGxpayJ8ZbaxyCy06IhlYKxru4u8A6M8TvUCgjYuMqz4dLgcQWSCCKuZsHy /sYLOtFtLJXgAhg/A51sqAK8nxJg8oNB9jczlDgZ1EWhivNk2wbFmEw8BzEc2BlIeEGn sIpA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=rZX72APXQVT9jyxmFLUzIQlxNTvbwFDUqpYgUwDxtQs=; b=bPImD6WzCAMp0p1Nv/Y8MUn+dnio51Ak1AiBKwOca/eYHzw+M0+KEkxkpaE3hZPJeE qZd51tjsDQLFcRR/IbURJEsdIYt8aDP8iKOkonPaUmGQg6jL++fQhI98Kva/u8yS01Ko SxLa42VvTvYI7NlMBrzpoKXK1PcdAmrGEHUVnNkBMEERXZoG/BM1RrPJAA0Bfz1IbwS/ QbdgatoN3yB7QeDjccIdtNdMfV4xlDD5xzSi39gxjl15JRdUip6zLTcuIq3FOTuZnWk7 IkHIQZFAE+BYQYmKnWulkHJ1CvPEX6Z9ryLeVV2pEvRKG8FHxV5KntYoy4popA+xbavE VgOg== X-Gm-Message-State: ANoB5plPR9HR0nk7LhzlxgMZKxK1DOhX6Dd1E4kfctDpsnNS7VN+vxyC sgv/CwSOKUyxw/ZDAiXj5ko4c6O39NINrdGn X-Google-Smtp-Source: AA0mqf7SBgqifLGGpF1oI1xiEVq9yKr8L3h6yXQ95UWvsR4NJeQJ4RqRnHduTZ0quMqo2V+fJCSRHQ== X-Received: by 2002:a05:600c:24e:b0:3c5:f9f1:f956 with SMTP id 14-20020a05600c024e00b003c5f9f1f956mr1725272wmj.50.1668595213013; Wed, 16 Nov 2022 02:40:13 -0800 (PST) Received: from x220.qyliss.net (p200300fcdf00b400ae9be2f2b7a3b27f.dip0.t-ipconnect.de. [2003:fc:df00:b400:ae9b:e2f2:b7a3:b27f]) by smtp.gmail.com with ESMTPSA id q125-20020a1c4383000000b003c6cd82596esm1612415wma.43.2022.11.16.02.40.11 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 16 Nov 2022 02:40:12 -0800 (PST) Received: by x220.qyliss.net (Postfix, from userid 1000) id 10E7D19540; Wed, 16 Nov 2022 10:40:11 +0000 (UTC) Date: Wed, 16 Nov 2022 10:40:11 +0000 From: Alyssa Ross To: Henri Rosten Subject: Re: [PATCH 2/2] nix/checks.nix: shellcheck more files Message-ID: <20221116104011.gnavjqmr7jws2q7z@x220> References: <20221115105637.298620-1-alyssa.ross@unikie.com> <20221115105637.298620-2-alyssa.ross@unikie.com> <20221116085618.GA1412553@buamix> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="5ctinw4jkmt2vtp2" Content-Disposition: inline In-Reply-To: <20221116085618.GA1412553@buamix> Message-ID-Hash: I747Z6KASX3MA5A37LNANPU3WACUGDQU X-Message-ID-Hash: I747Z6KASX3MA5A37LNANPU3WACUGDQU X-MailFrom: alyssa.ross@unikie.com X-Mailman-Rule-Hits: header-match-devel.spectrum-os.org-0 X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-config-1 CC: devel@spectrum-os.org X-Mailman-Version: 3.3.5 Precedence: list List-Id: Patches and low-level development discussion Archived-At: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: --5ctinw4jkmt2vtp2 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Wed, Nov 16, 2022 at 10:56:18AM +0200, Henri Rosten wrote: > On Tue, Nov 15, 2022 at 10:56:37AM +0000, Alyssa Ross wrote: > > I didn't realise that bash's ** feature (which matches any depth of > > directories) wasn't enabled by default, because it appeared to work, > > just didn't find all scripts. > > I'm getting shellcheck warnings from > host/rootfs/build/etc/mdev/modalias.sh. Did you intentionally include > scripts under 'build' too, or should those be excluded? They should indeed be excluded. Thanks for catching! --5ctinw4jkmt2vtp2 Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCAAdFiEEH9wgcxqlHM/ARR3h+dvtSFmyccAFAmN0vgEACgkQ+dvtSFmy ccDx2w//clgFENaaiCvm5GijYjylG1njHbBM/6lY8vm/OAUpANPAgWaC/wH0DWwu I32rYNjmG0WwnGUYUbDqZDzN6Mu7gqSpNvjed3Mg7eZQmBTY8/6QRvWZkj+XpPZF cXqVVF+0EUD/CVl+LMA0Sti4y/emx12MbeerhxNR9RRxZh3E6lDZ19FLf1UfgbmY +vp6r0k7uiTTp/gd6zLHjh2hhNBvZkLmikMJS30PWRPZlAWFTtr/tX3mRJwoe+dt J7piPDLly0iapGKbskqOIgc36BWi82dZxBWyxC2YEHmiFY2cx6RXxpMJQMI+B2XU KYkPj7jSSF2M8ZxpEulAoRFMGMQ7N3ufJXWDvtAahaR/U8KffvK4cGgVowHxZbEU jGE9/SWpcbjzPIi3vxLevRnmM5JV2YP1yv7CjvfPv0nMQiJREva0lOzJCvWiVFFn gTtMqkQQRvRHmJxGNubGIPgUnjWauQrKygUeJ535Ni5ay3UpeGxTO79boNTITuga oDS5vDuww3dgHuCcMwR7djFbEjYxPcNlYuyCIvIy/NtdGKkG9+3KmL+aHX0lQBUO XqQ6mmuRvHSXZ7Aex4LWsFzIb79D7pWT21rKJodVTHwB80kBTFnMkP4i5nnb6Y6y TEIgdf+pF27HpiJzwdt5cCHba4JYWV8B1p2ifpOf9JNWD9mGbJY= =jY3Z -----END PGP SIGNATURE----- --5ctinw4jkmt2vtp2--