Re: [PATCH] rootfs: make rootfs kernel configurable

[Alyssa Ross <hi@alyssa.is>]

[-- Attachment #1: Type: text/plain, Size: 1242 bytes --]

On Mon, Jan 09, 2023 at 04:34:33PM +0200, Ivan Nikolaenko wrote:
> This patch makes it possible to use custom linux kernel.
> This is needed in case of porting Spectrum OS to the other
> hardware than generic-x86.
>
> To override rootfs kernel, define "spectrum_kernel" in the
> customization overlay.
>
> Signed-off-by: Ivan Nikolaenko <ivan.nikolaenko@unikie.com>
> ---
>  host/rootfs/default.nix | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Did you change your mind from the approach you suggested in your
previous email? [1]  I liked that approach, because it didn't require
adding something custom to the global Nixpkgs namespace that's only used
in one place, outside of Nixpkgs.

[1]: https://spectrum-os.org/lists/archives/spectrum-devel/4d41315a-05d2-747c-3708-37f7c8c34684@unikie.com/

>
> diff --git a/host/rootfs/default.nix b/host/rootfs/default.nix
> index 0a84f55..b853250 100644
> --- a/host/rootfs/default.nix
> +++ b/host/rootfs/default.nix
> @@ -81,7 +81,7 @@ let
>      imports = [ (modulesPath + "/profiles/all-hardware.nix") ];
>    });
>
> -  kernel = pkgs.linux_latest;
> +  kernel = pkgs.spectrum_kernel or pkgs.linux_latest;
>
>    appvm = import ../../img/app {
>      inherit config;
> --
> 2.34.1
>
>

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]