From: Yureka <yuka@yuka.dev>
To: devel@spectrum-os.org
Cc: Yureka <yuka@yuka.dev>
Subject: [PATCH] host/start-vmm: replace jq calls with miniserde
Date: Sun, 25 Aug 2024 13:28:35 +0200 [thread overview]
Message-ID: <20240825112835.207659-1-yuka@yuka.dev> (raw)
---
host/start-vmm/ch.rs | 38 +++++++++++++++-----------------------
1 file changed, 15 insertions(+), 23 deletions(-)
diff --git a/host/start-vmm/ch.rs b/host/start-vmm/ch.rs
index cf164c6..abc6a00 100644
--- a/host/start-vmm/ch.rs
+++ b/host/start-vmm/ch.rs
@@ -9,7 +9,7 @@ use std::os::raw::{c_char, c_int};
use std::os::unix::prelude::*;
use std::process::{Command, Stdio};
-use miniserde::{json, Serialize};
+use miniserde::{json, Deserialize, Serialize};
use crate::net::MacAddress;
@@ -126,34 +126,26 @@ pub fn create_vm(vm_name: &str, mut config: VmConfig) -> Result<(), String> {
}
pub fn add_net(vm_name: &str, net: &NetConfig) -> Result<OsString, NonZeroI32> {
- let mut ch_remote = command(vm_name, "add-net")
+ let ch_output = command(vm_name, "add-net")
.arg(format!("fd={},mac={}", net.fd, net.mac))
- .stdout(Stdio::piped())
.spawn()
- .or(Err(EPERM))?;
+ .or(Err(EPERM))?
+ .wait_with_output()
+ .or(Err(EPROTO))?;
- let jq_out = match Command::new("jq")
- .args(["-j", ".id"])
- .stdin(ch_remote.stdout.take().unwrap())
- .stderr(Stdio::inherit())
- .output()
- {
- Ok(o) => o,
- Err(_) => {
- // Try not to leave a zombie.
- let _ = ch_remote.kill();
- let _ = ch_remote.wait();
- return Err(EPERM);
- }
- };
+ if !ch_output.status.success() {
+ return Err(EPROTO);
+ }
- if let Ok(ch_remote_status) = ch_remote.wait() {
- if ch_remote_status.success() && jq_out.status.success() {
- return Ok(OsString::from_vec(jq_out.stdout));
- }
+ #[derive(Deserialize)]
+ struct AddNetOutput {
+ id: String,
}
- Err(EPROTO)
+ let output_str = std::str::from_utf8(&ch_output.stdout).map_err(|_| EPROTO)?;
+ let output_parsed: AddNetOutput = json::from_str(output_str).map_err(|_| EPROTO)?;
+
+ Ok(OsString::from_vec(output_parsed.id.into()))
}
pub fn remove_device(vm_name: &str, device_id: &OsStr) -> Result<(), NonZeroI32> {
--
2.45.2
next reply other threads:[~2024-08-25 11:29 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-25 11:28 Yureka [this message]
2024-08-25 11:45 ` [PATCH] host/start-vmm: replace jq calls with miniserde Alyssa Ross
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240825112835.207659-1-yuka@yuka.dev \
--to=yuka@yuka.dev \
--cc=devel@spectrum-os.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://spectrum-os.org/git/crosvm
https://spectrum-os.org/git/doc
https://spectrum-os.org/git/mktuntap
https://spectrum-os.org/git/nixpkgs
https://spectrum-os.org/git/spectrum
https://spectrum-os.org/git/ucspi-vsock
https://spectrum-os.org/git/www
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).