From: Dom Rodriguez <shymega@shymega.org.uk>
To: devel@spectrum-os.org
Subject: [PATCH] crosvm: Rename `--vhost-user-{fs,gpu}` args
Date: Fri, 6 Sep 2024 10:34:30 +0100 [thread overview]
Message-ID: <20240906093430.1168464-1-shymega@shymega.org.uk> (raw)
crosvm was producing warnings when using `--vhost-user-gpu` and
`--vhost-user-fs`.
In this commit, I have adjusted the `crosvm` invocations to look
something like `--vhost-user $DEVICE`, where `$DEVICE` is, in this case,
`gpu` or `fs`.
I have run unit tests, but would appreciate testing.
Signed-off-by: Dom Rodriguez <shymega@shymega.org.uk>
---
img/app/Makefile | 4 ++--
release/checks/wayland/default.nix | 2 +-
2 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/img/app/Makefile b/img/app/Makefile
index 3adf8c4..fd8befe 100644
--- a/img/app/Makefile
+++ b/img/app/Makefile
@@ -152,8 +152,8 @@ run-crosvm: $(imgdir)/appvm/blk/root.img start-vhost-user-gpu start-virtiofsd
--disk $(RUN_IMG) \
-p "console=ttyS0 root=PARTLABEL=root" \
--net tap-name=tap0 \
- --vhost-user-fs build/virtiofsd.sock:virtiofs0 \
- --vhost-user-gpu build/vhost-user-gpu.sock \
+ --vhost-user fs build/virtiofsd.sock:virtiofs0 \
+ --vhost-user gpu build/vhost-user-gpu.sock \
--vsock cid=3 \
--serial type=file,hardware=serial,path=build/serial.log \
--serial type=stdout,hardware=virtio-console,stdin=true \
diff --git a/release/checks/wayland/default.nix b/release/checks/wayland/default.nix
index d05aa88..774c9b9 100644
--- a/release/checks/wayland/default.nix
+++ b/release/checks/wayland/default.nix
@@ -29,7 +29,7 @@ nixosTest ({ lib, pkgs, ... }: {
systemd.services.crosvm = {
after = [ "crosvm-gpu.service" "weston.service" ];
requires = [ "crosvm-gpu.service" "weston.service" ];
- serviceConfig.ExecStart = "${lib.getExe pkgs.crosvm} run -s /run/crosvm --disk ${appvm}/img/appvm/blk/root.img --disk ${run}/blk/run.img -p \"console=ttyS0 root=PARTLABEL=root\" --vhost-user-gpu /run/crosvm-gpu.sock --vsock cid=3 --serial type=stdout,hardware=virtio-console,stdin=true ${appvm}/img/appvm/vmlinux";
+ serviceConfig.ExecStart = "${lib.getExe pkgs.crosvm} run -s /run/crosvm --disk ${appvm}/img/appvm/blk/root.img --disk ${run}/blk/run.img -p \"console=ttyS0 root=PARTLABEL=root\" --vhost-user gpu /run/crosvm-gpu.sock --vsock cid=3 --serial type=stdout,hardware=virtio-console,stdin=true ${appvm}/img/appvm/vmlinux";
serviceConfig.ExecStop = "${lib.getExe pkgs.crosvm} stop /run/crosvm";
};
--
2.44.1
next reply other threads:[~2024-09-06 9:34 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-06 9:34 Dom Rodriguez [this message]
2024-09-06 11:22 ` [PATCH] crosvm: Rename `--vhost-user-{fs,gpu}` args Alyssa Ross
2024-09-06 22:41 ` Dom Rodriguez
2024-09-08 7:46 ` Alyssa Ross
2024-09-21 22:51 ` Dom Rodriguez
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240906093430.1168464-1-shymega@shymega.org.uk \
--to=shymega@shymega.org.uk \
--cc=devel@spectrum-os.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://spectrum-os.org/git/crosvm
https://spectrum-os.org/git/doc
https://spectrum-os.org/git/mktuntap
https://spectrum-os.org/git/nixpkgs
https://spectrum-os.org/git/spectrum
https://spectrum-os.org/git/ucspi-vsock
https://spectrum-os.org/git/www
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).