From: Alyssa Ross <hi@alyssa.is>
To: devel@spectrum-os.org
Subject: [PATCH] lib/common.mk: move .POSIX out
Date: Sun, 8 Sep 2024 16:47:49 +0200 [thread overview]
Message-ID: <20240908144749.842619-1-hi@alyssa.is> (raw)
The standard says the following, so I don't think it's specified that
it's allowed to be in an include file:
> If it appears as the first non-comment line in the makefile, make
> shall process the makefile as specified by this section; otherwise,
> the behavior of make is unspecified.
Link: https://pubs.opengroup.org/onlinepubs/9799919799/utilities/make.html#tag_20_76_13_04
Fixes: c3fbeca ("lib/common.mk: init")
Signed-off-by: Alyssa Ross <hi@alyssa.is>
---
host/initramfs/Makefile | 2 ++
host/rootfs/Makefile | 2 ++
img/app/Makefile | 2 ++
lib/common.mk | 2 --
release/live/Makefile | 2 ++
vm/sys/net/Makefile | 2 ++
6 files changed, 10 insertions(+), 2 deletions(-)
diff --git a/host/initramfs/Makefile b/host/initramfs/Makefile
index 06f69b3..8382296 100644
--- a/host/initramfs/Makefile
+++ b/host/initramfs/Makefile
@@ -1,6 +1,8 @@
# SPDX-License-Identifier: EUPL-1.2+
# SPDX-FileCopyrightText: 2021-2023 Alyssa Ross <hi@alyssa.is>
+.POSIX:
+
include ../../lib/common.mk
dest = build/initramfs
diff --git a/host/rootfs/Makefile b/host/rootfs/Makefile
index f4fb7a4..2f4445d 100644
--- a/host/rootfs/Makefile
+++ b/host/rootfs/Makefile
@@ -1,6 +1,8 @@
# SPDX-License-Identifier: EUPL-1.2+
# SPDX-FileCopyrightText: 2021-2024 Alyssa Ross <hi@alyssa.is>
+.POSIX:
+
include ../../lib/common.mk
dest = build/rootfs.erofs
diff --git a/img/app/Makefile b/img/app/Makefile
index 3adf8c4..79dd22e 100644
--- a/img/app/Makefile
+++ b/img/app/Makefile
@@ -2,6 +2,8 @@
# SPDX-FileCopyrightText: 2021-2024 Alyssa Ross <hi@alyssa.is>
# SPDX-FileCopyrightText: 2022 Unikie
+.POSIX:
+
include ../../lib/common.mk
prefix = build/host
diff --git a/lib/common.mk b/lib/common.mk
index 8f11ecc..7733878 100644
--- a/lib/common.mk
+++ b/lib/common.mk
@@ -1,8 +1,6 @@
# SPDX-License-Identifier: EUPL-1.2+
# SPDX-FileCopyrightText: 2021, 2023 Alyssa Ross <hi@alyssa.is>
-.POSIX:
-
# qemu-kvm is non-standard, but is present in at least Fedora and
# Nixpkgs. If you don't have qemu-kvm, you'll need to set e.g.
# QEMU_KVM = qemu-system-x86_64 -enable-kvm.
diff --git a/release/live/Makefile b/release/live/Makefile
index f45870d..a8c81c3 100644
--- a/release/live/Makefile
+++ b/release/live/Makefile
@@ -1,6 +1,8 @@
# SPDX-License-Identifier: EUPL-1.2+
# SPDX-FileCopyrightText: 2021-2023 Alyssa Ross <hi@alyssa.is>
+.POSIX:
+
include ../../lib/common.mk
dest = build/live.img
diff --git a/vm/sys/net/Makefile b/vm/sys/net/Makefile
index 00757db..2c2f084 100644
--- a/vm/sys/net/Makefile
+++ b/vm/sys/net/Makefile
@@ -1,6 +1,8 @@
# SPDX-License-Identifier: EUPL-1.2+
# SPDX-FileCopyrightText: 2021-2024 Alyssa Ross <hi@alyssa.is>
+.POSIX:
+
include ../../../lib/common.mk
prefix = build/svc
base-commit: 0f5cfe23285d31c3f7ea1d0fbca967fa8bae8d59
--
2.45.2
next reply other threads:[~2024-09-08 14:48 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-08 14:47 Alyssa Ross [this message]
2024-09-21 22:52 ` [PATCH] lib/common.mk: move .POSIX out Dom (shymega) Rodriguez
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240908144749.842619-1-hi@alyssa.is \
--to=hi@alyssa.is \
--cc=devel@spectrum-os.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://spectrum-os.org/git/crosvm
https://spectrum-os.org/git/doc
https://spectrum-os.org/git/mktuntap
https://spectrum-os.org/git/nixpkgs
https://spectrum-os.org/git/spectrum
https://spectrum-os.org/git/ucspi-vsock
https://spectrum-os.org/git/www
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).