From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from atuin.qyliss.net (localhost [IPv6:::1]) by atuin.qyliss.net (Postfix) with ESMTP id 1DF5019000; Thu, 07 Nov 2024 08:45:16 +0000 (UTC) Received: by atuin.qyliss.net (Postfix, from userid 993) id 5CFD718FE5; Thu, 07 Nov 2024 08:45:11 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-26) on atuin.qyliss.net X-Spam-Level: ** X-Spam-Status: No, score=2.3 required=5.0 tests=DMARC_NONE,FORGED_SPF_HELO, KHOP_HELO_FCRDNS,SPF_HELO_PASS autolearn=no autolearn_force=no version=4.0.1 Received: from LO3P265CU004.outbound.protection.outlook.com (mail-uksouthazlp170100001.outbound.protection.outlook.com [IPv6:2a01:111:f403:c205::1]) by atuin.qyliss.net (Postfix) with ESMTPS id 6943918F77 for ; Thu, 07 Nov 2024 08:45:09 +0000 (UTC) ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=imdJFgIfZCtvngnDvctYuK+8E93KyDNjbBZ5AW2SiR2wItq6gRgrgNJJv2Luqi3787dsRDsnLhfouQwhJHjS1ohvp+fu9dyCEqGQiSCtiNXvJHcm/GikgVGbMETKdM11f1slIOPodYTeEp3L/XkxMGtzEpspYRx9g+4ANaRxW2Lea7YI0SZJNJdJCLj4YF5KjvDdRL0Bz3P1JN+bU+mZhBoIYUNaVNhwKV5VHbDZiNYJa5/tKXaNEU5PgrcyToS7uMq9EZerpIANxBQe2sAp37b466aa2AwV2vb4YILSk9ZYuS6BO41EK+WfgrYA5v0MLOPFerA4BBTatjAJFYhZMQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=kuybGb4qgLegWsQve/mgvbYUdiWYA6412UW8vQsHC5M=; b=xMgjGaVrqudeCbIT0RslyesUr4deqNPC/KtZoDZLTJew76Qax4lQCIO5qdUWyK8wiPT0UsRy162epNMKfZPMJl+iL9GS28djxdbB2eOwDOqPBKrB99h8fmkWUGI57ODsa4MPJdxmeHbI/y9/LBHv1YojfCyS62z8rjY/KOZbww6b+J8B78InMkCwM1wPlCMOpUkwhDJDS0fm9uAdo6xGhaSdNiuuYRfUZoBHEJsUsRyRjEwM9ESBmj0lJhl3Q/pxEH4lDO9BsvByG2zEHzgO+OMCzulLkvaZQ4ObUIHJyPJ7RTdX3qE+dMt/6M1t6v2mxLs/BY4ci3K1IfX5roaAqQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 62.210.214.198) smtp.rcpttodomain=spectrum-os.org smtp.mailfrom=shymega.org.uk; dmarc=pass (p=none sp=none pct=100) action=none header.from=shymega.org.uk; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=shymega.org.uk; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=kuybGb4qgLegWsQve/mgvbYUdiWYA6412UW8vQsHC5M=; b=IVifV5aqF3GCsMlDRTP8XMhpx1udsBhvhIsiV0VjBQEbZ1MHYn8snxBH2/2OPRTHD0vto1dvXn+rYZQlPmz308D90rRydGZ7SOQE6GGGO6NghWTgTfCeMHX/gHpv0+UyMtrJ1T7TMvXNI9HwZ75Pj9nIbHFQL9f6G6Gi7fhuDG0yXSBLzc7U24ggrWEARFTk//uixntLftxndMPpB+A8/To2DZXeMloWknzbKe5sbPAEqGBAHaSyykLSbakMc3XPVDWALAcxWYm6iTT2pR49r3kmPWvoUzjMkgz+SsLp3zF3GVzv27PiagsMdNcU3Zzs0KR5D/2RTDXVbb7VBDNZoA== Received: from LO4P265CA0021.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:2ae::22) by LO4P265MB6261.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:27e::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8137.19; Thu, 7 Nov 2024 08:45:02 +0000 Received: from LO1PEPF000022FD.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:2ae:cafe::e6) by LO4P265CA0021.outlook.office365.com (2603:10a6:600:2ae::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8137.20 via Frontend Transport; Thu, 7 Nov 2024 08:45:02 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 62.210.214.198) smtp.mailfrom=shymega.org.uk; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=shymega.org.uk; Received-SPF: Pass (protection.outlook.com: domain of shymega.org.uk designates 62.210.214.198 as permitted sender) receiver=protection.outlook.com; client-ip=62.210.214.198; helo=oracle.rodriguez.org.uk; pr=C Received: from oracle.rodriguez.org.uk (62.210.214.198) by LO1PEPF000022FD.mail.protection.outlook.com (10.167.240.21) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.20.8137.17 via Frontend Transport; Thu, 7 Nov 2024 08:45:01 +0000 Received: from MORPHEUS-LINUX.localdomain (unknown [217.155.6.253]) by oracle.rodriguez.org.uk (Postfix) with ESMTPSA id A3CE2ACA0053 for ; Thu, 7 Nov 2024 08:45:01 +0000 (UTC) Received: from MORPHEUS-LINUX.fritz.box (localhost [IPv6:::1]) by MORPHEUS-LINUX.localdomain (Postfix) with ESMTP id D8733108250 for ; Thu, 07 Nov 2024 00:59:48 +0000 (GMT) From: Dom Rodriguez To: devel@spectrum-os.org Subject: [PATCH v3] crosvm: Rename `--vhost-user-gpu` flag Date: Thu, 7 Nov 2024 00:59:43 +0000 Message-ID: <20241107005948.2318591-1-shymega@shymega.org.uk> X-Mailer: git-send-email 2.44.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: LO1PEPF000022FD:EE_|LO4P265MB6261:EE_ Content-Type: text/plain X-MS-Office365-Filtering-Correlation-Id: 27622604-0ab5-4ecd-033f-08dcff087829 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|36860700013|82310400026|1800799024|376014; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?X5HmOYnUq372TyGki/NEq5IchZv7kArXOMmJf3fELlsS5InQAZfkRtx0Nu5i?= =?us-ascii?Q?JAqPvlCwXXF93Gqcl1KtQmikWhZbs/bnDB39AQrhF5COSF2e5xUA5bOtYTvQ?= =?us-ascii?Q?FEkDZO6MJble8hE0S9yt+Rws8AWLyF9t9QUsMghiKN8KD2UtIi2xuzaRLAps?= =?us-ascii?Q?+fma7zKSJmsdIBdrsKRioXb1FYgx9b5V+MzZeoDnkIxyzmPpIopyTb2K5zKp?= =?us-ascii?Q?URCUVfWIa+CndlFLDjN81hTAdp0zrFDlQztzVykqJ52LviNkakomucsNkpRL?= =?us-ascii?Q?C3VqBgxR1TUJIlbv2pDulTwcFyd9ulJqLcPFESpt1Hvl15IMjwyz0IUSOY+f?= =?us-ascii?Q?rWlqtFZmmrh8tbOpTw15GuDpX7r0VSCZYjdhhakCiX2Xq8SNA1KC5YpH3WHE?= =?us-ascii?Q?RSL7UE4OOldteS/j+/M8jO3aHxqoP0x8yl7ulspxkANsxYjHFAsFMCWndVmg?= =?us-ascii?Q?lGF5EMfbcNjYlPUOSoCfVQz3McA2wJP5Yppzts031pKw/xBYTCQZicVxxT/M?= =?us-ascii?Q?jL/uFp3zV5U4dkiObuuwFAirUm05xxoADvDbdxmRhZ1JqPOosb430XPzv3B3?= =?us-ascii?Q?8XVaUKltpEPSqFhMKTpVgXs4H17jvb5eh3drTMZAl4GL2eLDSZlvXYe8fNt0?= =?us-ascii?Q?nkGUVhi0Jf00fyvsbNUeO02k1QdM/xx/LFI4vI62jRanuBboFq9vgnVbmaT0?= =?us-ascii?Q?lZxu/HvubCMCSLKR382Wr6u6o8Te87JEXYwprH/ukRKL8wBSitXGhwC2I5bZ?= =?us-ascii?Q?DUTwAsnmY4TP/cJTL7T7zoEZ4tzFfImxpdIe7ysbpHSWOntaNYVFb70J8teZ?= =?us-ascii?Q?And0JCZ32MZB2rmx8MExsmzV/HK8zJyiXEd/Fi/yaSqRot4vTiuXXqVvfVqr?= =?us-ascii?Q?h0wSjdn9onv9E8GdbPMzVhKfhOYMsyJXXwDAYE9DZjiYkAW71dzduQ4KSwQ5?= =?us-ascii?Q?YurLbphtiHvfX98mAXLipxLlNI/w1DV9VGx5YxZfxw9SmY6GoBxzAJ64TOQ+?= =?us-ascii?Q?cAE1xlND02ZRwZe+xp80avRZDbNBzl8ianiv6TkIsILh3A0abmKZuY8ffPZa?= =?us-ascii?Q?Tn/c9SeVG21xzYTp7iYZDRYFh5gAi2ELlUWzr2GQWQJo+/Mg/FbbjHIu0h3B?= =?us-ascii?Q?e6csnFaGAUkcz5HhEDFTPM95T+6qgSghGsKvVKksmjEICz9vHdWikO7sFjwJ?= =?us-ascii?Q?SxzjzY5WMRlmuXGNDr/DnsdYjtP4pl0WP9RLrUNz3XN92oSJuRpVaah0uajp?= =?us-ascii?Q?WFZ4Tvvtx+/ncQ0PjTtefxRHl6KvM9BeECDeh+UuqckjoeA7h+qtNC0p6FEc?= =?us-ascii?Q?mNR7pDNyZJy1XJuE8LNlE2aX4rL9/ydIBUbLnh7D/Yxvqy4bZIK/Vke11nqj?= =?us-ascii?Q?KCEI7aw6lk5AV+iAh4YAmpvaAIJHDC8cyr5sgk1LLX9ZUB8raQ=3D=3D?= X-Forefront-Antispam-Report: CIP:62.210.214.198;CTRY:FR;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:oracle.rodriguez.org.uk;PTR:oracle.rodriguez.org.uk;CAT:NONE;SFS:(13230040)(36860700013)(82310400026)(1800799024)(376014);DIR:OUT;SFP:1102; X-OriginatorOrg: shymega.org.uk X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Nov 2024 08:45:01.9917 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 27622604-0ab5-4ecd-033f-08dcff087829 X-MS-Exchange-CrossTenant-Id: 7e15dc52-0465-4028-b82a-3c894bbc5ba6 X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=7e15dc52-0465-4028-b82a-3c894bbc5ba6;Ip=[62.210.214.198];Helo=[oracle.rodriguez.org.uk] X-MS-Exchange-CrossTenant-AuthSource: LO1PEPF000022FD.GBRP265.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: LO4P265MB6261 Message-ID-Hash: ABEHBG2D24XOMBBZNS3CSJ5YBREXCVWZ X-Message-ID-Hash: ABEHBG2D24XOMBBZNS3CSJ5YBREXCVWZ X-MailFrom: shymega@shymega.org.uk X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-devel.spectrum-os.org-0; header-match-devel.spectrum-os.org-1; header-match-devel.spectrum-os.org-2; header-match-devel.spectrum-os.org-3; header-match-devel.spectrum-os.org-4; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.9 Precedence: list List-Id: Patches and low-level development discussion Archived-At: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: crosvm was producing warnings when using `--vhost-user-gpu` and `--vhost-user-fs`, of which the former is fixable, but the latter requires some more work. The latter will be patched later on. To mitigate the former, I have adjusted the `crosvm` invocations to look something like `--vhost-user $DEVICE,socket=$PATH`, where `$DEVICE` is, in this case, `gpu`, and `$PATH` is the path to the Unix socket. Signed-off-by: Dom Rodriguez --- img/app/Makefile | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/img/app/Makefile b/img/app/Makefile index 7c3e3e8..db9fbea 100644 --- a/img/app/Makefile +++ b/img/app/Makefile @@ -167,7 +167,7 @@ run-crosvm: $(imgdir)/appvm/blk/root.img start-vhost-user-gpu start-virtiofsd -p "console=ttyS0 root=PARTLABEL=root" \ --net tap-name=tap0 \ --vhost-user-fs build/virtiofsd.sock:virtiofs0 \ - --vhost-user-gpu build/vhost-user-gpu.sock \ + --vhost-user gpu socket=build/vhost-user-gpu.sock \ --vsock cid=3 \ --serial type=file,hardware=serial,path=build/serial.log \ --serial type=stdout,hardware=virtio-console,stdin=true \ -- 2.44.1