From: Dom Rodriguez <shymega@shymega.org.uk>
To: devel@spectrum-os.org
Subject: [PATCH v4] crosvm: Rename `--vhost-user-gpu` flag
Date: Fri, 8 Nov 2024 18:12:50 +0000 [thread overview]
Message-ID: <20241108181450.1424488-1-shymega@shymega.org.uk> (raw)
crosvm was producing warnings when using `--vhost-user-gpu` and
`--vhost-user-fs`, of which the former is fixable, but the latter
requires some more work. The latter will be patched later on.
To mitigate the former, I have adjusted the `crosvm` invocations to look
something like `--vhost-user $DEVICE,socket=$PATH`, where `$DEVICE` is,
in this case, `gpu`, and `$PATH` is the path to the Unix socket.
Signed-off-by: Dom Rodriguez <shymega@shymega.org.uk>
---
The typo gremlins snuck into that last v3 patch, but hopefully v4 will
fix it.
img/app/Makefile | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/img/app/Makefile b/img/app/Makefile
index 2aa78a0..d914cab 100644
--- a/img/app/Makefile
+++ b/img/app/Makefile
@@ -168,7 +168,7 @@ run-crosvm: $(imgdir)/appvm/blk/root.img start-vhost-user-gpu start-virtiofsd
-p "console=ttyS0 root=PARTLABEL=root" \
--net tap-name=tap0 \
--vhost-user-fs build/virtiofsd.sock:virtiofs0 \
- --vhost-user-gpu build/vhost-user-gpu.sock \
+ --vhost-user gpu,socket=build/vhost-user-gpu.sock \
--vsock cid=3 \
--serial type=file,hardware=serial,path=build/serial.log \
--serial type=stdout,hardware=virtio-console,stdin=true \
--
2.44.1
next reply other threads:[~2024-11-09 2:00 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-11-08 18:12 Dom Rodriguez [this message]
2024-11-10 19:52 ` [PATCH v4] crosvm: Rename `--vhost-user-gpu` flag Alyssa Ross
2024-11-10 19:55 ` Alyssa Ross
2024-11-11 1:35 ` Dom Rodriguez
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241108181450.1424488-1-shymega@shymega.org.uk \
--to=shymega@shymega.org.uk \
--cc=devel@spectrum-os.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://spectrum-os.org/git/crosvm
https://spectrum-os.org/git/doc
https://spectrum-os.org/git/mktuntap
https://spectrum-os.org/git/nixpkgs
https://spectrum-os.org/git/spectrum
https://spectrum-os.org/git/ucspi-vsock
https://spectrum-os.org/git/www
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).