From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from atuin.qyliss.net (localhost [IPv6:::1]) by atuin.qyliss.net (Postfix) with ESMTP id CFDCC1AFE7; Sat, 09 Nov 2024 02:00:34 +0000 (UTC) Received: by atuin.qyliss.net (Postfix, from userid 993) id DC7031AFA2; Sat, 09 Nov 2024 02:00:16 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-26) on atuin.qyliss.net X-Spam-Level: X-Spam-Status: No, score=0.9 required=5.0 tests=DMARC_NONE,RCVD_IN_DNSWL_NONE, SPF_HELO_NONE autolearn=no autolearn_force=no version=4.0.1 Received: from LO0P265CU003.outbound.protection.outlook.com (mail-uksouthazlp170120005.outbound.protection.outlook.com [IPv6:2a01:111:f403:c205::5]) by atuin.qyliss.net (Postfix) with ESMTPS id D08F51AF9E for ; Sat, 09 Nov 2024 02:00:13 +0000 (UTC) ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=Z4QN2A0tGqIta8zn9sA7gZod17Nj/uAb9Lib0sMFBXBDuQqdorLMBXNLl6nAhPlmECeovXhHlJIfSCU5gWuiRhG70atHoakWWMFpRRj5FD069D03PpFaQSkWiJK8J85MQH+VhMx8WrOm2pBHwi1iYDRUtFisda/sYFhw+0hZLUQ1h5nk9ansDdITYX3NjQDf8a7+SrvgvxaLotQABGLrWDEoUzncrlmqJZKUxdyrG0ZjG/VV0fLffmkCrYqgnQtgRv30Xg9wuQ9bOs3I8N4Ihbnp3GxJHOUjvMfL81EZ1ToMrwX4DPoZw8m5lSxwIXNz9D64ojdjCioM+BMiqLs4aw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=KAXZFTnWE0ZH+aCXA6evkqbYoqqxDJN3aNxCFVHvpBA=; b=nvD1GBkUOY3Rx1eGiJ/cSDIKSqnYSxqvgtvLqQlmRObOlRRNquIFzdiTFxx/wgTt5SqSayYMrUcMr4a52w8NyrmXizoJNRu8mHqMPIxGTmQyLX7nyJzXu8DU1OLaTyn357CP3y+YU2z8wh17HMOfq+N+7pRaLsyFwKo9krBN17lFdCCjFVzzYTWkAQS8aMVLJdymS2GYWWyxlYwF0SQ9vmzjhJHZdPDavWjrmjpTaLBKiHNw1OaGK6gGwZwpYAQWMv3HclO295BhoaC574Xq1GAOko/31vS8kRh5LXnHgxcqPFcHXsdneTR/BI2FQg8HXHP1dHt+dkqtFGST6YSKpQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 62.210.214.198) smtp.rcpttodomain=spectrum-os.org smtp.mailfrom=shymega.org.uk; dmarc=pass (p=none sp=none pct=100) action=none header.from=shymega.org.uk; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=shymega.org.uk; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=KAXZFTnWE0ZH+aCXA6evkqbYoqqxDJN3aNxCFVHvpBA=; b=O3k44qbaALlh4H31OvO86Etq0ZlE+a0q/2QtVlBSEdCTD1cheK53T4dHqE0xShkdeAshgAajD0ZYvZPe4uneeLh+1uq/VAAk3jxnobjA+OzHBZgVb23UObf0FRw5BrFy1oO8yYTarIqjHixqUXXq+FYjEn3rhUyHFf+S7z4bF6UfxvYWxpCia0nb/AH9D6Lle/4W13d2H5NlAB1ZozVYuo3ZNOHOAw4IzjsY7k0+oY2/UJyat/M6xBVioK+VW079lVhlmOOQSkrhBVfQvTZTGG1QcevAyyzH8iYp64Gdb2cfJ1R/t73IwVMMI29uivIXE44igw/csHB7w7Jb9aw8PQ== Received: from LO4P123CA0556.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:33b::6) by LO2P265MB7217.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:32e::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8137.22; Sat, 9 Nov 2024 02:00:02 +0000 Received: from LN2PEPF000100CA.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:33b:cafe::e7) by LO4P123CA0556.outlook.office365.com (2603:10a6:600:33b::6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8137.26 via Frontend Transport; Sat, 9 Nov 2024 02:00:02 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 62.210.214.198) smtp.mailfrom=shymega.org.uk; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=shymega.org.uk; Received-SPF: Pass (protection.outlook.com: domain of shymega.org.uk designates 62.210.214.198 as permitted sender) receiver=protection.outlook.com; client-ip=62.210.214.198; helo=oracle.rodriguez.org.uk; pr=C Received: from oracle.rodriguez.org.uk (62.210.214.198) by LN2PEPF000100CA.mail.protection.outlook.com (10.167.240.4) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.20.8137.17 via Frontend Transport; Sat, 9 Nov 2024 02:00:02 +0000 Received: from MORPHEUS-LINUX.localdomain (unknown [217.155.6.253]) by oracle.rodriguez.org.uk (Postfix) with ESMTPSA id BD6C4ACA0055 for ; Sat, 9 Nov 2024 02:00:01 +0000 (UTC) Received: from MORPHEUS-LINUX.fritz.box (localhost [IPv6:::1]) by MORPHEUS-LINUX.localdomain (Postfix) with ESMTP id 2B61D108163 for ; Fri, 08 Nov 2024 18:14:50 +0000 (GMT) From: Dom Rodriguez To: devel@spectrum-os.org Subject: [PATCH v4] crosvm: Rename `--vhost-user-gpu` flag Date: Fri, 8 Nov 2024 18:12:50 +0000 Message-ID: <20241108181450.1424488-1-shymega@shymega.org.uk> X-Mailer: git-send-email 2.44.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: LN2PEPF000100CA:EE_|LO2P265MB7217:EE_ Content-Type: text/plain X-MS-Office365-Filtering-Correlation-Id: d8f0ceb1-36c6-4db6-0d32-08dd0062391e X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|1800799024|376014|82310400026|36860700013; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?SXc2lUvxJbhl7XINhXkr/msvXJNBJvzeOAArqCG9oxsbcBUmFFK9jAdoIDjp?= =?us-ascii?Q?49MN0TWQ1/kSg96r3FHC+qx4iYI3CPwnrmqTd3KO+HXXZ5bQUSH9ddA2CV9H?= =?us-ascii?Q?RQAGqtqaGegMKg/neM1xceOE+6YN1TWzjVvrt3SwZEUUWoWdnXTf7fuYMaNK?= =?us-ascii?Q?Cyq92cNWlLmZPwmy36N8E8p1PTSFBJU7u5On2ik19/u0ZGBeoecOe+A1Bp4G?= =?us-ascii?Q?ocylHYMOL2m8cC4ifbqmR9RzymKBrNYBakI6Yux6zQTVwqHnwMJtHBl5q3h4?= =?us-ascii?Q?LhQkkf9dEI6gPj9XWxAzDk0NXKhPq0E8AKrtXTCkn3FIVpfuO51zXCCN8hYJ?= =?us-ascii?Q?RD6y4lxIBlRkJ3RyeFf3QqCsQ9YIdm9XlohgjdIyU5vaRAYLLBox0723Gslw?= =?us-ascii?Q?/YCWZvtKeufHm+tJUcTomi/HbJW3D4Dd0e6iuklp0BplU2+2RDeAk1ItONvE?= =?us-ascii?Q?Ud8PGZYtfF5h8WRGVk34Rz3qVsmaXtwlgmcwLYxGPtiVANie/KNplNXDgJ59?= =?us-ascii?Q?ks2jMGZbBv4KTaywn8kkgzoUmWmyBhM9Uo33ifLIl9wFFxOAb8eXQXwFtdQ+?= =?us-ascii?Q?dLX/vXXjqcAK+YbBiEyF4mSY8XlEkYfclk9+tonm4KkY1X+dCEnsRszaEBhs?= =?us-ascii?Q?J8W5Y0lrjSxMslHO3iPEYFs6099GCSd/1aRhCg05ghk+fZocq6FCGLPxL7rY?= =?us-ascii?Q?uS6sz7Zgp0ZOW6wDxFAepRk9SQO09w1IIpNJjnEOKfrCzk+IKd94tH4JX5ty?= =?us-ascii?Q?adhrOWWc+9A1C9xV7v9lioDuxCnkpj5Kr9lWmVeWKKiaVhF6Pt2QL+TF84SE?= =?us-ascii?Q?f6dD35bEy3RyP2LL3l4Vxn1/hGGuO10efMQHUwsE7cAfD39C3/2ZTeyvP0pS?= =?us-ascii?Q?BOInrQuZhO66/FdkoIzyycK8nMF823sn8elp1Ne6F9hS3HwCa3tLtBB4NO04?= =?us-ascii?Q?XLK+tlmPWAzqPiLeBfF+bGbuTFVNjDO7m70rkIj1AbvBWGuuIXi9ziwOE3d4?= =?us-ascii?Q?d01PH4opIRAyAONdYyaasZMdzHjuc2JARE9Kc6x1ePmgHYgWED9S0Kn1DqET?= =?us-ascii?Q?3vbi5S/ZPprnW8+WKn+h2aRjKFrF1i4GnfYpY0ar4qolVhAU3taTmOxFcmjQ?= =?us-ascii?Q?cnt0mH47waUSLeraOXsxDpSMsaNAjNH+Ltr5DjThQwAulK5Fkft3MwovPRn4?= =?us-ascii?Q?An6jXvHLT4UyWb4X6wIT/MsBj8qKBoHUplnJOn0jVbC5OXuugpkdhucpd1GR?= =?us-ascii?Q?y054x8aXoROmI3X1VJ+pJkrkCnJygTuHhblwje4Kk71wPSoRYFIeHrZf/6DU?= =?us-ascii?Q?yGHjbMqeygQwyz4fomM62jFmKY/ZKmVCcIlJKng4w5ESx6Z+U5MjMDOivxrJ?= =?us-ascii?Q?1pDWjU0piefBk9Gdg2Pm/lPB1xIxeEn6eJvYUNW376LmDzntPQ=3D=3D?= X-Forefront-Antispam-Report: CIP:62.210.214.198;CTRY:FR;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:oracle.rodriguez.org.uk;PTR:oracle.rodriguez.org.uk;CAT:NONE;SFS:(13230040)(1800799024)(376014)(82310400026)(36860700013);DIR:OUT;SFP:1102; X-OriginatorOrg: shymega.org.uk X-MS-Exchange-CrossTenant-OriginalArrivalTime: 09 Nov 2024 02:00:02.0919 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: d8f0ceb1-36c6-4db6-0d32-08dd0062391e X-MS-Exchange-CrossTenant-Id: 7e15dc52-0465-4028-b82a-3c894bbc5ba6 X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=7e15dc52-0465-4028-b82a-3c894bbc5ba6;Ip=[62.210.214.198];Helo=[oracle.rodriguez.org.uk] X-MS-Exchange-CrossTenant-AuthSource: LN2PEPF000100CA.GBRP265.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: LO2P265MB7217 Message-ID-Hash: VFJBEN2FTJP4ZEV37YJJN6EBESCEVVTR X-Message-ID-Hash: VFJBEN2FTJP4ZEV37YJJN6EBESCEVVTR X-MailFrom: shymega@shymega.org.uk X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-devel.spectrum-os.org-0; header-match-devel.spectrum-os.org-1; header-match-devel.spectrum-os.org-2; header-match-devel.spectrum-os.org-3; header-match-devel.spectrum-os.org-4; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.9 Precedence: list List-Id: Patches and low-level development discussion Archived-At: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: crosvm was producing warnings when using `--vhost-user-gpu` and `--vhost-user-fs`, of which the former is fixable, but the latter requires some more work. The latter will be patched later on. To mitigate the former, I have adjusted the `crosvm` invocations to look something like `--vhost-user $DEVICE,socket=$PATH`, where `$DEVICE` is, in this case, `gpu`, and `$PATH` is the path to the Unix socket. Signed-off-by: Dom Rodriguez --- The typo gremlins snuck into that last v3 patch, but hopefully v4 will fix it. img/app/Makefile | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/img/app/Makefile b/img/app/Makefile index 2aa78a0..d914cab 100644 --- a/img/app/Makefile +++ b/img/app/Makefile @@ -168,7 +168,7 @@ run-crosvm: $(imgdir)/appvm/blk/root.img start-vhost-user-gpu start-virtiofsd -p "console=ttyS0 root=PARTLABEL=root" \ --net tap-name=tap0 \ --vhost-user-fs build/virtiofsd.sock:virtiofs0 \ - --vhost-user-gpu build/vhost-user-gpu.sock \ + --vhost-user gpu,socket=build/vhost-user-gpu.sock \ --vsock cid=3 \ --serial type=file,hardware=serial,path=build/serial.log \ --serial type=stdout,hardware=virtio-console,stdin=true \ -- 2.44.1