From: Dom Rodriguez <shymega@shymega.org.uk>
To: devel@spectrum-os.org
Subject: [PATCH v1] crosvm: Rename `--vhost-user-gpu` flag in checks
Date: Mon, 11 Nov 2024 01:28:33 +0000 [thread overview]
Message-ID: <20241111012846.3137729-1-shymega@shymega.org.uk> (raw)
Following on from c9052a4, Alyssa quite rightly pointed out the
remaining `--vhost-user-gpu` invocation in the release checks (Wayland).
Same principle as c9052a4, just one more replacement to the crosvm flag.
Signed-off-by: Dom Rodriguez <shymega@shymega.org.uk>
---
release/checks/wayland/default.nix | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/release/checks/wayland/default.nix b/release/checks/wayland/default.nix
index d4806db..083e60d 100644
--- a/release/checks/wayland/default.nix
+++ b/release/checks/wayland/default.nix
@@ -38,7 +38,7 @@ nixosTest ({ lib, pkgs, ... }: {
systemd.services.crosvm = {
after = [ "crosvm-gpu.service" "weston.service" ];
requires = [ "crosvm-gpu.service" "weston.service" ];
- serviceConfig.ExecStart = "${lib.getExe pkgs.crosvm} run -s /run/crosvm --disk ${appvm}/img/appvm/blk/root.img -p \"console=ttyS0 root=PARTLABEL=root\" --vhost-user-fs /run/virtiofsd.sock,tag=virtiofs0 --vhost-user-gpu /run/crosvm-gpu.sock --vsock cid=3 --serial type=stdout,hardware=virtio-console,stdin=true ${appvm}/img/appvm/vmlinux";
+ serviceConfig.ExecStart = "${lib.getExe pkgs.crosvm} run -s /run/crosvm --disk ${appvm}/img/appvm/blk/root.img -p \"console=ttyS0 root=PARTLABEL=root\" --vhost-user-fs /run/virtiofsd.sock,tag=virtiofs0 --vhost-user gpu,socket=/run/crosvm-gpu.sock --vsock cid=3 --serial type=stdout,hardware=virtio-console,stdin=true ${appvm}/img/appvm/vmlinux";
serviceConfig.ExecStop = "${lib.getExe pkgs.crosvm} stop /run/crosvm";
};
--
2.44.2
next reply other threads:[~2024-11-11 8:30 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-11-11 1:28 Dom Rodriguez [this message]
2024-11-11 10:42 ` [PATCH v1] crosvm: Rename `--vhost-user-gpu` flag in checks Alyssa Ross
2024-11-11 10:46 ` Alyssa Ross
2024-11-12 22:19 ` Dom Rodriguez
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241111012846.3137729-1-shymega@shymega.org.uk \
--to=shymega@shymega.org.uk \
--cc=devel@spectrum-os.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://spectrum-os.org/git/crosvm
https://spectrum-os.org/git/doc
https://spectrum-os.org/git/mktuntap
https://spectrum-os.org/git/nixpkgs
https://spectrum-os.org/git/spectrum
https://spectrum-os.org/git/ucspi-vsock
https://spectrum-os.org/git/www
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).