From: Alyssa Ross <hi@alyssa.is>
To: devel@spectrum-os.org
Subject: [PATCH] release/combined: fix for __structuredAttrs
Date: Sat, 30 Nov 2024 21:15:06 +0100 [thread overview]
Message-ID: <20241130201506.507062-1-hi@alyssa.is> (raw)
When I set __structuredAttrs for this derivation, these variables were
no longer passed to the build, resulting in GRUB not getting installed
properly.
Fixes: 296ccff ("Build images with __structuredAttrs")
Signed-off-by: Alyssa Ross <hi@alyssa.is>
---
release/combined/default.nix | 21 ++++++++++++++-------
1 file changed, 14 insertions(+), 7 deletions(-)
diff --git a/release/combined/default.nix b/release/combined/default.nix
index 764e2c3..537c5ef 100644
--- a/release/combined/default.nix
+++ b/release/combined/default.nix
@@ -60,15 +60,22 @@ let
esp = runCommand "esp.img" {
nativeBuildInputs = [ grub libfaketime dosfstools mtools ];
- grubTargetDir = "${grub}/lib/grub/${grub.grubTarget}";
- # Definition copied from util/grub-install-common.c.
- # Last checked: GRUB 2.06
- pkglib_DATA = [
- "efiemu32.o" "efiemu64.o" "moddep.lst" "command.lst" "fs.lst" "partmap.lst"
- "parttool.lst" "video.lst" "crypto.lst" "terminal.lst" "modinfo.sh"
- ];
+
+ env = {
+ grubTargetDir = "${grub}/lib/grub/${grub.grubTarget}";
+ # Definition copied from util/grub-install-common.c.
+ # Last checked: GRUB 2.06
+ pkglib_DATA = lib.escapeShellArgs [
+ "efiemu32.o" "efiemu64.o" "moddep.lst" "command.lst" "fs.lst"
+ "partmap.lst" "parttool.lst" "video.lst" "crypto.lst" "terminal.lst"
+ "modinfo.sh"
+ ];
+ };
+
__structuredAttrs = true;
+
unsafeDiscardReferences = { out = true; };
+
passthru = { inherit grubCfg; };
} ''
truncate -s 15M $out
base-commit: 741ed49303ffaba63c409962326ab447639e6e20
--
2.47.0
reply other threads:[~2024-11-30 20:16 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241130201506.507062-1-hi@alyssa.is \
--to=hi@alyssa.is \
--cc=devel@spectrum-os.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://spectrum-os.org/git/crosvm
https://spectrum-os.org/git/doc
https://spectrum-os.org/git/mktuntap
https://spectrum-os.org/git/nixpkgs
https://spectrum-os.org/git/spectrum
https://spectrum-os.org/git/ucspi-vsock
https://spectrum-os.org/git/www
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).