patches and low-level development discussion
 help / color / mirror / code / Atom feed
* [PATCH] release/combined: fix for __structuredAttrs
@ 2024-11-30 20:15 Alyssa Ross
  0 siblings, 0 replies; only message in thread
From: Alyssa Ross @ 2024-11-30 20:15 UTC (permalink / raw)
  To: devel

When I set __structuredAttrs for this derivation, these variables were
no longer passed to the build, resulting in GRUB not getting installed
properly.

Fixes: 296ccff ("Build images with __structuredAttrs")
Signed-off-by: Alyssa Ross <hi@alyssa.is>
---
 release/combined/default.nix | 21 ++++++++++++++-------
 1 file changed, 14 insertions(+), 7 deletions(-)

diff --git a/release/combined/default.nix b/release/combined/default.nix
index 764e2c3..537c5ef 100644
--- a/release/combined/default.nix
+++ b/release/combined/default.nix
@@ -60,15 +60,22 @@ let
 
   esp = runCommand "esp.img" {
     nativeBuildInputs = [ grub libfaketime dosfstools mtools ];
-    grubTargetDir = "${grub}/lib/grub/${grub.grubTarget}";
-    # Definition copied from util/grub-install-common.c.
-    # Last checked: GRUB 2.06
-    pkglib_DATA = [
-      "efiemu32.o" "efiemu64.o" "moddep.lst" "command.lst" "fs.lst" "partmap.lst"
-      "parttool.lst" "video.lst" "crypto.lst" "terminal.lst" "modinfo.sh"
-    ];
+
+    env = {
+      grubTargetDir = "${grub}/lib/grub/${grub.grubTarget}";
+      # Definition copied from util/grub-install-common.c.
+      # Last checked: GRUB 2.06
+      pkglib_DATA = lib.escapeShellArgs [
+        "efiemu32.o" "efiemu64.o" "moddep.lst" "command.lst" "fs.lst"
+        "partmap.lst" "parttool.lst" "video.lst" "crypto.lst" "terminal.lst"
+        "modinfo.sh"
+      ];
+    };
+
     __structuredAttrs = true;
+
     unsafeDiscardReferences = { out = true; };
+
     passthru = { inherit grubCfg; };
   } ''
     truncate -s 15M $out

base-commit: 741ed49303ffaba63c409962326ab447639e6e20
-- 
2.47.0


^ permalink raw reply related	[flat|nested] only message in thread

only message in thread, other threads:[~2024-11-30 20:16 UTC | newest]

Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-11-30 20:15 [PATCH] release/combined: fix for __structuredAttrs Alyssa Ross

Code repositories for project(s) associated with this public inbox

	https://spectrum-os.org/git/crosvm
	https://spectrum-os.org/git/doc
	https://spectrum-os.org/git/mktuntap
	https://spectrum-os.org/git/nixpkgs
	https://spectrum-os.org/git/spectrum
	https://spectrum-os.org/git/ucspi-vsock
	https://spectrum-os.org/git/www

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).