From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from atuin.qyliss.net (localhost [IPv6:::1]) by atuin.qyliss.net (Postfix) with ESMTP id B85D8D2AC; Fri, 13 Jun 2025 14:05:31 +0000 (UTC) Received: by atuin.qyliss.net (Postfix, from userid 993) id C2583D299; Fri, 13 Jun 2025 14:05:28 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-26) on atuin.qyliss.net X-Spam-Level: X-Spam-Status: No, score=-0.8 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,DMARC_MISSING,RCVD_IN_DNSWL_LOW,RCVD_IN_MSPIKE_H2, SPF_HELO_PASS autolearn=unavailable autolearn_force=no version=4.0.1 Received: from fout-a1-smtp.messagingengine.com (fout-a1-smtp.messagingengine.com [103.168.172.144]) by atuin.qyliss.net (Postfix) with ESMTPS id 59A35D24C for ; Fri, 13 Jun 2025 14:05:26 +0000 (UTC) Received: from phl-compute-01.internal (phl-compute-01.phl.internal [10.202.2.41]) by mailfout.phl.internal (Postfix) with ESMTP id 6DE031380449; Fri, 13 Jun 2025 10:05:23 -0400 (EDT) Received: from phl-mailfrontend-02 ([10.202.2.163]) by phl-compute-01.internal (MEProxy); Fri, 13 Jun 2025 10:05:23 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=alyssa.is; h=cc :cc:content-transfer-encoding:content-type:date:date:from:from :in-reply-to:message-id:mime-version:reply-to:subject:subject:to :to; s=fm3; t=1749823523; x=1749909923; bh=oRKVYTnqGt/8DEXUvj6Kx bq8Xuubhq26Cgyv9YoCUSw=; b=X6HN/CBl+BUXDRrP/8RjUbDEFpSQRETi1M/ri Bih5PHBc6sCrRM0Gtarm7/Tzt1/2T+Wr+J0TqjVwQeOKcgSv12mLRVYgf9xOTdB0 00JyeUWqjuxLcRDQ1PnqpbL1gbPDzIefSks5nojUTxPOQNSg6IaDSWGig+ciAS6w hcJBM4sFurrfutBPKNd9rxdBX1g6GmMiN8M6Znp+yRIK9DwBQNyFS6Sv+k/8hRfP 64HIlViHJj0D+YH2Gv2xd6sn0pbNv0XTgCWRZghIE/VhW0bHvo6z0eQw9h15iqIE coly2ySd/4W23y/B18cBCDKscHdHy2vP3xDAkBEZFde+KHpiw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:date:date:feedback-id:feedback-id:from:from :in-reply-to:message-id:mime-version:reply-to:subject:subject:to :to:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm1; t= 1749823523; x=1749909923; bh=oRKVYTnqGt/8DEXUvj6Kxbq8Xuubhq26Cgy v9YoCUSw=; b=dz0lFQtaHrdDABzxAUusFFROXZIXXmJMl8YKSagNdR0ma0lNwFw zcVLSJirrcrh7Zd90l9yw/SFjW2/wYNJvStcRPH4Kx0ZsmaKqNveupvkvjsVv+Ug r0y+ttlHFYZBBrp+Eep9hIBOa24JKLMA67w4z15ST6enyBTV2bqfefS8iLcMItdj HFDX78/sunwylhp0dXOLPMzamElLf6QnVQLjNujHS2UZYjyWW6pqo1ZRCpx+4gVg xkK2CfrxJNYAemoZlL+z//TaCiio3AV1nW12si+ngMg6YqAFmXv51AYv0mUkwf7X gXKq7E8x8XnplbTPbnO0CcMpHBhRV3GqMDQ== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeeffedrtddugddukedugecutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpggftfghnshhusghstghrihgsvgdp uffrtefokffrpgfnqfghnecuuegrihhlohhuthemuceftddtnecunecujfgurhephffvve fufffkofgggfestdekredtredttdenucfhrhhomheptehlhihsshgrucftohhsshcuoehh ihesrghlhihsshgrrdhisheqnecuggftrfgrthhtvghrnhepheekgfdtveettdekudduge eugfdujeehuefgleegtedthfffudfhheduhfduuefhnecuvehluhhsthgvrhfuihiivgep tdenucfrrghrrghmpehmrghilhhfrhhomhephhhisegrlhihshhsrgdrihhspdhnsggprh gtphhtthhopedvpdhmohguvgepshhmthhpohhuthdprhgtphhtthhopeguvghvvghlsehs phgvtghtrhhumhdqohhsrdhorhhgpdhrtghpthhtohephihukhgrseihuhhkrgdruggvvh X-ME-Proxy: Feedback-ID: i12284293:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Fri, 13 Jun 2025 10:05:22 -0400 (EDT) Received: by sf.qyliss.net (Postfix, from userid 1000) id B4B45245D66F7; Fri, 13 Jun 2025 16:05:20 +0200 (CEST) From: Alyssa Ross To: devel@spectrum-os.org Subject: [PATCH 0/8] Change serial getty instances dynamically Date: Fri, 13 Jun 2025 16:05:00 +0200 Message-ID: <20250613140508.76998-1-hi@alyssa.is> X-Mailer: git-send-email 2.49.0 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Message-ID-Hash: M3EKLFPXNHHC4LC7FVP4UURJQEGTVV2E X-Message-ID-Hash: M3EKLFPXNHHC4LC7FVP4UURJQEGTVV2E X-MailFrom: hi@alyssa.is X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-devel.spectrum-os.org-0; header-match-devel.spectrum-os.org-1; header-match-devel.spectrum-os.org-2; header-match-devel.spectrum-os.org-3; header-match-devel.spectrum-os.org-4; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: Yureka X-Mailman-Version: 3.3.9 Precedence: list List-Id: Patches and low-level development discussion Archived-At: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: The host system is supposed to provide a shell on whatever serial devices are configured as the active kernel consoles. Previously, the system made the assumption that the active console would never change after boot, but in reality devices can be added and removed later than that. One situation in which this happened is when a serial device was configured whose driver was not built in to the kernel, but loaded as a module after the console was checked by rc.init. This series fixes that by creating and destroying instances of the serial-getty service whenever the active kernel consoles change, and adds a regression test. Since this is the second test that involves running a full Spectrum system in a VM, most of the series has ended up being refactoring the first such test, so that code can be shared with this new one. Yureka, I don't know whether this is the issue you were encountering when you tried debugging the Weston issue over serial, but maybe worth a try? I suspect not though, because if I recall correctly you weren't even getting kernel logs? This was the only issue I could find trying to reproduce the problem in QEMU. Alyssa Ross (8): host/rootfs: poll active consoles for serial getty release/checks/integration: init from networking release/checks/integration: use default Meson timeout release/checks/integration: extract config struct release/checks/integration: run from tmpdir release/checks/integration: name QEMU arg pointers release/checks/integration: extract library release/checks/integration: test late serial host/rootfs/Makefile | 1 + host/rootfs/default.nix | 8 +- .../service/serial-getty-generator/run | 43 +++ host/rootfs/etc/s6-linux-init/scripts/rc.init | 9 - release/checks/default.nix | 4 +- release/checks/integration/default.nix | 88 +++++ release/checks/integration/late-serial.c | 15 + release/checks/integration/lib.c | 221 ++++++++++++ release/checks/integration/lib.h | 20 ++ release/checks/integration/meson.build | 21 ++ release/checks/integration/meson_options.txt | 6 + release/checks/integration/networking.c | 138 +++++++ release/checks/networking/default.nix | 62 ---- release/checks/networking/test.c | 337 ------------------ release/checks/pkg-tests.nix | 2 +- 15 files changed, 560 insertions(+), 415 deletions(-) create mode 100755 host/rootfs/etc/s6-linux-init/run-image/service/serial-getty-generator/run create mode 100644 release/checks/integration/default.nix create mode 100644 release/checks/integration/late-serial.c create mode 100644 release/checks/integration/lib.c create mode 100644 release/checks/integration/lib.h create mode 100644 release/checks/integration/meson.build create mode 100644 release/checks/integration/meson_options.txt create mode 100644 release/checks/integration/networking.c delete mode 100644 release/checks/networking/default.nix delete mode 100644 release/checks/networking/test.c base-commit: 42887a0331fd058ee0930fd5209fc3265565c3a8 -- 2.49.0