patches and low-level development discussion
 help / color / mirror / code / Atom feed
From: Alyssa Ross <hi@alyssa.is>
To: devel@spectrum-os.org
Cc: Demi Marie Obenour <demiobenour@gmail.com>
Subject: [PATCH] tools: mark start-vmm test as requiring KVM
Date: Mon, 14 Jul 2025 13:55:23 +0200	[thread overview]
Message-ID: <20250714115521.1707738-3-hi@alyssa.is> (raw)

This will tell Nix (on a correctly configured system) that if it
doesn't have KVM, it can't build the package, allowing it to fall back
to outsourcing it to a remote builder in that case.

Ideally, we don't want to have any part of the Spectrum build
requiring KVM, but until that's fixed, occurences should at least be
correctly marked.

Fixes: a4e3a40 ("host/start-vmm: actually run "run" test")
Signed-off-by: Alyssa Ross <hi@alyssa.is>
---
Demi, if you find other occurences of derivations requiring KVM to build,
please send a patch like this. :)

 tools/default.nix | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/tools/default.nix b/tools/default.nix
index 7a2926d..908ec0d 100644
--- a/tools/default.nix
+++ b/tools/default.nix
@@ -142,7 +142,9 @@ stdenv.mkDerivation (finalAttrs: {
       }
     );
 
-    run = runCommand "start-vmm-test" {} ''
+    run = runCommand "start-vmm-test" {
+      requiredSystemFeatures = [ "kvm" ];
+    } ''
       ${run-spectrum-vm.override {
         spectrum-host-tools = finalAttrs.finalPackage;
       }} > $out

base-commit: 9090caebe25310caa80a13787ef58b1f81658a78
-- 
2.49.0


                 reply	other threads:[~2025-07-14 11:56 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250714115521.1707738-3-hi@alyssa.is \
    --to=hi@alyssa.is \
    --cc=demiobenour@gmail.com \
    --cc=devel@spectrum-os.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://spectrum-os.org/git/crosvm
	https://spectrum-os.org/git/doc
	https://spectrum-os.org/git/mktuntap
	https://spectrum-os.org/git/nixpkgs
	https://spectrum-os.org/git/spectrum
	https://spectrum-os.org/git/ucspi-vsock
	https://spectrum-os.org/git/www

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).