From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from atuin.qyliss.net (localhost [IPv6:::1]) by atuin.qyliss.net (Postfix) with ESMTP id 770BB1F26A; Mon, 14 Jul 2025 11:56:22 +0000 (UTC) Received: by atuin.qyliss.net (Postfix, from userid 993) id 612381F313; Mon, 14 Jul 2025 11:56:21 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-26) on atuin.qyliss.net X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,DMARC_MISSING,RCVD_IN_DNSWL_LOW,SPF_HELO_PASS autolearn=unavailable autolearn_force=no version=4.0.1 Received: from fout-b4-smtp.messagingengine.com (fout-b4-smtp.messagingengine.com [202.12.124.147]) by atuin.qyliss.net (Postfix) with ESMTPS id 171321F312 for ; Mon, 14 Jul 2025 11:56:20 +0000 (UTC) Received: from phl-compute-05.internal (phl-compute-05.phl.internal [10.202.2.45]) by mailfout.stl.internal (Postfix) with ESMTP id AFCA21D0030B; Mon, 14 Jul 2025 07:56:18 -0400 (EDT) Received: from phl-mailfrontend-01 ([10.202.2.162]) by phl-compute-05.internal (MEProxy); Mon, 14 Jul 2025 07:56:18 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=alyssa.is; h=cc :cc:content-transfer-encoding:content-type:date:date:from:from :in-reply-to:message-id:mime-version:reply-to:subject:subject:to :to; s=fm1; t=1752494178; x=1752580578; bh=WJ0BEVb+P7EO27A4Z6UNX IypB/+2t68wfY2MTwKfD8M=; b=bwZNcyx9jVMZgHb9sKsxu5QOenRcNFJsJc34G DOElXFCsk06Sg++YTYW3vZpiyk0xNFRXNMqO8TUdBNXF0geFrU94bOFkQxMpYkpI I6YsO2IL0lQFRgNhWmnf01QKWVB8r/dPkTBw38tv1blQAkbdZG4L3bClQYi1jZmM dEyaTsZk6fQ4GxjJR8giKsmSViPr5i/4GEZBTpcL8gRcS0t+cgxtrnz2jQdVnHeu HJ3uzXVi79aFspJ0ZT234GN9iMEsKYnwezMgR9XBoyF/FftyKhe2Xc79utDvbz5o nX6gJLhnwM8rwXa8YCYLU7kc+uG+jODxBq6/MOTE4ZyEj+SCQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:date:date:feedback-id:feedback-id:from:from :in-reply-to:message-id:mime-version:reply-to:subject:subject:to :to:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm2; t= 1752494178; x=1752580578; bh=WJ0BEVb+P7EO27A4Z6UNXIypB/+2t68wfY2 MTwKfD8M=; b=HtZF1QGC/kUBk85/VZD22/Uii7ZYAr6yxJ0IMdi4R9cXckgU3ZQ sMh5iSXFgw2h4aJPQUbTqTuJiIkKjsXrfbMPyCRFdkEvL1/VbrCF67iQmEuMwFwY YJPX9nNWOp+AX+1dhVHYO/ZESTR6NNwFPCLtm+009+4kZ4WVJseZy0n+PXLC0nca uzXG+mr7J8zAhl5ptiNJ5tnTtCWXIs7CwY268AztgwYiord+LDqOlrexGuIzhE9y Uw1gJv/K54ROatzGA0VUeCEgQcvT5kIB7XOHjV1SIAccTt6X5XOwBI7ejhtMDoHf J1X5szNvp3ATtPxtE8ocRpaB/Ag98qO3NwQ== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeeffedrtdefgdehudeklecutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpuffrtefokffrpgfnqfghnecuuegr ihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenucfjug hrpefhvfevufffkffoggfgsedtkeertdertddtnecuhfhrohhmpeetlhihshhsrgcutfho shhsuceohhhisegrlhihshhsrgdrihhsqeenucggtffrrghtthgvrhhnpeejgfdtffdtte egffdtkeevhfffffffteegieevvddvveekhefhlefgvdeuffdvffenucffohhmrghinhep thhhihhsrdhtohholhhsnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrg hilhhfrhhomhephhhisegrlhihshhsrgdrihhspdhnsggprhgtphhtthhopedvpdhmohgu vgepshhmthhpohhuthdprhgtphhtthhopeguvghmihhosggvnhhouhhrsehgmhgrihhlrd gtohhmpdhrtghpthhtohepuggvvhgvlhesshhpvggtthhruhhmqdhoshdrohhrgh X-ME-Proxy: Feedback-ID: i12284293:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Mon, 14 Jul 2025 07:56:17 -0400 (EDT) Received: by sf.qyliss.net (Postfix, from userid 1000) id 4439729C92D8E; Mon, 14 Jul 2025 13:56:17 +0200 (CEST) From: Alyssa Ross To: devel@spectrum-os.org Subject: [PATCH] tools: mark start-vmm test as requiring KVM Date: Mon, 14 Jul 2025 13:55:23 +0200 Message-ID: <20250714115521.1707738-3-hi@alyssa.is> X-Mailer: git-send-email 2.49.0 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Message-ID-Hash: YVOYHPE5EGIQY27FMSAMXSOXONGZ3M3J X-Message-ID-Hash: YVOYHPE5EGIQY27FMSAMXSOXONGZ3M3J X-MailFrom: hi@alyssa.is X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-devel.spectrum-os.org-0; header-match-devel.spectrum-os.org-1; header-match-devel.spectrum-os.org-2; header-match-devel.spectrum-os.org-3; header-match-devel.spectrum-os.org-4; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: Demi Marie Obenour X-Mailman-Version: 3.3.9 Precedence: list List-Id: Patches and low-level development discussion Archived-At: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: This will tell Nix (on a correctly configured system) that if it doesn't have KVM, it can't build the package, allowing it to fall back to outsourcing it to a remote builder in that case. Ideally, we don't want to have any part of the Spectrum build requiring KVM, but until that's fixed, occurences should at least be correctly marked. Fixes: a4e3a40 ("host/start-vmm: actually run "run" test") Signed-off-by: Alyssa Ross --- Demi, if you find other occurences of derivations requiring KVM to build, please send a patch like this. :) tools/default.nix | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/tools/default.nix b/tools/default.nix index 7a2926d..908ec0d 100644 --- a/tools/default.nix +++ b/tools/default.nix @@ -142,7 +142,9 @@ stdenv.mkDerivation (finalAttrs: { } ); - run = runCommand "start-vmm-test" {} '' + run = runCommand "start-vmm-test" { + requiredSystemFeatures = [ "kvm" ]; + } '' ${run-spectrum-vm.override { spectrum-host-tools = finalAttrs.finalPackage; }} > $out base-commit: 9090caebe25310caa80a13787ef58b1f81658a78 -- 2.49.0