* [PATCH] tools: mark start-vmm test as requiring KVM
@ 2025-07-14 11:55 Alyssa Ross
0 siblings, 0 replies; only message in thread
From: Alyssa Ross @ 2025-07-14 11:55 UTC (permalink / raw)
To: devel; +Cc: Demi Marie Obenour
This will tell Nix (on a correctly configured system) that if it
doesn't have KVM, it can't build the package, allowing it to fall back
to outsourcing it to a remote builder in that case.
Ideally, we don't want to have any part of the Spectrum build
requiring KVM, but until that's fixed, occurences should at least be
correctly marked.
Fixes: a4e3a40 ("host/start-vmm: actually run "run" test")
Signed-off-by: Alyssa Ross <hi@alyssa.is>
---
Demi, if you find other occurences of derivations requiring KVM to build,
please send a patch like this. :)
tools/default.nix | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/tools/default.nix b/tools/default.nix
index 7a2926d..908ec0d 100644
--- a/tools/default.nix
+++ b/tools/default.nix
@@ -142,7 +142,9 @@ stdenv.mkDerivation (finalAttrs: {
}
);
- run = runCommand "start-vmm-test" {} ''
+ run = runCommand "start-vmm-test" {
+ requiredSystemFeatures = [ "kvm" ];
+ } ''
${run-spectrum-vm.override {
spectrum-host-tools = finalAttrs.finalPackage;
}} > $out
base-commit: 9090caebe25310caa80a13787ef58b1f81658a78
--
2.49.0
^ permalink raw reply related [flat|nested] only message in thread
only message in thread, other threads:[~2025-07-14 11:56 UTC | newest]
Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-07-14 11:55 [PATCH] tools: mark start-vmm test as requiring KVM Alyssa Ross
Code repositories for project(s) associated with this public inbox
https://spectrum-os.org/git/crosvm
https://spectrum-os.org/git/doc
https://spectrum-os.org/git/mktuntap
https://spectrum-os.org/git/nixpkgs
https://spectrum-os.org/git/spectrum
https://spectrum-os.org/git/ucspi-vsock
https://spectrum-os.org/git/www
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).