From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from atuin.qyliss.net (localhost [IPv6:::1]) by atuin.qyliss.net (Postfix) with ESMTP id E77A04D03; Thu, 04 Sep 2025 23:47:48 +0000 (UTC) Received: by atuin.qyliss.net (Postfix, from userid 993) id 8251C4C51; Thu, 04 Sep 2025 23:47:44 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-26) on atuin.qyliss.net X-Spam-Level: X-Spam-Status: No, score=-0.1 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,DMARC_PASS,FREEMAIL_FROM,RCVD_IN_DNSWL_NONE, SPF_HELO_NONE autolearn=unavailable autolearn_force=no version=4.0.1 Received: from mail-yb1-xb29.google.com (mail-yb1-xb29.google.com [IPv6:2607:f8b0:4864:20::b29]) by atuin.qyliss.net (Postfix) with ESMTPS id 759B14BDC for ; Thu, 04 Sep 2025 23:47:43 +0000 (UTC) Received: by mail-yb1-xb29.google.com with SMTP id 3f1490d57ef6-e96ff518c08so1644192276.1 for ; Thu, 04 Sep 2025 16:47:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1757029662; x=1757634462; darn=spectrum-os.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=w5FFFxtv2wmVvbqdeWmh8Opo4Wfbg7LH+IFMUtSa3cA=; b=QTX8VB/jJLx0n3LdPtd//AqiUTwTGZV6I232k+A/xerujK5sRk7RnD7V2e6MERcLgu dwLrHKacXLnt8Z9iumeXWkF+C9VdKvOicPZ6SwI9j297ddto+SxAC2muTzGS4eS9kiPP pwtVI6Kjp+iFkV7SCY8LsAVqyyH1GfENNWGmBnMIESlaJN5WLxY0YjHs/YhmyyepfMSm l+mnfOUwxKlsERONJmacOgeKNqjjA1TzRFLErs5u066XQ4RSeVBHJ6MWaM2ybdwNmeBs 7Ew29AuL2gKQB+QkEcWdW7zQg5Yn/XV3ogqUo9KdqDGCSHBvXg4zac1DAmaSSfeIenhX aHTw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1757029662; x=1757634462; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=w5FFFxtv2wmVvbqdeWmh8Opo4Wfbg7LH+IFMUtSa3cA=; b=OzsX76NTiqShgW64RHVfr8JZJD0xlqajfy2gifDXIDGEb84SYwOyisQgEjihlaHIp0 UjTQpV/y4qjFe6rTC3jd4Ah5gY0iB3QqqbX6PFiukUg8v36/c7X57BlyHvkuUddDIKHN CDrX2eAHHQkhN9M+jYxshfFdN9iqc3YEphnCs637Q1mDYUkTb9X0Xuv9hAyq4k+u0V0w 3XeCzh34jc7bMdxo87DB4D8BB/0EoIedWolqomYTYkNFAP3y/DmDKaY5X87STUVcLDM7 QVzIUyZJEOyDo1hmVflEQS3r7TfKVg885foMrMAt/Q9zwUFrM6+Uhby9/8xHm5VFBA6I 10aw== X-Gm-Message-State: AOJu0Yx1UBGK5yal8sNJOxSau4/zuXxb0fRI0zwZNAZULULnVUpfpCHo zFr+4kvi3M/Iucx9nUauR29c+8WUK1T5IQbc1k0L26sUOirTFzMuSwvyR8aGxpfn X-Gm-Gg: ASbGncv+j9mh8zZSHJmmCjR8bWZuTp5xFoxFMf0kZ1C43ZC022losB0UQByQVDoojo7 Wj/ykK6zySgtQQuH1xMf16r4/t1V101FxiVn3OA4Q6oS54EH0CKgZ6f10DDf7e9qs9K0Npgp/jt Ya5oZGBBSKp6t2nFxaUXrgthypgfnO55y3ri7NqD0p0peEYH1A56tt3VTMMCOR5AYY1PFB2N54H zFjiiB/4sWBRzCXcno3FIF14UNcL1Aww0WKHXr5M8dhY8DZu8GnwBjxGeXIlYo/Ab6HHqmP586P E2TnbggZGGbsmGadeH6A/a/Mjc4uKkcaxrEO0J+rJwOsOcHwnZEdBbMyuND1L4H7PklMurjf30Z Ag65byX6Cv0ngH4ZrPWBAke15fBgMqC5aizsB3+EGGZ5Ir6BtxssSfyAHUxOZG33DqwmMMFKtcy piXT6AmBdw2uKrT+6U0zgz+db5S35J5UdQe+5TuYHCVRk= X-Google-Smtp-Source: AGHT+IGcdVXJPE6H8WU1VmK8WG/HErA3qafOTVc3TkIT5lXArQtZ4YvXTxCqsLRNQepxKPSoIcjtbw== X-Received: by 2002:a05:690e:430f:b0:5f3:315d:79ae with SMTP id 956f58d0204a3-601756ad2c9mr3481982d50.3.1757029662093; Thu, 04 Sep 2025 16:47:42 -0700 (PDT) Received: from localhost.localdomain (h96-60-249-169.cncrtn.broadband.dynamic.tds.net. [96.60.249.169]) by smtp.gmail.com with UTF8SMTPSA id 00721157ae682-723a85a0cd9sm25477217b3.69.2025.09.04.16.47.41 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 04 Sep 2025 16:47:41 -0700 (PDT) From: Demi Marie Obenour Date: Thu, 04 Sep 2025 17:26:23 -0400 Subject: [PATCH 01/20] scripts/make-erofs.sh: Ensure that / is world-readable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Message-Id: <20250904-systemd-v1-1-2a63b790a913@gmail.com> References: <20250904-systemd-v1-0-2a63b790a913@gmail.com> In-Reply-To: <20250904-systemd-v1-0-2a63b790a913@gmail.com> To: Spectrum OS Development X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=ed25519-sha256; t=1757021182; l=1433; i=demiobenour@gmail.com; s=20250729; h=from:subject:message-id; bh=54TnOsKJxSrgZa3Idu+k5Bi6P3h83pAvzG2vTQ5OZNE=; b=+1PpLO4nlPajf3/xXUDiTJ2408Va98v1bcAftWLYlBOE6IsG+lQH51ycBO0wTiwQrBpOjZ+1q 9kBrQlaHynzBr7EXfB6L52H5x9GRtZW1+v9K5Xv+G0HorCet0Rz2+t5 X-Developer-Key: i=demiobenour@gmail.com; a=ed25519; pk=X57Q4/YQDj9t4SBeKaDwvXYKB6quZJVx/DE2Ly2out0= Message-ID-Hash: XOMCWYFTEVIHUHRBBHWXXJISGDDWKMK5 X-Message-ID-Hash: XOMCWYFTEVIHUHRBBHWXXJISGDDWKMK5 X-MailFrom: demiobenour@gmail.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-devel.spectrum-os.org-0; header-match-devel.spectrum-os.org-1; header-match-devel.spectrum-os.org-2; header-match-devel.spectrum-os.org-3; header-match-devel.spectrum-os.org-4; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: Demi Marie Obenour , Alyssa Ross X-Mailman-Version: 3.3.9 Precedence: list List-Id: Patches and low-level development discussion Archived-At: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: Previously it had 0700 permissions, which was hidden because everything ran as root anyway. However, dbus-broker fails to start in this case because it always drops privileges. Also set umask to 0022 to ensure that the permissions of other directories are correct. Signed-off-by: Demi Marie Obenour --- scripts/make-erofs.sh | 9 +++++++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/scripts/make-erofs.sh b/scripts/make-erofs.sh index b47048ad747bd7dfcc28e0f1dfd75ec090fa7e09..88e3885e578a6fd85a61c6f2993a9addb7f44c37 100755 --- a/scripts/make-erofs.sh +++ b/scripts/make-erofs.sh @@ -8,6 +8,7 @@ # single directory structure, and could generate an EROFS image # based on source:dest mappings directly. +umask 0022 # for permissions ex_usage() { echo "Usage: make-erofs.sh [options]... img < srcdest.txt" >&2 exit 1 @@ -18,8 +19,12 @@ if [ -z "${img-}" ]; then ex_usage fi -root="$(mktemp -d -- "$img.tmp.XXXXXXXXXX")" -trap 'chmod -R +w -- "$root" && rm -rf -- "$root"' EXIT +superroot="$(mktemp -d -- "$img.tmp.XXXXXXXXXX")" +trap 'chmod -R +w -- "$root" && rm -rf -- "$superroot"' EXIT +# $superroot has 0700 permissions, so create a subdirectory +# with correct (0755) permissions and do all work there. +root=$superroot/real_root +mkdir -- "$root" while read -r arg1; do read -r arg2 || ex_usage -- 2.51.0