From: Demi Marie Obenour <demiobenour@gmail.com>
To: Spectrum OS Development <devel@spectrum-os.org>
Cc: Demi Marie Obenour <demiobenour@gmail.com>, Alyssa Ross <hi@alyssa.is>
Subject: [PATCH 13/20] host/rootfs: pass API socket as fd 3, not fd 0
Date: Thu, 04 Sep 2025 17:26:35 -0400 [thread overview]
Message-ID: <20250904-systemd-v1-13-2a63b790a913@gmail.com> (raw)
In-Reply-To: <20250904-systemd-v1-0-2a63b790a913@gmail.com>
Cloud Hypervisor might close this, and closing stdin is a bad idea.
Signed-off-by: Demi Marie Obenour <demiobenour@gmail.com>
---
host/rootfs/usr/bin/run-vmm | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/host/rootfs/usr/bin/run-vmm b/host/rootfs/usr/bin/run-vmm
index 14e2452f6648fd190a85d03e5cc4ce3fb54ec04f..bcb6cdaf6646da6bb4970fe97f5ef03badbd66a6 100755
--- a/host/rootfs/usr/bin/run-vmm
+++ b/host/rootfs/usr/bin/run-vmm
@@ -50,6 +50,7 @@ background -d {
id=router-${client_id},tap=router-${client_id},mac=${mac}
}
unexport !
-fdclose 3
+fdmove -c 3 0
+redirfd -r 0 /dev/null
-cloud-hypervisor --api-socket fd=0
+cloud-hypervisor --api-socket fd=3
--
2.51.0
next prev parent reply other threads:[~2025-09-04 23:48 UTC|newest]
Thread overview: 66+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-09-04 21:26 [PATCH 00/20] Many image fixes and systemd integration Demi Marie Obenour
2025-09-04 21:26 ` [PATCH 01/20] scripts/make-erofs.sh: Ensure that / is world-readable Demi Marie Obenour
2025-09-08 8:21 ` Alyssa Ross
2025-09-04 21:26 ` [PATCH 02/20] scripts/make-erofs.sh: Do not read one byte at a time Demi Marie Obenour
2025-09-08 8:23 ` Alyssa Ross
2025-09-08 16:57 ` Demi Marie Obenour
2025-09-09 15:19 ` Alyssa Ross
2025-09-04 21:26 ` [PATCH 03/20] scripts/make-erofs.sh: Avoid unneeded calls to awk and chmod Demi Marie Obenour
2025-09-08 8:28 ` Alyssa Ross
2025-09-08 17:14 ` Demi Marie Obenour
2025-09-10 18:45 ` Alyssa Ross
2025-09-04 21:26 ` [PATCH 04/20] scripts/make-erofs.sh: Validate all paths Demi Marie Obenour
2025-09-08 8:36 ` Alyssa Ross
2025-09-08 18:21 ` Demi Marie Obenour
2025-09-10 18:54 ` Alyssa Ross
2025-09-21 12:09 ` Alyssa Ross
2025-09-04 21:26 ` [PATCH 05/20] scripts/make-erofs.sh: Avoid unneeded calls to dirname Demi Marie Obenour
2025-09-10 20:04 ` Alyssa Ross
2025-09-10 20:06 ` Demi Marie Obenour
2025-09-19 16:47 ` Alyssa Ross
2025-09-19 19:04 ` Demi Marie Obenour
2025-09-04 21:26 ` [PATCH 06/20] scripts/make-erofs.sh: Avoid unneeded calls to mkdir Demi Marie Obenour
2025-09-08 8:39 ` Alyssa Ross
2025-09-04 21:26 ` [PATCH 07/20] scripts/make-erofs.sh: Standardize file modes in images Demi Marie Obenour
2025-09-08 8:46 ` Alyssa Ross
2025-09-08 17:16 ` Demi Marie Obenour
2025-09-19 17:50 ` Alyssa Ross
2025-09-19 19:18 ` Demi Marie Obenour
2025-09-21 12:23 ` Alyssa Ross
2025-09-04 21:26 ` [PATCH 08/20] Standardize directories and symlinks " Demi Marie Obenour
2025-09-08 8:59 ` Alyssa Ross
2025-09-08 18:05 ` Demi Marie Obenour
2025-09-19 17:53 ` Alyssa Ross
2025-09-04 21:26 ` [PATCH 09/20] Add os-release file Demi Marie Obenour
2025-09-08 9:12 ` Alyssa Ross
2025-09-08 18:07 ` Demi Marie Obenour
2025-09-04 21:26 ` [PATCH 10/20] host/rootfs: Set -eu in build Demi Marie Obenour
2025-09-08 9:13 ` Alyssa Ross
2025-09-08 18:08 ` Demi Marie Obenour
2025-09-04 21:26 ` [PATCH 11/20] Add /dev/fd and /dev/std* Demi Marie Obenour
2025-09-08 9:18 ` Alyssa Ross
2025-09-08 18:12 ` Demi Marie Obenour
2025-09-04 21:26 ` [PATCH 12/20] host/rootfs: Do not read from /dev/tty1 Demi Marie Obenour
2025-09-08 9:19 ` Alyssa Ross
2025-09-08 18:18 ` Demi Marie Obenour
2025-09-19 18:22 ` Alyssa Ross
2025-09-19 19:00 ` Demi Marie Obenour
2025-09-21 9:01 ` Alyssa Ross
2025-09-04 21:26 ` Demi Marie Obenour [this message]
2025-09-08 9:44 ` [PATCH 13/20] host/rootfs: pass API socket as fd 3, not fd 0 Alyssa Ross
2025-09-04 21:26 ` [PATCH 14/20] host/rootfs: Disable unneeded BusyBox tools Demi Marie Obenour
2025-09-08 9:24 ` Alyssa Ross
2025-09-04 21:26 ` [PATCH 15/20] host/rootfs: Use real less, not BusyBox less Demi Marie Obenour
2025-09-08 9:25 ` Alyssa Ross
2025-09-08 18:16 ` Demi Marie Obenour
2025-09-19 18:45 ` Alyssa Ross
2025-09-19 19:01 ` Demi Marie Obenour
2025-09-21 9:02 ` Alyssa Ross
2025-09-04 21:26 ` [PATCH 16/20] host/rootfs: explicitly set PATH in network add script Demi Marie Obenour
2025-09-04 21:26 ` [PATCH 17/20] Use /etc/s6-rc/compiled for compiled s6-rc directory Demi Marie Obenour
2025-09-08 9:27 ` Alyssa Ross
2025-09-08 18:15 ` Demi Marie Obenour
2025-09-04 21:26 ` [PATCH 18/20] host/rootfs: virtiofsd: Do not use FD 0 as the socket Demi Marie Obenour
2025-09-08 9:44 ` Alyssa Ross
2025-09-04 21:26 ` [PATCH 19/20] host/rootfs: Disable unneeded busybox stuff Demi Marie Obenour
2025-09-04 21:26 ` [PATCH 20/20] host/rootfs: Switch to systemd Demi Marie Obenour
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250904-systemd-v1-13-2a63b790a913@gmail.com \
--to=demiobenour@gmail.com \
--cc=devel@spectrum-os.org \
--cc=hi@alyssa.is \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://spectrum-os.org/git/crosvm
https://spectrum-os.org/git/doc
https://spectrum-os.org/git/mktuntap
https://spectrum-os.org/git/nixpkgs
https://spectrum-os.org/git/spectrum
https://spectrum-os.org/git/ucspi-vsock
https://spectrum-os.org/git/www
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).