From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from atuin.qyliss.net (localhost [IPv6:::1]) by atuin.qyliss.net (Postfix) with ESMTP id E4EDA50D5; Thu, 04 Sep 2025 23:48:23 +0000 (UTC) Received: by atuin.qyliss.net (Postfix, from userid 993) id EF4224F65; Thu, 04 Sep 2025 23:48:09 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-26) on atuin.qyliss.net X-Spam-Level: X-Spam-Status: No, score=-0.1 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,DMARC_PASS,FREEMAIL_FROM,RCVD_IN_DNSWL_NONE, SPF_HELO_NONE autolearn=unavailable autolearn_force=no version=4.0.1 Received: from mail-yb1-xb35.google.com (mail-yb1-xb35.google.com [IPv6:2607:f8b0:4864:20::b35]) by atuin.qyliss.net (Postfix) with ESMTPS id 52EC94DF9 for ; Thu, 04 Sep 2025 23:48:03 +0000 (UTC) Received: by mail-yb1-xb35.google.com with SMTP id 3f1490d57ef6-e9d6cb1df67so1383721276.1 for ; Thu, 04 Sep 2025 16:48:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1757029682; x=1757634482; darn=spectrum-os.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=i3ycx1/i6JkEzU1hP9Iy6/CDEDD99d9YQhSqSU8hjwc=; b=J/qMqCjsg5PZQRYBFFp4wSqT3ukNdKQt9P4GPjzqawPInkdEyi8x4sGWG38Xqo5R85 F680kkXssE5oiQb3RbdcJheNUJMu4T7TKtW2XPj45KWC+j3cFzVUll+Xzxc7e73KMfbN oB1kFTtF/MBzxuZjHiMJaYL8Q8QEi6kcUrLzznkt2+hbs0Z/33UgqdyX0WmYF0x4rPv5 G219pzoZmILpew0qqn/P4fp7wHcNFtfKZNN/4O0qkWkavY+Uvne85SD6z0kAjTGTaurW j5Sq9HUnzyttj1+Rr7rWDN6jqYl3Id0aRTVUF9/hZgtDdlzEe4CQQBpaUjAnpYFyKobH aYJw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1757029682; x=1757634482; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=i3ycx1/i6JkEzU1hP9Iy6/CDEDD99d9YQhSqSU8hjwc=; b=WLSfUdI0Ng4BlxuD5kqfidL3oTz81WhVGHvFdGIAHw46VyZQDnG85n+t/Qlg1EHtkh 5S0XMlQx1/sWhMPqQF3m+UNNDsguJXiXJpqDMqih4bBpdg0bEjOoiMn4JJdWp0CVVTHU SsisBOCRtOWPUdu1KmmUphLZs+uu+9M3dHkc/DuyRYDbRUM9cPRGScQ4rpkLMPpYd5A8 Ef4xSzgkslGvKKk7BFMfOaJdrIMVTUw/X2WUUoKrxtZ/xLn/fshK1Kvo3loaIudgH31U hO6bL/iGhzifhynKlUfBNd+4K7jUjC6Z+BxkqtXTf17bsADWnqsvrMYGsKbG3jtQ6P59 1R0g== X-Gm-Message-State: AOJu0YyoKfhqbicdJAf1/kwR6V9u0knZUHNt3yL+dQ/vWlxAPkv41V/C UCugh/z0NH6Wp+TokjU9SXmUEoeQ0HLCTnb+r075u7CFPaJ1yyW1Hqj3i2aMiibU X-Gm-Gg: ASbGnctCmOmgZakiK7XmhP5hVmIIfdhTIXHKqIzjKwJ+kUkuJTwrPSKgTyCc1aMaRJf kLzBPEez11NvbMk4fDxrzSfdd671BLv47iGYJ27yYzrHxjp+Q2AFjLFZCxl+m9Gc9RxWi61A8Je W9fonVGpLgi1FtqSZNZoq83MjePo2PNhQBlTg1J/k67tg4uGtwICd40APLJTy/w6E1mAvDR9jVb M27frPZ9MeiBF3TXJ8W/m0mYC6YCzcU1W8wXdUdQEPpGn8YhA10YY5qnfqt/mdxxlYWBMzbRCWR 0i+OKPJA6EysHe6lzf159Z1Pii5hq31sQmCuOCoENoTOZnpv98fD1SeLtbXMSkHIt6gN8spJo/X m/FNPbnSuEw3oqKU2JFO5YfQSNptNrCBeKLiHcTCsIq0EXq4iFjFhutiEDL1R7DFD/A0O+E6+7T vhSvTW8J2V4GR29q2bQB5UXNzaaU4p+n2H0MI16Jm8S8rdFUtUM59Rew== X-Google-Smtp-Source: AGHT+IEsphDbcC4EbeiLPEnmxl4ctlo/ER7ef9S2S5opDn6CNt6BbpRcScEgH43SoMbrAX74AjNmkQ== X-Received: by 2002:a05:690c:7203:b0:721:6b2e:a07a with SMTP id 00721157ae682-72276580c26mr231737897b3.51.1757029681853; Thu, 04 Sep 2025 16:48:01 -0700 (PDT) Received: from localhost.localdomain (h96-60-249-169.cncrtn.broadband.dynamic.tds.net. [96.60.249.169]) by smtp.gmail.com with UTF8SMTPSA id 00721157ae682-723a82d964dsm25518377b3.1.2025.09.04.16.48.01 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 04 Sep 2025 16:48:01 -0700 (PDT) From: Demi Marie Obenour Date: Thu, 04 Sep 2025 17:26:40 -0400 Subject: [PATCH 18/20] host/rootfs: virtiofsd: Do not use FD 0 as the socket MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Message-Id: <20250904-systemd-v1-18-2a63b790a913@gmail.com> References: <20250904-systemd-v1-0-2a63b790a913@gmail.com> In-Reply-To: <20250904-systemd-v1-0-2a63b790a913@gmail.com> To: Spectrum OS Development X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=ed25519-sha256; t=1757021182; l=1139; i=demiobenour@gmail.com; s=20250729; h=from:subject:message-id; bh=HPI8zGPxAnVUV18nJ46hnC91BY5CLRLexgm5T/8hcH0=; b=MyNC5S5P+Hq6ySqt39oOmKx9c2Od1k/QwSdNjTk+7OU/ZjFl21dXHOeZlTMUyMtC0bvE+BWmQ WWm7UhE2zvyATAtrE0g6/qkaEnjRn79MX64rJHwhUN5a1+gSW+Sc3zd X-Developer-Key: i=demiobenour@gmail.com; a=ed25519; pk=X57Q4/YQDj9t4SBeKaDwvXYKB6quZJVx/DE2Ly2out0= Message-ID-Hash: 4G3WO3YOKCP5BGCSTTXSEMSDFFP7WQHB X-Message-ID-Hash: 4G3WO3YOKCP5BGCSTTXSEMSDFFP7WQHB X-MailFrom: demiobenour@gmail.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-devel.spectrum-os.org-0; header-match-devel.spectrum-os.org-1; header-match-devel.spectrum-os.org-2; header-match-devel.spectrum-os.org-3; header-match-devel.spectrum-os.org-4; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: Demi Marie Obenour , Alyssa Ross X-Mailman-Version: 3.3.9 Precedence: list List-Id: Patches and low-level development discussion Archived-At: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: virtiofsd might close it, and closing stdin is a bad idea. Signed-off-by: Demi Marie Obenour --- .../etc/s6-linux-init/run-image/service/vhost-user-fs/template/run | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/host/rootfs/etc/s6-linux-init/run-image/service/vhost-user-fs/template/run b/host/rootfs/etc/s6-linux-init/run-image/service/vhost-user-fs/template/run index 17e604ec41299934ae5eabbdea3d9cad3e63d1e1..70b06acb5193942c58d5011bfd9aa5a3bdd98ec0 100755 --- a/host/rootfs/etc/s6-linux-init/run-image/service/vhost-user-fs/template/run +++ b/host/rootfs/etc/s6-linux-init/run-image/service/vhost-user-fs/template/run @@ -5,7 +5,8 @@ s6-ipcserver-socketbinder -a 0700 -B env/virtiofsd.sock if { fdmove 1 3 echo } -fdclose 3 +fdmove -c 3 0 +redirfd -r 0 /dev/null export TMPDIR /run @@ -14,4 +15,4 @@ export TMPDIR /run unshare -m --propagation slave if { mount --rbind -o ro /run/vm/by-id/${1}/fs /run/vm/by-id/${1}/fs } -virtiofsd --fd 0 --shared-dir /run/vm/by-id/${1}/fs +virtiofsd --fd 3 --shared-dir /run/vm/by-id/${1}/fs -- 2.51.0