From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from atuin.qyliss.net (localhost [IPv6:::1]) by atuin.qyliss.net (Postfix) with ESMTP id EC9FC1EE93; Tue, 09 Sep 2025 03:37:47 +0000 (UTC) Received: by atuin.qyliss.net (Postfix, from userid 993) id 55AE21ED73; Tue, 09 Sep 2025 03:37:45 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-26) on atuin.qyliss.net X-Spam-Level: X-Spam-Status: No, score=-0.1 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,DMARC_PASS,FREEMAIL_FROM,SPF_HELO_NONE autolearn=unavailable autolearn_force=no version=4.0.1 Received: from mail-yx1-xb12f.google.com (mail-yx1-xb12f.google.com [IPv6:2607:f8b0:4864:20::b12f]) by atuin.qyliss.net (Postfix) with ESMTPS id B88B61ED70 for ; Tue, 09 Sep 2025 03:37:43 +0000 (UTC) Received: by mail-yx1-xb12f.google.com with SMTP id 956f58d0204a3-60f47bcdc52so1726455d50.2 for ; Mon, 08 Sep 2025 20:37:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1757389061; x=1757993861; darn=spectrum-os.org; h=cc:to:message-id:content-transfer-encoding:mime-version:subject :date:from:from:to:cc:subject:date:message-id:reply-to; bh=hKNuseqOx2njNmn57aPSBA9yW/3EshPvoav9jGZ1yaQ=; b=gltjoS1zvsHdUg2UwGQKcrkZV37KljWVu1DcgVDsFWKOZU83OfgGhFRQ30/AQ0Xyvl BeTOIcrFzqv/4KigdTOdyYr8uCLhdoQ+Xsc+vpyzHipb3+qSVNEEtfvOc2ey5DU/AaIx Kk9+TpVcu9HrrHi8gIqD4S3fIkIeolYQaj3E77cmih2xaOTyENG0Fpv+mJcWEtyauxgw diM8/Pt90XJopFxTAvX4pFDB/cSnW7naV1je/0ku26DdmeEV6TPfNG+ooDoAoKd45khK Lq8MCzvIKU790DbpSI1FSx0v2sB6Yec2aqPeMLno2/jjO5GbwCIRaGAN/UN/PYbZ6ysy 6Csg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1757389061; x=1757993861; h=cc:to:message-id:content-transfer-encoding:mime-version:subject :date:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=hKNuseqOx2njNmn57aPSBA9yW/3EshPvoav9jGZ1yaQ=; b=OYOvTzjvEFhotV0+2UotHYDBNFuPZtsKGXed1STpBrJTFiBxNcRTfGtBxaHwjA9SFR yHEtSVZZPtJN2+A2gi14Sqe0r5crBholynz8vQmcUFf2dzvAya1vqGDopods4XAicQCz WpgHF53IdBbzUwaX+hYAYYVTqErT/c45nJS7taHn6dir0iAOPveurcjZmhrmIkrdKNhF 4klwQc+Vd5dSJo37cqRhbVbAt1S5AZvTTj1mt0fxjyN415Yfhq5d/GfSYuvr4KSnxctL Je0+4NqNnKYcpWkpqzbklk6w+5udA9D3W3KOxL53LPNWbuUzf7LjpJBE5pKNvbNttU8x L/Pw== X-Gm-Message-State: AOJu0YzUZPvwauLmQsNy3FUS+ygFUB8oc/b5UGOI3ocwMhEXhiStFzgm VEIZ2vb9N6UwM7cwLTs8Hc2kf46z7+Bwwn/3iA5qrDrKUtzeDyRj/SX8Bpt74g== X-Gm-Gg: ASbGncu01S5i3ob1unLGvz/SmRbg3RhC2fD0LQwaGMo8Q1heNxaAIPHCL072+OzZDnK A0qQbTW7zV3sOFnuN5OVTLFhT/QvY+p541Xobo1QBAw3iLZSukFW5WQD8ddUJg6c+tJjVOJ1Ar9 i9G0rU2l6puMhlJQU4YaF+DXDNyEUoOH4BIGZwVe8KqJjMj/zUXzJD8VRDqQjpj9gS+hkcAoORc fQcxBDaSRKuXgDW4sDYHVuhtkIY/KwaSxj5RgLBW+dz5CN0+o6GasrrMdeFU5adAz/lXIKIOtCz wa50cnvMZFHTNIYsaEearotZSGVSdcgvjnyyGKFiZ3owuh6WeB79kafVjBNCSQca+4F0GOnsTlc 8Q5BeYiup7OLfvEzyPzQ7kraEOLLH84hg4ln6KXa2qQgpapQUeaHGYkT/faNrTJSYayuBBt2z86 ObzHxsEa15lgjFBbTXSJHXRrTDCAdZXZ2hnyjD/DNktJ7TxhVMYhH8GQ== X-Google-Smtp-Source: AGHT+IGRARWh0pJmeswd6Q2djqjQDSglqSh/HML7LkXA9irmDRS0+C/DOe8PV/w3SgiW8WyIV2P30w== X-Received: by 2002:a05:690e:42c6:b0:5fb:e4f2:ed24 with SMTP id 956f58d0204a3-6102d270b44mr6590089d50.6.1757389061018; Mon, 08 Sep 2025 20:37:41 -0700 (PDT) Received: from localhost.localdomain (h96-60-249-169.cncrtn.broadband.dynamic.tds.net. [96.60.249.169]) by smtp.gmail.com with UTF8SMTPSA id 00721157ae682-723a831fcc6sm58122097b3.16.2025.09.08.20.37.40 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 08 Sep 2025 20:37:40 -0700 (PDT) From: Demi Marie Obenour Date: Mon, 08 Sep 2025 23:35:54 -0400 Subject: [PATCH] scripts/make-erofs.sh: Ensure that / is world-readable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Message-Id: <20250908-world-readable-root-v1-1-597c761ba2a0@gmail.com> X-B4-Tracking: v=1; b=H4sIAJmgv2gC/x3MSQqAMAxA0atI1gbqPFxFXNQ2akCspKJC8e4Wl 2/xfwBPwuShTwIIXezZ7RFZmoBZ9b4Qso2GXOWV6lSLt5PNopC2etoIxbkT2yZrat2VtjAGYnk Izfz812F83w/zeZO+ZQAAAA== X-Change-ID: 20250908-world-readable-root-87176a94d3cc To: Spectrum OS Development X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=ed25519-sha256; t=1757388953; l=1880; i=demiobenour@gmail.com; s=20250729; h=from:subject:message-id; bh=kpAgfwkk8obrd7cbRJ1eZSKQQIC6fERBnXVJ1x+OpFs=; b=aR8f1evTNIeF1IOiapK7ynJ2z2Qwbwepe2pXDkVCt0Ah0RuWq7j95aXOAhxHSZNjjzFyC1qqU FGzi3vaPH7QCK6lT/Tmsld0BWF+xzveHiV9Q5mcX45Y84s/Q1EVgpl+ X-Developer-Key: i=demiobenour@gmail.com; a=ed25519; pk=X57Q4/YQDj9t4SBeKaDwvXYKB6quZJVx/DE2Ly2out0= Message-ID-Hash: NJLXE35T46CEIYIJKHULKDKAZOJIPO3K X-Message-ID-Hash: NJLXE35T46CEIYIJKHULKDKAZOJIPO3K X-MailFrom: demiobenour@gmail.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-devel.spectrum-os.org-0; header-match-devel.spectrum-os.org-1; header-match-devel.spectrum-os.org-2; header-match-devel.spectrum-os.org-3; header-match-devel.spectrum-os.org-4; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: Alyssa Ross , Demi Marie Obenour X-Mailman-Version: 3.3.9 Precedence: list List-Id: Patches and low-level development discussion Archived-At: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: Previously it had 0700 permissions, which was hidden because everything ran as root anyway. However, dbus-broker fails to start in this case because it always drops privileges. Also set umask to 0022 to ensure that the permissions of other directories are correct. Signed-off-by: Demi Marie Obenour --- scripts/make-erofs.sh | 10 ++++++++-- 1 file changed, 8 insertions(+), 2 deletions(-) diff --git a/scripts/make-erofs.sh b/scripts/make-erofs.sh index b47048ad747bd7dfcc28e0f1dfd75ec090fa7e09..5b620be77f2967e45fa1c2b06c6acfc3329e46c0 100755 --- a/scripts/make-erofs.sh +++ b/scripts/make-erofs.sh @@ -1,6 +1,7 @@ #!/bin/sh -eu # # SPDX-FileCopyrightText: 2023-2024 Alyssa Ross +# SPDX-FileCopyrightText: 2025 Demi Marie Obenour # SPDX-License-Identifier: EUPL-1.2+ # # FIXME: It would be nice to replace this script with a program that @@ -8,6 +9,7 @@ # single directory structure, and could generate an EROFS image # based on source:dest mappings directly. +umask 0022 # for permissions ex_usage() { echo "Usage: make-erofs.sh [options]... img < srcdest.txt" >&2 exit 1 @@ -18,8 +20,12 @@ if [ -z "${img-}" ]; then ex_usage fi -root="$(mktemp -d -- "$img.tmp.XXXXXXXXXX")" -trap 'chmod -R +w -- "$root" && rm -rf -- "$root"' EXIT +superroot="$(mktemp -d -- "$img.tmp.XXXXXXXXXX")" +trap 'chmod -R +w -- "$root" && rm -rf -- "$superroot"' EXIT +# $superroot has 0700 permissions, so create a subdirectory +# with correct (0755) permissions and do all work there. +root=$superroot/real_root +mkdir -- "$root" while read -r arg1; do read -r arg2 || ex_usage --- base-commit: 8ce6039b6dde7fda98ceea018addecb8bee0e7b3 change-id: 20250908-world-readable-root-87176a94d3cc -- Sincerely, Demi Marie Obenour (she/her/hers)