From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from atuin.qyliss.net (localhost [IPv6:::1]) by atuin.qyliss.net (Postfix) with ESMTP id 0E06CE523; Thu, 11 Sep 2025 12:51:14 +0000 (UTC) Received: by atuin.qyliss.net (Postfix, from userid 993) id 74BAFE4DE; Thu, 11 Sep 2025 12:51:11 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-26) on atuin.qyliss.net X-Spam-Level: X-Spam-Status: No, score=-0.1 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,DMARC_PASS,FREEMAIL_FROM,RCVD_IN_DNSWL_NONE, SPF_HELO_NONE autolearn=unavailable autolearn_force=no version=4.0.1 Received: from mail-yb1-xb2c.google.com (mail-yb1-xb2c.google.com [IPv6:2607:f8b0:4864:20::b2c]) by atuin.qyliss.net (Postfix) with ESMTPS id C5027E46D for ; Thu, 11 Sep 2025 12:51:09 +0000 (UTC) Received: by mail-yb1-xb2c.google.com with SMTP id 3f1490d57ef6-e96dc26dfa2so511779276.1 for ; Thu, 11 Sep 2025 05:51:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1757595068; x=1758199868; darn=spectrum-os.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=NMQoPwpxZbhgrRkpcuGjOcyT2zWT44eNPbjuahrwpuo=; b=mlkR/0U0dMhZCsvlzGugWPgtwdUGNa1m/WfuoUX2Pg9qVb9ePE0jyLUdm2oeDWeLcw zHSnKhiSwPLVji4zipu/wFNMGPXVnuE0+A0Ex+5bceAg3NbWUAIQopLMf4oAfglnfpjP py/dbtyVEP6N2JUxKgTvGhak2VlAGu8vNdbQPtwEJ56cwF391ksGM1JxXuEzSisw8Har SmjLiJ4r9sxUZs7PGhfMg2W0NJiIiXrf3Sy37CwtJPHrAa37qm2N/naDFJSKxxL6ccwe 1ijPG3Niy6xCrt5rLk+5rgJeYJraLm28w0cusgHswEa0x5uS1a5ospoX6RHGKDPaYZH3 YkLg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1757595068; x=1758199868; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=NMQoPwpxZbhgrRkpcuGjOcyT2zWT44eNPbjuahrwpuo=; b=lZzHoVIU4yGRIG3rUMKVHRynfwlvRPWMOMhhUMeE/IuaA8UsrM1MmYTwtaLueDIGmd KMQc2EZ9VsH3fs0LDKgKRiuotA0uJZPwTKRXitJwW9OMbt9mYXINk06Xs7rRwQxY8P4M PDA7F7iUg2ymBDZlGzxOvziRG5tmuBaYHhspxYJYsx7bORfNF0zmsq+SjFW6HlndCU4b UrZD5hJGIG80jGfy19nJPi7u9ZyU786gWN2FKJ3osVt4bYU0pXudV0MjQNatw2RWEzk9 SebYFI9uIwCHqFYowGt10A+zwR1GP779pqwwF6T12rY7Hvruk5SneIrvoYNnjnbvo2/b TO8A== X-Gm-Message-State: AOJu0Yz4bKQSrfxbUPxbbd7pkzX2qvu9LEKQyLgDZOvaciQMfpBGdFz5 qiNApKF6FIOeEnN35m2W0v2OHgY8Ya/xAIlzgdKpYlgZ0yts/9hmKrCWOpfDcw== X-Gm-Gg: ASbGnctSTVjDokAHIT9OZz4bC/mrC9qg8NeehvNvS4YoYviq4SK1BH8UdICGkzkJBkP daD6L9dljlM0XRA8g+cgaFyhNPHHRpyuucv1z7qhFKOSTBOsriXHHbIZcSUuUE29LR5oquYBFTn PyWvbH529epiwG3DrAWauC5g+8bAeJ5XDh4Uf26vPoUSDv71oC4AGSpk5jQEBem1/aGicR3TDzf HlGEbYS8HrjHQFIjKG5dhCouuGerrSclOxXyEubDx/Vhh/1E52dhG6lVqrW9M9aUbbBbhehHRF+ wM0mT/QzLsqp9bRkwZZ4FE5vXO1wbU2sIniHdD0hm80LWYggzuMfPbn6qUbffPio0WSJyf/hc4m eS+m/Cs+6OdMV7D/m3Ui0S6zclQ6Uqz0KUjdF6I66NrXQnUctlTgd4Tzb8SStan+ljRs05doWB3 7etAoI49mR6D9LCPfQ6IUegfE9LB3CY3wXnXZI2Xn2Q0v2+30saZstDA== X-Google-Smtp-Source: AGHT+IFIueRr3wSbZzBLYtnHnTcKZAys7GUrqQIlZzROVZExXYbL5sqorjHcq3ObEKc5ggriSAy+fQ== X-Received: by 2002:a05:690e:d4a:b0:5f3:316d:1cf8 with SMTP id 956f58d0204a3-61027e48d0bmr13102236d50.23.1757595068316; Thu, 11 Sep 2025 05:51:08 -0700 (PDT) Received: from localhost.localdomain (h96-60-249-169.cncrtn.broadband.dynamic.tds.net. [96.60.249.169]) by smtp.gmail.com with UTF8SMTPSA id 956f58d0204a3-6247cbed5bdsm522213d50.1.2025.09.11.05.51.07 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 11 Sep 2025 05:51:07 -0700 (PDT) From: Demi Marie Obenour Date: Thu, 11 Sep 2025 08:47:44 -0400 Subject: [PATCH v3 1/4] Do not ignore errors from tar MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Message-Id: <20250911-genfiles-v3-1-d8709081dc5c@gmail.com> References: <20250911-genfiles-v3-0-d8709081dc5c@gmail.com> In-Reply-To: <20250911-genfiles-v3-0-d8709081dc5c@gmail.com> To: Spectrum OS Development X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=ed25519-sha256; t=1757594863; l=2372; i=demiobenour@gmail.com; s=20250729; h=from:subject:message-id; bh=RG94pGqGBw7lRSpJg3qLrZs1ucfvE4PXDIrwSaDCKCc=; b=HWlmk7eYcsQcy0lB7U5RJcoZb47EBvPbha0bLwv1HzQpNQUU8yT7n19/O7fPUARf4QxnzOSXX +sIMb3E8/5eDhaIUF/LOL20AVABfL+ffmEwnC7/4NG2FJAJr5tb5e4w X-Developer-Key: i=demiobenour@gmail.com; a=ed25519; pk=X57Q4/YQDj9t4SBeKaDwvXYKB6quZJVx/DE2Ly2out0= Message-ID-Hash: CFOFUTWVWYJ5DCGLCWB7HXNL6XUKPBKO X-Message-ID-Hash: CFOFUTWVWYJ5DCGLCWB7HXNL6XUKPBKO X-MailFrom: demiobenour@gmail.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-devel.spectrum-os.org-0; header-match-devel.spectrum-os.org-1; header-match-devel.spectrum-os.org-2; header-match-devel.spectrum-os.org-3; header-match-devel.spectrum-os.org-4; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: Demi Marie Obenour , Alyssa Ross X-Mailman-Version: 3.3.9 Precedence: list List-Id: Patches and low-level development discussion Archived-At: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: These would be ignored due to a missing -o pipefail in the shell script. As a result, listing nonexistent s6-rc-compile inputs would cause a broken image to be successfully built. Reported-by: Alyssa Ross Link: https://spectrum-os.org/lists/archives/spectrum-devel/87segu879h.fsf@alyssa.is Signed-off-by: Demi Marie Obenour --- host/rootfs/Makefile | 4 ++-- img/app/Makefile | 4 ++-- vm/sys/net/Makefile | 4 ++-- 3 files changed, 6 insertions(+), 6 deletions(-) diff --git a/host/rootfs/Makefile b/host/rootfs/Makefile index e96458dba06ae31129b115b2b649962f8d88187a..2288ae4d22ca817ba9fe8ebfc42326fe38b27c27 100644 --- a/host/rootfs/Makefile +++ b/host/rootfs/Makefile @@ -169,8 +169,8 @@ build/etc/s6-rc: $(S6_RC_FILES) mkdir -p $$(dirname $@) rm -rf $@ - dir=$$(mktemp -d) && \ - tar -c $(S6_RC_FILES) | tar -C $$dir -x --strip-components 2 && \ + set -uo pipefail; dir=$$(mktemp -d) || exit; \ + { tar -c $(S6_RC_FILES) | tar -C $$dir -x --strip-components 2; } && \ s6-rc-compile $@ $$dir; \ exit=$$?; rm -r $$dir; exit $$exit diff --git a/img/app/Makefile b/img/app/Makefile index 9665a6b7158f2d8b183831202a4559ae06d53d16..73db07cc4c781d9c41cdf41a6214298aae8de58a 100644 --- a/img/app/Makefile +++ b/img/app/Makefile @@ -117,8 +117,8 @@ build/etc/s6-rc: $(VM_S6_RC_FILES) mkdir -p $$(dirname $@) rm -rf $@ - dir=$$(mktemp -d) && \ - tar -c $(VM_S6_RC_FILES) | tar -C $$dir -x --strip-components 2 && \ + set -uo pipefail; dir=$$(mktemp -d) || exit; \ + { tar -c $(VM_S6_RC_FILES) | tar -C $$dir -x --strip-components 2; } && \ s6-rc-compile $@ $$dir; \ exit=$$?; rm -r $$dir; exit $$exit diff --git a/vm/sys/net/Makefile b/vm/sys/net/Makefile index 755b145175199aa97049dbd7feadc0e76230cf30..88ae20de79cd21b06263837f90310e8800b3d4e2 100644 --- a/vm/sys/net/Makefile +++ b/vm/sys/net/Makefile @@ -82,8 +82,8 @@ build/etc/s6-rc: $(VM_S6_RC_FILES) mkdir -p $$(dirname $@) rm -rf $@ - dir=$$(mktemp -d) && \ - tar -c $(VM_S6_RC_FILES) | tar -C $$dir -x --strip-components 2 && \ + set -uo pipefail; dir=$$(mktemp -d) || exit; \ + { tar -c $(VM_S6_RC_FILES) | tar -C $$dir -x --strip-components 2; } && \ s6-rc-compile $@ $$dir; \ exit=$$?; rm -r $$dir; exit $$exit -- 2.51.0