patches and low-level development discussion
 help / color / mirror / code / Atom feed
From: Demi Marie Obenour <demiobenour@gmail.com>
To: Spectrum OS Development <devel@spectrum-os.org>
Cc: Alyssa Ross <hi@alyssa.is>, Demi Marie Obenour <demiobenour@gmail.com>
Subject: [PATCH] tools/start-vmm: Add additional warning options
Date: Thu, 18 Sep 2025 15:06:27 -0400	[thread overview]
Message-ID: <20250918-more-c-warnings-1-v1-1-5fe4eaff8a30@gmail.com> (raw)

This detected a missing prototype.

No functional change.

Signed-off-by: Demi Marie Obenour <demiobenour@gmail.com>
---
 tools/meson.build    | 2 ++
 tools/start-vmm/ch.h | 1 +
 2 files changed, 3 insertions(+)

diff --git a/tools/meson.build b/tools/meson.build
index 9cebd03e323531fca7600cacf120161a98de16c5..8262f3e01d7bd56561306d7dd4650a22ca40ebe7 100644
--- a/tools/meson.build
+++ b/tools/meson.build
@@ -9,6 +9,8 @@ project('spectrum-tools', 'c',
   })
 
 add_project_arguments('-Wno-error=attributes', language : 'c')
+add_project_arguments('-Werror=missing-prototypes', language : 'c')
+add_project_arguments('-Werror=missing-declarations', language : 'c')
 
 if get_option('host')
   add_languages('rust')
diff --git a/tools/start-vmm/ch.h b/tools/start-vmm/ch.h
index 7230913ef0abf41a4f712ac4a543c7f7fdecec0f..5431365e6e2894cdebae22a9a44e2ccf1222e0d2 100644
--- a/tools/start-vmm/ch.h
+++ b/tools/start-vmm/ch.h
@@ -8,3 +8,4 @@ struct net_config {
 	char id[18];
 	uint8_t mac[6];
 };
+struct net_config net_setup(const char name[static 1], int name_len);

---
base-commit: edd53bb5dd9b682fec744d6df7921b64e0f56565
change-id: 20250918-more-c-warnings-1-239a405997c0
-- 
Sincerely,
Demi Marie Obenour (she/her/hers)


             reply	other threads:[~2025-09-18 19:07 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-09-18 19:06 Demi Marie Obenour [this message]
2025-09-19 11:55 ` [PATCH] tools/start-vmm: Add additional warning options Alyssa Ross
2025-09-19 19:38   ` Demi Marie Obenour
2025-09-21  8:55     ` Alyssa Ross
2025-09-21 15:57       ` Demi Marie Obenour
2025-09-21 16:13         ` Alyssa Ross
2025-09-21 16:14           ` Demi Marie Obenour
2025-09-21 16:17             ` Alyssa Ross
2025-09-21 16:18               ` Demi Marie Obenour
2025-09-23 18:54 ` Alyssa Ross

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250918-more-c-warnings-1-v1-1-5fe4eaff8a30@gmail.com \
    --to=demiobenour@gmail.com \
    --cc=devel@spectrum-os.org \
    --cc=hi@alyssa.is \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://spectrum-os.org/git/crosvm
	https://spectrum-os.org/git/doc
	https://spectrum-os.org/git/mktuntap
	https://spectrum-os.org/git/nixpkgs
	https://spectrum-os.org/git/spectrum
	https://spectrum-os.org/git/ucspi-vsock
	https://spectrum-os.org/git/www

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).